Page MenuHomePhabricator
Create Task
Maniphest T397582

Recent changes in REL1_43: Special:AllComments no longer available; comments show on both namespace and talk page
Closed, ResolvedPublicBUG REPORT
Actions

Description

The latest commit "62d026a" broke the StoreModule logic of CommentStreams.
Prior to this, $wgCommentStreamsStoreModel was supposed to use the default value "
namespace-page", but after this commit, all comments were changed to default to TalkPageStore storage format. Even when I manually specified "wgCommentStreamsStoreModel", it couldn't be corrected
I noticed the latest commits in REL1_43 might have caused some porblems. Special:AllComments is no longer available, and comments will show on both a namespace and its talk page (for example: user page and its talk page), I'm not sure if these are expected behaviors.

image.png (587×1 px, 311 KB)

image.png (776×1 px, 390 KB)

image.png (805×1 px, 426 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Separate talk page comments if talk namespace is in $wgCommentStreamsAllowedNamespacesmediawiki/extensions/CommentStreamsREL1_44+4 -2
Separate talk page comments if talk namespace is in $wgCommentStreamsAllowedNamespacesmediawiki/extensions/CommentStreamsREL1_45+4 -2
Separate talk page comments if talk namespace is in $wgCommentStreamsAllowedNamespacesmediawiki/extensions/CommentStreamsmaster+4 -2
Fix associatedId not always corresponding to the page comments are shown formediawiki/extensions/CommentStreamsREL1_43+3 -2
Fix associatedId not always corresponding to the page comments are shown formediawiki/extensions/CommentStreamsREL1_44+3 -2
Fix associatedId not always corresponding to the page comments are shown formediawiki/extensions/CommentStreamsmaster+3 -2
Customize query in gerrit

Related Objects

Event Timeline

Zorua_Fox created this task.Jun 22 2025, 1:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2025, 1:44 PM
Zorua_Fox added a subscriber: Dsavuljesku.Jun 22 2025, 1:45 PM
Zorua_Fox added a comment.EditedJun 22 2025, 1:48 PM

@Dsavuljesku and @Osnard merged that change (62d026a) and cherry picked this commit into master branch, please be advised.

Zorua_Fox closed this task as Invalid.Jun 22 2025, 1:52 PM
This comment was removed by Zorua_Fox.
Zorua_Fox reopened this task as Open.Jun 22 2025, 1:54 PM
Zorua_Fox added a comment.Jun 22 2025, 2:01 PM
This comment was removed by Zorua_Fox.
Zorua_Fox renamed this task from Latest changes borke CommentStreams' StoreModule to Latest changes in REL1_43.Jun 22 2025, 2:08 PM
Zorua_Fox renamed this task from Latest changes in REL1_43 to About latest changes in REL1_43.
Zorua_Fox renamed this task from About latest changes in REL1_43 to About the latest changes in REL1_43.
Zorua_Fox updated the task description. (Show Details)
Zorua_Fox updated the task description. (Show Details)Jun 22 2025, 2:11 PM
Zorua_Fox updated the task description. (Show Details)EditedJun 22 2025, 2:35 PM

and comments will show on both a namespace and its talk page (for example: user page and its talk page)

I found this issue on namespace id 2 only, my configurations are in https://github.com/TopRealm/YsArchives-Extensions/blob/ef502c4245aaeb8ba80a69808a97d78df194789e/LoadExtensions.php#L85

Zorua_Fox updated the task description. (Show Details)Jun 22 2025, 2:40 PM
Aklapper renamed this task from About the latest changes in REL1_43 to Recent changes in REL1_43: Special:AllComments no longer available; comments show on both namespace and talk page.Jun 22 2025, 3:45 PM
Osnard added a subscriber: cicalese.Jun 23 2025, 7:01 AM

Hi!

First of all, my apologies for the inconvenience. I'd like to provide some context.

At the beginning of 2025, the BlueSpice team took over maintenance for Extension:CommentStreams, in order to ensure MediaWiki 1.43 compatibility and to add some new features. During the discussion with the original author and maintainer @cicalese, we decided to remove Special:AllComments. Therefore, we made a major version release (9.0) to indicate breaking changes. While we properly bumped the version number in extension.json, I have to admit, we did not add a tag yet. Also there are no official release notes for 9.0 yet. Again, my apologies.

Maybe you can help me understand your use case of Special:AllComments? Having a list of all comments in the wiki without much context about the actual thing (wikipage) they are about didn't seem very helpful.

Regarding the "comments show up on both, subject and talk page (at least in NS_USER)": Thanks for reporting, I will have a look.

FTR: I don't think rECOS62d026a5db46 is related to this topic.

Zorua_Fox added a comment.Jun 23 2025, 7:18 AM

@Osnard Thank you very much for your answer. Special:AllComments is not widely used; I only discovered that this Special page was removed in a certain version while deploying CommentStreams. However, the documentation on MediaWiki.org has not been updated, so I came here specifically to ask.

The commit previous mentioned was incorrectly cited, and I sincerely apologize for any inconvenience caused. Thanks again to the BlueSpice team and the developers involved for their contributions to this extension.

Osnard added a comment.Jul 29 2025, 7:01 AM

In the meantime 9.0 has been released. Can we close this ticket?

Zorua_Fox closed this task as Resolved.Jul 29 2025, 10:03 AM
Zorua_Fox claimed this task.
SomeRandomDeveloper reopened this task as Open.Sep 25 2025, 1:03 PM
SomeRandomDeveloper claimed this task.
SomeRandomDeveloper added projects: affects-Miraheze, Regression.
SomeRandomDeveloper subscribed.

comments will show on both a namespace and its talk page (for example: user page and its talk page)

This part of the task was not fixed (downstream task). This is caused by the following code: https://gerrit.wikimedia.org/g/mediawiki/extensions/CommentStreams/+/d0512294a15f0bd51f78e74d94e63f0424d8c80f/includes/CommentStreamsHandler.php#258

Additionally, commenting on a talk page causes the comment to get lost as it will be associated with the talk page, but the comments displayed will only be the ones associated to the subject page.

I'll upload two patches shortly.

gerritbot added a comment.Sep 25 2025, 1:06 PM

Change #1191394 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/extensions/CommentStreams@master] Fix associatedId not always corresponding to the page comments are shown for

https://gerrit.wikimedia.org/r/1191394

gerritbot added a project: Patch-For-Review.Sep 25 2025, 1:06 PM
gerritbot added a comment.Sep 25 2025, 1:12 PM

Change #1191396 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/extensions/CommentStreams@master] Separate talk page comments if talk namespace is in $wgCommentStreamsAllowedNamespaces

https://gerrit.wikimedia.org/r/1191396

SomeRandomDeveloper added a comment.Sep 25 2025, 1:18 PM

The first patchset fixes a bug where comments are associated with the wrong page on talk pages, while the second one allows having separate talk page comments, but it should be backwards-compatible and not change the behavior of the extension unless talk namespaces are listed in $wgCommentStreamsAllowedNamespaces.

gerritbot added a comment.Sep 25 2025, 1:52 PM

Change #1191417 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/extensions/CommentStreams@REL1_44] Fix associatedId not always corresponding to the page comments are shown for

https://gerrit.wikimedia.org/r/1191417

gerritbot added a comment.Sep 25 2025, 1:52 PM

Change #1191418 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/extensions/CommentStreams@REL1_43] Fix associatedId not always corresponding to the page comments are shown for

https://gerrit.wikimedia.org/r/1191418

gerritbot added a comment.Oct 3 2025, 2:20 PM

Change #1191394 merged by Paladox:

[mediawiki/extensions/CommentStreams@master] Fix associatedId not always corresponding to the page comments are shown for

https://gerrit.wikimedia.org/r/1191394

Paladox mentioned this in rECOS9c1543183259: Fix associatedId not always corresponding to the page comments are shown for.Oct 3 2025, 2:23 PM
gerritbot added a comment.Oct 3 2025, 2:23 PM

Change #1191417 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@REL1_44] Fix associatedId not always corresponding to the page comments are shown for

https://gerrit.wikimedia.org/r/1191417

gerritbot added a comment.Oct 3 2025, 2:24 PM

Change #1191418 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@REL1_43] Fix associatedId not always corresponding to the page comments are shown for

https://gerrit.wikimedia.org/r/1191418

SomeRandomDeveloper mentioned this in rECOS31badb5c4ddb: Fix associatedId not always corresponding to the page comments are shown for.Oct 3 2025, 2:24 PM
SomeRandomDeveloper mentioned this in rECOS09f775ce8704: Fix associatedId not always corresponding to the page comments are shown for.
gerritbot added a comment.Nov 7 2025, 9:22 AM

Change #1191396 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@master] Separate talk page comments if talk namespace is in $wgCommentStreamsAllowedNamespaces

https://gerrit.wikimedia.org/r/1191396

jenkins-bot mentioned this in rECOS1ecf605e46bd: Separate talk page comments if talk namespace is in….Nov 7 2025, 9:23 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 7 2025, 9:30 AM
gerritbot added a comment.Nov 7 2025, 12:54 PM

Change #1203006 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/extensions/CommentStreams@REL1_45] Separate talk page comments if talk namespace is in $wgCommentStreamsAllowedNamespaces

https://gerrit.wikimedia.org/r/1203006

gerritbot added a project: Patch-For-Review.Nov 7 2025, 12:54 PM

Change #1203007 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/extensions/CommentStreams@REL1_44] Separate talk page comments if talk namespace is in $wgCommentStreamsAllowedNamespaces

https://gerrit.wikimedia.org/r/1203007

gerritbot added a comment.Nov 7 2025, 1:00 PM

Change #1203006 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@REL1_45] Separate talk page comments if talk namespace is in $wgCommentStreamsAllowedNamespaces

https://gerrit.wikimedia.org/r/1203006

SomeRandomDeveloper mentioned this in rECOS23b6a93bafaa: Separate talk page comments if talk namespace is in….Nov 7 2025, 1:00 PM
gerritbot added a comment.Nov 7 2025, 1:00 PM

Change #1203007 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@REL1_44] Separate talk page comments if talk namespace is in $wgCommentStreamsAllowedNamespaces

https://gerrit.wikimedia.org/r/1203007

SomeRandomDeveloper mentioned this in rECOSffafce5bfa7b: Separate talk page comments if talk namespace is in….Nov 7 2025, 1:01 PM
SomeRandomDeveloper closed this task as Resolved.Nov 7 2025, 1:02 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 7 2025, 1:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits