Page MenuHomePhabricator
Create Task
Maniphest T397632

💡 Ensure ?language query param determines both search language and result language
Closed, ResolvedPublic
Actions

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Search: Always return prefix search results in search languagemediawiki/extensions/Wikibasemaster+45 -10
Extract EntitySearchHelperFactorymediawiki/extensions/WikibaseCirrusSearchmaster+80 -22
Add result language param to EntitySearchHelpermediawiki/extensions/Wikibasemaster+10 -7
Add $resultLanguage param to EntitySearchElasticmediawiki/extensions/WikibaseCirrusSearchmaster+6 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Jun 23 2025, 2:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2025, 2:36 PM
Jakob_WMDE claimed this task.Jun 23 2025, 2:42 PM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 47) board.
gerritbot added a comment.Jun 23 2025, 2:57 PM

Change #1162925 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseCirrusSearch@master] Add $resultLanguage param to EntitySearchElastic

https://gerrit.wikimedia.org/r/1162925

gerritbot added a project: Patch-For-Review.Jun 23 2025, 2:57 PM
gerritbot added a comment.Jun 23 2025, 3:19 PM

Change #1162934 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Add result language param to EntitySearchHelper

https://gerrit.wikimedia.org/r/1162934

Ifrahkhanyaree_WMDE edited projects, added Wikibase Reuse Team (Sprint 48); removed Wikibase Reuse Team (Sprint 47).Jun 24 2025, 10:25 AM
Ifrahkhanyaree_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 48) board.
gerritbot added a comment.Jun 25 2025, 2:24 PM

Change #1163796 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseCirrusSearch@master] Extract EntitySearchHelperFactory

https://gerrit.wikimedia.org/r/1163796

gerritbot added a comment.Jun 25 2025, 3:06 PM

Change #1163811 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Search: Always return prefix search results in search language

https://gerrit.wikimedia.org/r/1163811

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Reuse Team (Sprint 48) board.Jun 25 2025, 3:30 PM
gerritbot added a comment.Jun 26 2025, 2:50 PM

Change #1162925 abandoned by Jakob:

[mediawiki/extensions/WikibaseCirrusSearch@master] Add $resultLanguage param to EntitySearchElastic

Reason:

went with a different approach

https://gerrit.wikimedia.org/r/1162925

gerritbot added a comment.Jun 26 2025, 2:50 PM

Change #1162934 abandoned by Jakob:

[mediawiki/extensions/Wikibase@master] Add result language param to EntitySearchHelper

https://gerrit.wikimedia.org/r/1162934

gerritbot added a comment.Jun 27 2025, 11:43 AM

Change #1163796 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Extract EntitySearchHelperFactory

https://gerrit.wikimedia.org/r/1163796

gerritbot added a comment.Jun 27 2025, 11:45 AM

Change #1163811 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Search: Always return prefix search results in search language

https://gerrit.wikimedia.org/r/1163811

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.8; 2025-07-01).Jun 27 2025, 12:00 PM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Reuse Team (Sprint 48) board.Jun 27 2025, 12:09 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 27 2025, 12:30 PM
Physikerwelt mentioned this in T398144: mediawiki-quibble-apitests-vendor-php81 fail for extension math.Jul 3 2025, 4:44 AM
Ifrahkhanyaree_WMDE closed this task as Resolved.Jul 7 2025, 9:06 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits