Page MenuHomePhabricator
Create Task
Maniphest T397643

Make configuration of min edits optional in voter eligbility
Closed, ResolvedPublic
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Try to save voter eligibility settings for an election, leave the "Mininum edits" blank.

What happens?:
Form validation error:

Screenshot 2025-06-23 at 9.30.08 PM.png (1×1 px, 156 KB)

What should have happened instead?:
No form validation error. It should be possible to configure an election without an editcount requirement.

Other information
The backend checking logic in Election::getQualifiedStatus already treats min-edits as an optional configuration.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
htmlform: fix min/max validations on empty input in int/float fieldsmediawiki/coreREL1_43+3 -0
htmlform: fix min/max validations on empty input in int/float fieldsmediawiki/coreREL1_44+3 -0
htmlform: fix min/max validations on empty input in int/float fieldsmediawiki/coreREL1_42+3 -0
htmlform: fix min/max validations on empty input in int/float fieldsmediawiki/coreREL1_39+3 -0
htmlform: fix min/max validations on empty input in int/float fieldsmediawiki/coremaster+3 -0
VoterEligibilityPage: make edit count optionalmediawiki/extensions/SecurePollmaster+0 -1
htmlform: fix min/max validations on empty input in int/float fieldsmediawiki/coremaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

SD0001 created this task.Jun 23 2025, 4:05 PM
Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptJun 23 2025, 4:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
SD0001 changed the subtype of this task from "Bug Report" to "Task".Jun 23 2025, 4:06 PM
SD0001 mentioned this in T397596: Voter eligibility page - allow configuring "disallow everyone except these user groups".
SD0001 updated the task description. (Show Details)Jun 23 2025, 4:08 PM
gerritbot added a comment.Jun 23 2025, 5:05 PM

Change #1162974 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/extensions/SecurePoll@master] Make edit count optional in voter eligibility settings

https://gerrit.wikimedia.org/r/1162974

gerritbot added a project: Patch-For-Review.Jun 23 2025, 5:05 PM
Novem_Linguae mentioned this in T397883: allow HTMLIntField to have a minimum of 0 OR be blank.Jun 25 2025, 9:38 PM
gerritbot added a comment.Jun 28 2025, 9:58 AM

Change #1164551 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/core@master] htmlform: allow optional int and float fields to specify min value

https://gerrit.wikimedia.org/r/1164551

gerritbot added a comment.Jun 28 2025, 10:37 AM

Change #1164552 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/core@master] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164552

gerritbot added a comment.Jun 28 2025, 10:40 AM

Change #1164552 abandoned by SD0001:

[mediawiki/core@master] htmlform: fix min/max validations on empty input in int/float fields

Reason:

accidentally created duplicate of I37be8455

https://gerrit.wikimedia.org/r/1164552

gerritbot added a comment.Jun 28 2025, 12:03 PM

Change #1162974 abandoned by SD0001:

[mediawiki/extensions/SecurePoll@master] VoterEligibilityPage: make edit count optional

Reason:

I37be8455 was merged instead

https://gerrit.wikimedia.org/r/1162974

gerritbot added a comment.Jun 28 2025, 12:11 PM

Change #1164551 merged by jenkins-bot:

[mediawiki/core@master] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164551

Maintenance_bot removed a project: Patch-For-Review.Jun 28 2025, 12:30 PM
Novem_Linguae closed this task as Resolved.Jun 28 2025, 12:32 PM
Novem_Linguae assigned this task to SD0001.
gerritbot added a comment.Jun 28 2025, 12:49 PM

Change #1164612 had a related patch set uploaded (by Umherirrender; author: SD0001):

[mediawiki/core@REL1_44] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164612

gerritbot added a project: Patch-For-Review.Jun 28 2025, 12:49 PM

Change #1164613 had a related patch set uploaded (by Umherirrender; author: SD0001):

[mediawiki/core@REL1_43] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164613

gerritbot added a comment.Jun 28 2025, 12:49 PM

Change #1164614 had a related patch set uploaded (by Umherirrender; author: SD0001):

[mediawiki/core@REL1_42] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164614

gerritbot added a comment.Jun 28 2025, 12:50 PM

Change #1164615 had a related patch set uploaded (by Umherirrender; author: SD0001):

[mediawiki/core@REL1_39] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164615

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.8; 2025-07-01).Jun 28 2025, 1:00 PM
gerritbot added a comment.Jun 28 2025, 1:21 PM

Change #1164615 merged by jenkins-bot:

[mediawiki/core@REL1_39] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164615

gerritbot added a comment.Jun 28 2025, 1:23 PM

Change #1164614 merged by jenkins-bot:

[mediawiki/core@REL1_42] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164614

gerritbot added a comment.Jun 28 2025, 1:26 PM

Change #1164612 merged by jenkins-bot:

[mediawiki/core@REL1_44] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164612

gerritbot added a comment.Jun 28 2025, 1:27 PM

Change #1164613 merged by jenkins-bot:

[mediawiki/core@REL1_43] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164613

Maintenance_bot removed a project: Patch-For-Review.Jun 28 2025, 1:31 PM
ReleaseTaggerBot added projects: MW-1.39-notes, MW-1.42-notes, MW-1.44-notes, MW-1.43-notes.Jun 28 2025, 2:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits