Page MenuHomePhabricator

Teleport Menus so they're always on top of everything else (part 1)
Closed, ResolvedPublic3 Estimated Story Points

Description

Note: this ticket was not completed during the sprint. The follow up ticket T405746: Codex: Teleport Menus by default (part 2) resolves the remaining pieces.

Just like Dialogs, Menus should automatically teleport if a TeleportTarget is provided. This would avoid menus getting cut off by things like sticky headers, as seen at T379836#10823078. It would also help with (but not entirely fix) T379947.

For Menus inside Dialogs, teleportation alone doesn't guarantee that the Menu will appear on top of the Dialog if both are teleported. For this case we will probably have to have each Dialog create its own teleport target and provide that to the components inside it.

The Reader Experience team will provide code review.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@ovasileva I'd recommend we add 3 points for code review and put this in "ready for sprint" so we can pull it in if we have time, once Roan has created the patch. Does that work for you?

Change #1170619 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] Dialog, Popover: Support template ref as teleport target

https://gerrit.wikimedia.org/r/1170619

Change #1170620 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] useFloatingMenu: Pass in reference HTMLElement to autoUpdate() directly

https://gerrit.wikimedia.org/r/1170620

Change #1170621 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] Menu, Dialog: Teleport menus by default

https://gerrit.wikimedia.org/r/1170621

AnneT set the point value for this task to 3.Jul 21 2025, 4:12 PM
AnneT moved this task from Needs refinement to Ready for sprint on the Reader Experience Team board.
AnneT updated the task description. (Show Details)

Change #1170619 merged by jenkins-bot:

[design/codex@main] Dialog, Popover: Support template ref as teleport target

https://gerrit.wikimedia.org/r/1170619

Change #1170620 merged by jenkins-bot:

[design/codex@main] useFloatingMenu: Pass in reference HTMLElement to autoUpdate() directly

https://gerrit.wikimedia.org/r/1170620

Change #1170621 merged by jenkins-bot:

[design/codex@main] Menu, Dialog: Teleport menus by default

https://gerrit.wikimedia.org/r/1170621

Change #1178961 had a related patch set uploaded (by LorenMora; author: LorenMora):

[mediawiki/core@master] Update Codex from v2.2.1 to v2.3.0

https://gerrit.wikimedia.org/r/1178961

Test wiki created on Patch demo by LMora-WMF using patch(es) linked to this task:
https://52ad408a3b.catalyst.wmcloud.org/w/

Change #1178961 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v2.2.1 to v2.3.0

https://gerrit.wikimedia.org/r/1178961

FTR, this broke at least one browser test, and I wouldn’t be surprised if there are more (“type into the input, then click the .cdx-menu--enabled descendant of the lookup” feels like it would be a reasonably common pattern when browser-testing Codex-based lookups/menus/etc.) – see T402021: Wikibase CI broken: NewLexeme:Page - shows the form and creating a lexeme is possible for how we’re fixing it in WikibaseLexeme (though I’m sure there are other approaches to do it too).

Change #1180982 had a related patch set uploaded (by LorenMora; author: LorenMora):

[mediawiki/core@master] Update Codex from v2.2.1 to v2.3.1

https://gerrit.wikimedia.org/r/1180982

Test wiki created on Patch demo by LMora-WMF using patch(es) linked to this task:
https://590db65713.catalyst.wmcloud.org/w/

Change #1180982 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v2.2.1 to v2.3.1

https://gerrit.wikimedia.org/r/1180982

Test wiki on Patch demo by LMora-WMF using patch(es) linked to this task was deleted:

https://590db65713.catalyst.wmcloud.org/w/

Test wiki on Patch demo by LMora-WMF using patch(es) linked to this task was deleted:

https://52ad408a3b.catalyst.wmcloud.org/w/

Change #1189332 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Codex: Teleport Menus by default

https://gerrit.wikimedia.org/r/1189332

Jdlrobson-WMF subscribed.

Tasks in archived sprints get lost in Phabricator and it becomes unclear what work is remaining when work has been done so i've opened a new task: T405746

Jdlrobson-WMF renamed this task from Teleport Menus so they're always on top of everything else to Teleport Menus so they're always on top of everything else (part 1).Oct 3 2025, 10:47 PM
Jdlrobson-WMF updated the task description. (Show Details)