Page MenuHomePhabricator
Create Task
Maniphest T397808

Change favorite notifications from 'success' type to 'info'
Closed, ResolvedPublic
Actions

Description

As brought up in T390019#10945763, 'success' type notifications shouldn't be used after favoriting or unfavoriting a template. Instead, 'info' should be used.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ext.templateData.templateDiscovery: use `info` mw.notifymediawiki/extensions/TemplateDatamaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Samwilson created this task.Jun 25 2025, 5:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 25 2025, 5:28 AM
Maintenance_bot added a project: VisualEditor.Jun 25 2025, 5:29 AM
Samwilson mentioned this in T390019: Add favorite button next to watch star on template pages.Jun 25 2025, 5:37 AM
Samwilson edited projects, added Community-Tech (Fox Squad); removed VisualEditor.Jun 25 2025, 12:55 PM
Maintenance_bot added a project: VisualEditor.Jun 25 2025, 1:29 PM
TheresNoTime claimed this task.Jun 26 2025, 10:35 AM
TheresNoTime moved this task from Ready for Dev to In Development on the Community-Tech (Fox Squad) board.
gerritbot added a comment.Jun 26 2025, 10:36 AM

Change #1164143 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/TemplateData@master] ext.templateData.templateDiscovery: use `info` mw.notify

https://gerrit.wikimedia.org/r/1164143

gerritbot added a project: Patch-For-Review.Jun 26 2025, 10:36 AM
TheresNoTime moved this task from In Development to Feedback and Review on the Community-Tech (Fox Squad) board.Jun 26 2025, 10:40 AM
gerritbot added a comment.Jun 26 2025, 11:34 AM

Change #1164143 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] ext.templateData.templateDiscovery: use `info` mw.notify

https://gerrit.wikimedia.org/r/1164143

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.8; 2025-07-01).Jun 26 2025, 12:01 PM
TheresNoTime moved this task from Feedback and Review to QA on the Community-Tech (Fox Squad) board.Jun 26 2025, 12:08 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 26 2025, 12:30 PM
dom_walden closed this task as Resolved.Aug 7 2025, 2:50 PM
dom_walden subscribed.

The toast notification when favouriting or unfavouriting is now white.

white_notification.png (730×1 px, 79 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits