Page MenuHomePhabricator
Create Task
Maniphest T397818

"Invalid response from server" when switching to VE source mode
Closed, ResolvedPublicBUG REPORT
Actions

Description

This might be a train blocker for T392177: 1.45.0-wmf.7 deployment blockers because I can reproduce the following issue on 1.45.0-wmf.7 (e.g. mediawiki.org) but not on 1.45.0-wmf.6 (e.g. dewiki).

Steps to reproduce:

  • Make sure you have the preference enabled to "use the wikitext mode inside the visual editor".
  • Start editing any article in VisualEditor.
  • Make at least one change, e.g. add a character.
  • Switch to source editing with one of the two methods available in the toolbar(s) at the top.
  • A popup appears: "Invalid response from server."
  • When I click "Try again" the code apparently does not try to do the same again but does a different API request in the background. As a result the edit I just did gets lost.

We have also seen the wikitext disappear completely when switching to the classic wikitext editor instead.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ArticleTarget: Avoid using chained promises with different return valuesmediawiki/extensions/VisualEditormaster+4 -2
ArticleTarget: Avoid using chained promises with different return valuesmediawiki/extensions/VisualEditorwmf/1.45.0-wmf.7+4 -2
[POC] Fix .then() in ArticleTarget dropping the return valuemediawiki/extensions/VisualEditormaster+4 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasejeenaT392177 1.45.0-wmf.7 deployment blockers
 ResolvedBUG REPORTEsandersT397818 "Invalid response from server" when switching to VE source mode

Event Timeline

thiemowmde created this task.Jun 25 2025, 9:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 25 2025, 9:09 AM
thiemowmde added a parent task: T392177: 1.45.0-wmf.7 deployment blockers.Jun 25 2025, 9:10 AM
thiemowmde renamed this task from Unrecognized parameter: editingStatsId in visualeditoredit API to "Invalid response from server" when switching to VE source mode.Jun 25 2025, 9:21 AM
thiemowmde updated the task description. (Show Details)Jun 25 2025, 9:26 AM
matmarex subscribed.Jun 25 2025, 10:08 AM

The use of editingStatsId emitting a warning can't be related, it has been that way for many years (I know, I know…).

I saw a lot of refactoring happening in mediawiki/extensions/VisualEditor to use newer JS features, maybe one of those changes broke something.

matmarex added a comment.EditedJun 25 2025, 10:21 AM

We have also seen the wikitext disappear completely but are not able to reproduce it.

I can reproduce this when switching to non-VE source mode with changes in the editor. This is definitely a deployment blocker.

matmarex added a comment.Jun 25 2025, 10:25 AM

Reverting 1141439 Fix no-jquery/no-done-fail warnings fixes this for me, so that would be an option to unblock the train. It's a large change and I haven't tried to find where exactly the mistake is.

gerritbot added a comment.Jun 25 2025, 12:51 PM

Change #1163765 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] [POC] Fix .then() in ArticleTarget dropping the return value

https://gerrit.wikimedia.org/r/1163765

gerritbot added a project: Patch-For-Review.Jun 25 2025, 12:51 PM
thiemowmde added a comment.Jun 25 2025, 12:53 PM

@matmarex Yea, I can confirm this. I made a patch to illustrate what I found, see https://gerrit.wikimedia.org/r/1163765. Personally I think it's better to revert the entire patch. It seems this is still possible with no conflict.

thiemowmde triaged this task as Unbreak Now! priority.Jun 25 2025, 1:00 PM
thiemowmde updated the task description. (Show Details)
gerritbot added a comment.Jun 25 2025, 1:07 PM

Change #1163767 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] ArticleTarget: Avoid using chained promises with different return values

https://gerrit.wikimedia.org/r/1163767

Esanders added a comment.Jun 25 2025, 1:09 PM

This was identified in my code review of the original patch but somehow I missed it when reviewing the second time. My patch above fixes by just removing the chaining.

gerritbot added a comment.Jun 25 2025, 1:10 PM

Change #1163768 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.7] ArticleTarget: Avoid using chained promises with different return values

https://gerrit.wikimedia.org/r/1163768

gerritbot added a comment.Jun 25 2025, 1:13 PM

Change #1163765 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/VisualEditor@master] [POC] Fix .then() in ArticleTarget dropping the return value

Reason:

See I842483c.

https://gerrit.wikimedia.org/r/1163765

gerritbot added a comment.Jun 25 2025, 1:59 PM

Change #1163768 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.7] ArticleTarget: Avoid using chained promises with different return values

https://gerrit.wikimedia.org/r/1163768

Stashbot added a comment.Jun 25 2025, 1:59 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-25T13:59:31Z] <esanders@deploy1003> Started scap sync-world: Backport for [[gerrit:1163768|ArticleTarget: Avoid using chained promises with different return values (T397818)]]

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.7; 2025-06-24).Jun 25 2025, 2:00 PM
Stashbot added a comment.Jun 25 2025, 2:01 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-25T14:01:57Z] <esanders@deploy1003> esanders: Backport for [[gerrit:1163768|ArticleTarget: Avoid using chained promises with different return values (T397818)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Jun 25 2025, 2:11 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-25T14:11:11Z] <esanders@deploy1003> Finished scap sync-world: Backport for [[gerrit:1163768|ArticleTarget: Avoid using chained promises with different return values (T397818)]] (duration: 11m 40s)

gerritbot added a comment.Jun 25 2025, 2:26 PM

Change #1163767 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ArticleTarget: Avoid using chained promises with different return values

https://gerrit.wikimedia.org/r/1163767

Maintenance_bot removed a project: Patch-For-Review.Jun 25 2025, 2:30 PM
ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.8; 2025-07-01); removed MW-1.45-notes (1.45.0-wmf.7; 2025-06-24).Jun 25 2025, 3:00 PM
matmarex closed this task as Resolved.Jun 26 2025, 1:18 AM
matmarex assigned this task to Esanders.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits