Page MenuHomePhabricator
Create Task
Maniphest T397867

Update entity layer to handle the new country schema
Closed, ResolvedPublic
Actions

Description

Acceptance criteria

  • Update the entity layer (EventRegistration, Address, EventFactory) to handle the new country schema
  • This should work for all possible values of the migration flag

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Daimona created this task.Jun 25 2025, 6:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 25 2025, 6:28 PM
Daimona claimed this task.Jun 25 2025, 6:28 PM
Daimona mentioned this in T397476: Country of event data migration (free text -> code; optional -> required; remove country from address).
Daimona added a parent task: T397476: Country of event data migration (free text -> code; optional -> required; remove country from address).
Daimona moved this task from Upcoming / refining 💡 to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.
gerritbot added a comment.Jun 25 2025, 6:31 PM

Change #1163848 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Introduce a value object to represent addresses

https://gerrit.wikimedia.org/r/1163848

gerritbot added a project: Patch-For-Review.Jun 25 2025, 6:31 PM
gerritbot added a comment.Jun 25 2025, 9:50 PM

Change #1163892 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Use Address objects directly in EventRegistration

https://gerrit.wikimedia.org/r/1163892

gerritbot added a comment.Jun 25 2025, 10:00 PM

Change #1163893 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Drop address and country direct getters from EventRegistration

https://gerrit.wikimedia.org/r/1163893

gerritbot added a comment.Jun 26 2025, 5:52 PM

Change #1164282 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Include country in the address in the registration header

https://gerrit.wikimedia.org/r/1164282

gerritbot added a comment.Jun 26 2025, 6:27 PM

Change #1164289 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Use address without country when guessing string direction

https://gerrit.wikimedia.org/r/1164289

gerritbot added a comment.Jun 26 2025, 9:49 PM

Change #1164288 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Introduce Address::toString()

https://gerrit.wikimedia.org/r/1164288

Daimona moved this task from Development In Progress 💻 to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.Jun 26 2025, 10:12 PM
Daimona moved this task from Code Review 💬 to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.Jun 27 2025, 1:27 PM
gerritbot added a comment.Jun 29 2025, 11:24 PM

Change #1163848 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Introduce a value object to represent addresses

https://gerrit.wikimedia.org/r/1163848

gerritbot added a comment.Jun 29 2025, 11:46 PM

Change #1163892 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Use Address objects directly in EventRegistration

https://gerrit.wikimedia.org/r/1163892

gerritbot added a comment.Jun 29 2025, 11:46 PM

Change #1164289 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Use address without country when guessing string direction

https://gerrit.wikimedia.org/r/1164289

gerritbot added a comment.Jun 29 2025, 11:56 PM

Change #1164282 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Include country in the address in the registration header

https://gerrit.wikimedia.org/r/1164282

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.8; 2025-07-01).Jun 30 2025, 12:00 AM
gerritbot added a comment.Jun 30 2025, 2:01 AM

Change #1163893 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Drop address and country direct getters from EventRegistration

https://gerrit.wikimedia.org/r/1163893

gerritbot added a comment.Jun 30 2025, 2:26 PM

Change #1164288 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Introduce Address::toString()

https://gerrit.wikimedia.org/r/1164288

Maintenance_bot removed a project: Patch-For-Review.Jun 30 2025, 2:30 PM
gerritbot added a comment.Jul 4 2025, 1:33 PM

Change #1166398 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Make EventFormatter a proper service

https://gerrit.wikimedia.org/r/1166398

gerritbot added a project: Patch-For-Review.Jul 4 2025, 1:33 PM
gerritbot added a comment.Jul 4 2025, 2:04 PM

Change #1166402 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Add EventFormatter::formatAddress, drop Address::toString

https://gerrit.wikimedia.org/r/1166402

Daimona updated the task description. (Show Details)Jul 4 2025, 2:15 PM
gerritbot added a comment.Jul 4 2025, 2:53 PM

Change #1166397 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Add country code to Address and use it for formatting

https://gerrit.wikimedia.org/r/1166397

gerritbot added a comment.Jul 4 2025, 4:04 PM

Change #1166413 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Add event country code to EventFactory

https://gerrit.wikimedia.org/r/1166413

Daimona added parent tasks: T397276: Update APIs to handle the new country code field, T397271: Add the new country drop-down field on Special:EnableEventRegistration and Special:EditEventRegistration.Jul 4 2025, 4:06 PM
gerritbot added a comment.Jul 7 2025, 2:57 PM

Change #1166398 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Make EventFormatter a proper service

https://gerrit.wikimedia.org/r/1166398

gerritbot added a comment.Jul 7 2025, 2:57 PM

Change #1166402 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add EventFormatter::formatAddress, drop Address::toString

https://gerrit.wikimedia.org/r/1166402

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.9; 2025-07-08); removed MW-1.45-notes (1.45.0-wmf.8; 2025-07-01).Jul 7 2025, 3:00 PM
Daimona moved this task from Development In Progress 💻 to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.Jul 8 2025, 6:48 PM
gerritbot added a comment.Jul 11 2025, 9:00 PM

Change #1166397 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add country code to Address and use it for formatting

https://gerrit.wikimedia.org/r/1166397

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.10; 2025-07-15); removed MW-1.45-notes (1.45.0-wmf.9; 2025-07-08).Jul 11 2025, 10:00 PM
gerritbot added a comment.Jul 12 2025, 1:19 PM

Change #1166413 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add event country code to EventFactory

https://gerrit.wikimedia.org/r/1166413

Daimona moved this task from Code Review 💬 to QA 🐛 on the Connection-Team (Connection-Current-Sprint) board.Jul 12 2025, 1:29 PM

QA notes: not directly testable. At most, you could test that nothing broke, if you'd like.

Maintenance_bot removed a project: Patch-For-Review.Jul 12 2025, 1:30 PM
gerritbot added a comment.Jul 15 2025, 6:31 PM

Change #1169726 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Fix EventFactory not using country code when provided without address

https://gerrit.wikimedia.org/r/1169726

gerritbot added a project: Patch-For-Review.Jul 15 2025, 6:31 PM
Daimona moved this task from QA 🐛 to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.Jul 15 2025, 6:32 PM
gerritbot added a comment.Jul 22 2025, 9:53 AM

Change #1169726 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Fix EventFactory not using country code when provided without address

https://gerrit.wikimedia.org/r/1169726

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.12; 2025-07-29); removed MW-1.45-notes (1.45.0-wmf.10; 2025-07-15).Jul 22 2025, 10:05 AM
Daimona moved this task from Code Review 💬 to QA 🐛 on the Connection-Team (Connection-Current-Sprint) board.Jul 22 2025, 10:07 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 22 2025, 10:31 AM
vaughnwalters moved this task from QA 🐛 to Product sign-off 🖌️ on the Connection-Team (Connection-Current-Sprint) board.Jul 23 2025, 8:41 PM
vaughnwalters subscribed.
In T397867#10997305, @Daimona wrote:

QA notes: not directly testable. At most, you could test that nothing broke, if you'd like.

The country field is still working as expected. Sending to product sign off.

ifried closed this task as Resolved.Aug 6 2025, 10:35 PM
ifried moved this task from Product sign-off 🖌️ to Done 🏁 on the Connection-Team (Connection-Current-Sprint) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits