Page MenuHomePhabricator
Create Task
Maniphest T397883

allow HTMLIntField to have a minimum of 0 OR be blank
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • In PHP code...
    • Create a HTMLIntField
    • Configure it so that min: 0
  • In browser, viewing the form
    • Set the HTMLIntField's value to blank
    • Submit the form

What happens?:

  • Form validation error

image.png (1,682×1,078 px, 113 KB)

What should have happened instead?:

  • Form submission succeeds
  • Blank is written to the database

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
htmlform: fix min/max validations on empty input in int/float fieldsUmherirrendermediawiki/coreREL1_43+3 -0
htmlform: fix min/max validations on empty input in int/float fieldsUmherirrendermediawiki/coreREL1_44+3 -0
htmlform: fix min/max validations on empty input in int/float fieldsUmherirrendermediawiki/coreREL1_42+3 -0
htmlform: fix min/max validations on empty input in int/float fieldsUmherirrendermediawiki/coreREL1_39+3 -0
htmlform: fix min/max validations on empty input in int/float fieldsSD0001mediawiki/coremaster+3 -0
htmlform: fix min/max validations on empty input in int/float fieldsSD0001mediawiki/coremaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

Novem_Linguae created this task.Jun 25 2025, 9:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 25 2025, 9:38 PM
SD0001 edited projects, added: MediaWiki-HTMLForm; removed: OOUI.Jun 27 2025, 11:08 AM
gerritbot added a comment.Jun 28 2025, 9:58 AM

Change #1164551 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/core@master] htmlform: allow optional int and float fields to specify min value

https://gerrit.wikimedia.org/r/1164551

gerritbot added a project: Patch-For-Review.Jun 28 2025, 9:58 AM
Umherirrender added a project: PHP 8.0 support.Jun 28 2025, 10:19 AM
Umherirrender subscribed.

Sounds like a problem from change to PHP8.0

PHP 8.0: String to number comparisons no longer coerce string to a number

gerritbot added a comment.Jun 28 2025, 10:37 AM

Change #1164552 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/core@master] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164552

gerritbot added a comment.Jun 28 2025, 10:40 AM

Change #1164552 abandoned by SD0001:

[mediawiki/core@master] htmlform: fix min/max validations on empty input in int/float fields

Reason:

accidentally created duplicate of I37be8455

https://gerrit.wikimedia.org/r/1164552

gerritbot added a comment.Jun 28 2025, 12:11 PM

Change #1164551 merged by jenkins-bot:

[mediawiki/core@master] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164551

Maintenance_bot removed a project: Patch-For-Review.Jun 28 2025, 12:30 PM
Novem_Linguae closed this task as Resolved.Jun 28 2025, 12:31 PM
Novem_Linguae assigned this task to SD0001.
gerritbot added a comment.Jun 28 2025, 12:49 PM

Change #1164612 had a related patch set uploaded (by Umherirrender; author: SD0001):

[mediawiki/core@REL1_44] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164612

gerritbot added a project: Patch-For-Review.Jun 28 2025, 12:49 PM

Change #1164613 had a related patch set uploaded (by Umherirrender; author: SD0001):

[mediawiki/core@REL1_43] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164613

gerritbot added a comment.Jun 28 2025, 12:49 PM

Change #1164614 had a related patch set uploaded (by Umherirrender; author: SD0001):

[mediawiki/core@REL1_42] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164614

gerritbot added a comment.Jun 28 2025, 12:50 PM

Change #1164615 had a related patch set uploaded (by Umherirrender; author: SD0001):

[mediawiki/core@REL1_39] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164615

gerritbot added a comment.Jun 28 2025, 1:21 PM

Change #1164615 merged by jenkins-bot:

[mediawiki/core@REL1_39] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164615

gerritbot added a comment.Jun 28 2025, 1:23 PM

Change #1164614 merged by jenkins-bot:

[mediawiki/core@REL1_42] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164614

gerritbot added a comment.Jun 28 2025, 1:26 PM

Change #1164612 merged by jenkins-bot:

[mediawiki/core@REL1_44] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164612

gerritbot added a comment.Jun 28 2025, 1:27 PM

Change #1164613 merged by jenkins-bot:

[mediawiki/core@REL1_43] htmlform: fix min/max validations on empty input in int/float fields

https://gerrit.wikimedia.org/r/1164613

Maintenance_bot removed a project: Patch-For-Review.Jun 28 2025, 1:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits