Page MenuHomePhabricator
Create Task
Maniphest T397914

VE failing to load a second time after saving
Closed, ResolvedPublic
Actions

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (4d51df7e7)mediawiki/extensions/VisualEditormaster+2 -1
ve.init.Target: Fix double initialization of toolbarsVisualEditor/VisualEditormaster+31 -18
Force-clear toolbar after teardownmediawiki/extensions/VisualEditormaster+3 -0
ve.init.Target: Don't lazy-initialize the toolbar in #getToolbarVisualEditor/VisualEditormaster+7 -10
Force-clear toolbar after teardownmediawiki/extensions/VisualEditorwmf/1.45.0-wmf.7+3 -0
Customize query in gerrit

Event Timeline

Esanders created this task.Jun 26 2025, 10:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2025, 10:55 AM
Esanders moved this task from Inbox to Doing on the Editing-team (Kanban Board) board.Jun 26 2025, 10:55 AM

Likely caused by our promise refactor: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1141439

Esanders added a comment.EditedJun 26 2025, 11:17 AM

So not in fact cause by the promise refactor, but the surface padding refactor (https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/1161510):

  • When the target is torn down after save the toolbar is set to null
  • A debounced 'position' event triggers a recalculation of surface padding
  • This calls getToolbar, which lazy-initialises target.toolbar
  • When we go to initialise the target again, it thinks the toolbar is already setup so it skips it.
gerritbot added a comment.Jun 26 2025, 11:23 AM

Change #1164163 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Don't lazy-initialize the toolbar when calculating surface padding

https://gerrit.wikimedia.org/r/1164163

gerritbot added a project: Patch-For-Review.Jun 26 2025, 11:23 AM
gerritbot added a comment.Jun 26 2025, 11:37 AM

Change #1164164 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Force-clear toolbar after teardown

https://gerrit.wikimedia.org/r/1164164

Esanders triaged this task as Unbreak Now! priority.Jun 26 2025, 11:37 AM
gerritbot added a comment.Jun 26 2025, 11:39 AM

Change #1164165 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.7] Force-clear toolbar after teardown

https://gerrit.wikimedia.org/r/1164165

SBisson subscribed.Jun 26 2025, 12:57 PM
gerritbot added a comment.Jun 26 2025, 1:11 PM

Change #1164165 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.7] Force-clear toolbar after teardown

https://gerrit.wikimedia.org/r/1164165

Stashbot added a comment.Jun 26 2025, 1:11 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-26T13:11:30Z] <esanders@deploy1003> Started scap sync-world: Backport for [[gerrit:1164165|Force-clear toolbar after teardown (T397914)]]

Stashbot added a comment.Jun 26 2025, 1:13 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-26T13:13:47Z] <esanders@deploy1003> esanders: Backport for [[gerrit:1164165|Force-clear toolbar after teardown (T397914)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Jun 26 2025, 1:21 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-26T13:21:22Z] <esanders@deploy1003> Finished scap sync-world: Backport for [[gerrit:1164165|Force-clear toolbar after teardown (T397914)]] (duration: 09m 52s)

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.7; 2025-06-24).Jun 26 2025, 2:00 PM
gerritbot added a comment.Jun 26 2025, 2:36 PM

Change #1164164 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Force-clear toolbar after teardown

https://gerrit.wikimedia.org/r/1164164

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.8; 2025-07-01); removed MW-1.45-notes (1.45.0-wmf.7; 2025-06-24).Jun 26 2025, 3:00 PM
gerritbot added a comment.Jun 26 2025, 3:18 PM

Change #1164163 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] ve.init.Target: Don't lazy-initialize the toolbar in #getToolbar

https://gerrit.wikimedia.org/r/1164163

Maintenance_bot removed a project: Patch-For-Review.Jun 26 2025, 3:30 PM
ppelberg subscribed.Jun 26 2025, 4:01 PM
Esanders moved this task from Doing to QA on the Editing-team (Kanban Board) board.Jun 27 2025, 12:26 PM
Esanders added a project: Editing QA.
gerritbot added a comment.Jul 1 2025, 1:58 PM

Change #1165533 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (10fa68ec4)

https://gerrit.wikimedia.org/r/1165533

gerritbot added a project: Patch-For-Review.Jul 1 2025, 1:58 PM
EAkinloose subscribed.Jul 1 2025, 6:21 PM

VE loads fine when I save multiple time. Pending related patch set merge. Will retest after.

EAkinloose moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Jul 1 2025, 6:21 PM
gerritbot added a comment.Jul 2 2025, 10:36 AM

Change #1165848 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[VisualEditor/VisualEditor@master] ve.init.Target: Fix double initialization of toolbars

https://gerrit.wikimedia.org/r/1165848

thiemowmde added a project: WMDE-TechWish-Sprint-2025-06-25-Basil-Lime-Sorbet.Jul 2 2025, 10:41 AM
thiemowmde moved this task from Sprint Backlog to Watching / Stalled on the WMDE-TechWish-Sprint-2025-06-25-Basil-Lime-Sorbet board.
thiemowmde subscribed.
gerritbot added a comment.Jul 2 2025, 7:31 PM

Change #1165848 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] ve.init.Target: Fix double initialization of toolbars

https://gerrit.wikimedia.org/r/1165848

EAkinloose edited projects, added Verified; removed Editing QA.Jul 3 2025, 12:52 AM
EAkinloose moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Kanban Board) board.
gerritbot added a comment.Jul 4 2025, 10:57 AM

Change #1165533 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (4d51df7e7)

https://gerrit.wikimedia.org/r/1165533

Maintenance_bot removed a project: Patch-For-Review.Jul 4 2025, 11:30 AM
thiemowmde lowered the priority of this task from Unbreak Now! to Needs Triage.Jul 15 2025, 8:16 AM

I think we are unblocked here, aren't we?

ppelberg closed this task as Resolved.Aug 18 2025, 4:30 PM
VPuffetMichel added a project: Essential-Work.Dec 8 2025, 10:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits