Maniphest T397941

Update code to read from afl_ip_hex
Closed, ResolvedPublic
Actions

Description

Summary

The abuse_filter_log table has a new afl_ip_hex column. We should read from it instead of reading from afl_ip.

Background & Technical details

T391322: Special:AbuseLog: Support search by IP and IP range when temporary accounts are enabled requests that it be possible to search AbuseFilter log entries performed by temporary accounts by the IP address used to perform the action
To achieve this we need to be able to search by the IP address column in the abuse_filter_log table
- This involves reading from this new afl_ip_hex column instead of afl_ip so that the old column can be removed, which will be the focus of this task.

Acceptance criteria

The afl_ip_hex column is read from
No code reads from afl_ip (except for any code related to the migration to afl_ip_hex)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Don't read from `afl_ip`	mediawiki/extensions/AbuseFilter	master	+290 -44
	Don't read from `afl_ip` column in `abuse_filter_log`	mediawiki/extensions/IPInfo	master	+18 -7

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		STran	T391322 Special:AbuseLog: Support search by IP and IP range when temporary accounts are enabled
		Resolved		Dreamy_Jazz	T395612 AbuseFilter abuse_filter_log table: Store IP addresses as hex values
		Resolved		Dreamy_Jazz	T400280 Drop `afl_ip` as the last step of the migration to `afl_ip_hex`
		Resolved		STran	T400284 Stop writing to `afl_ip`
		Resolved		mszwarc	T397941 Update code to read from afl_ip_hex
		Resolved		Dreamy_Jazz	T397842 Populate afl_ip_hex for pre-existing abuse_filter_log rows
		Resolved		Dreamy_Jazz	T397762 Write to afl_ip_hex in AbuseFilter

Event Timeline

Dreamy_Jazz created this task.Jun 26 2025, 2:42 PM

Dreamy_Jazz added subtasks: T397842: Populate afl_ip_hex for pre-existing abuse_filter_log rows, T397762: Write to afl_ip_hex in AbuseFilter.

Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.Jun 26 2025, 4:08 PM

Tchanders moved this task from To triage to Ready on the Temporary accounts (Global wiki rollout) board.Jul 15 2025, 5:23 PM

Dreamy_Jazz closed subtask T397762: Write to afl_ip_hex in AbuseFilter as Resolved.Jul 16 2025, 12:20 PM

STran claimed this task.Jul 16 2025, 1:25 PM

STran added a project: Trust and Safety Product Sprint (Sprint Cannoli (July 7 - July 25)).

STran moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Cannoli (July 7 - July 25)) board.

Tchanders removed a project: Trust and Safety Product Sprint (Sprint Cannoli (July 7 - July 25)).Jul 16 2025, 2:20 PM

Tchanders edited projects, added Temporary accounts (Create/update essential tools/anti-abuse management); removed Temporary accounts (Global wiki rollout).

STran removed STran as the assignee of this task.Jul 16 2025, 3:04 PM

STran subscribed.

Tchanders added a project: Trust and Safety Product Sprint.Jul 16 2025, 3:12 PM

Restricted Application removed a project: Trust and Safety Product Team. · View Herald TranscriptJul 16 2025, 3:12 PM

Tchanders moved this task from Backlog to Maintenance to triage on the Trust and Safety Product Sprint board.Jul 16 2025, 3:13 PM

Dreamy_Jazz mentioned this in T388124: CheckUser IP reveal: Support IP reveal on Special:AbuseLog.Jul 18 2025, 1:57 PM

Dreamy_Jazz closed subtask T397842: Populate afl_ip_hex for pre-existing abuse_filter_log rows as Resolved.Jul 21 2025, 9:48 AM

OKryva-WMF triaged this task as Medium priority.Jul 22 2025, 3:17 PM

OKryva-WMF edited projects, added Trust and Safety Product Sprint (Sprint Cannoli (July 7 - July 25)); removed Trust and Safety Product Sprint.

Tchanders moved this task from In Progress to Ready on the Trust and Safety Product Sprint (Sprint Cannoli (July 7 - July 25)) board.Jul 22 2025, 4:51 PM

mszwarc claimed this task.Jul 22 2025, 7:37 PM

Change #1171995 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/AbuseFilter@master] Don't read from `afl_ip`

https://gerrit.wikimedia.org/r/1171995

gerritbot added a project: Patch-For-Review.Jul 23 2025, 9:35 AM

Change #1172003 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/IPInfo@master] Don't read from `afl_ip` column in `abuse_filter_log`

https://gerrit.wikimedia.org/r/1172003

mszwarc moved this task from Ready to Needs Review on the Trust and Safety Product Sprint (Sprint Cannoli (July 7 - July 25)) board.Jul 23 2025, 10:22 AM

Change #1172003 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Don't read from `afl_ip` column in `abuse_filter_log`

https://gerrit.wikimedia.org/r/1172003

STran mentioned this in T395612: AbuseFilter abuse_filter_log table: Store IP addresses as hex values.Jul 23 2025, 3:54 PM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.12; 2025-07-29).Jul 23 2025, 4:01 PM

STran mentioned this in T400284: Stop writing to `afl_ip`.Jul 23 2025, 4:34 PM

STran mentioned this in T400280: Drop `afl_ip` as the last step of the migration to `afl_ip_hex`.Jul 23 2025, 4:36 PM

This can skip QA

Change #1171995 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Don't read from `afl_ip`

https://gerrit.wikimedia.org/r/1171995

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2025, 10:31 PM

Dreamy_Jazz added a parent task: T400284: Stop writing to `afl_ip`.Jul 28 2025, 12:53 PM