Page MenuHomePhabricator

LQT search function use the normal search, but adding ondiscussionpage:, exposing that keyword on the new page creation link
Closed, ResolvedPublic

Description

Author: dasch

Description:
Somehow sometimes instead of the korrekt Thread:Topic pages there are strang
Topic ondiscussionpage:Talk_Page:Pagename are created.

This is on MW 1.20 with latest git clone of LQT


Version: master
Severity: minor

Details

Reference
bz37801

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:27 AM
bzimport set Reference to bz37801.
bzimport added a subscriber: Unknown Object (MLST).

Can you please add some screenshots, and describe exactly what are the steps causing this?

dasch wrote:

The problem is, that I can not reproduce this problem myself. I just see some users randomly create such strange pages on my Wiki.

I can enter some example pagenames, there is nothing more to see. And I deleted the pages after this.

Examples

Looser ondiscussionpage:Benutzer Diskussion:DaSch
Roter Laternenbaum ondiscussionpage:WeCoWi:Importanfragen
Gualterio Looser Schallemberg ondiscussionpage:WeCoWi:Importanfragen
Lemma Manfred Riebe ondiscussionpage:Benutzer Diskussion:Manfred Riebe
Rockya ondiscussionpage:Benutzer Diskussion:DaSch

DaSch: Has this ever happened again? If not this is probably a RESOLVED WORKSFORME...

dasch wrote:

in the last month not. But LQT was not used that much in the last month. I assign this to me so that I'll keep an eye on this

dasch wrote:

so this happended again
Skin-Extensions ondiscussionpage:Portal:Gästebuch

the format is always the same. It's <Threadname> ondiscussionpage:<Discussionpagename>

I think that this may be a JavaScript Error, that maybe happens with old Browsers.

Oh, I think I see what's happening here.

  1. Go to https://www.mediawiki.org/wiki/Project:Support_desk
  2. There's a search box just above the LQT TOC. Put anything there and hit the "search" button (for example, "testing")
  3. The search results page comes up. The search terms are: testing ondiscussionpage:Project:Support desk
  4. Below the search filters there's a "Create the page "Testing ondiscussionpage:Project:Support desk" on this wiki!" with a link to create "Testing ondiscussionpage:Project:Support desk" (MediaWiki:Searchmenu-new)

People clicking on that link will be creating that page as any other normal page.

Maybe we should change that new page creation link to point to a new thread creation (under the original discussion, stripping ondiscussionpage:) instead of the default one. Or remove the link to create that page completely, probably using a different message than MediaWiki:Searchmenu-new.

So it turns out this 'ondiscussionpage' thing is coded into Wikimedia's Lucene Search - 'inthread' as well. See operations/debs/lucene-search-2.git

The ondiscussionpage: "feature" was added on r53948 but it's undocumented.
"It requires Lucene search to be installed." according to comments for that commit. Still, no documentation about what configuration needs for Lucene search.

Also, lowering severity

So shall this request be moved to "Wikimedia > lucene-search-2" or is there something that can be fixed in the LQT codebase?

I really have no idea. MediaWiki core should have a system to detect such keywords (or whatever you call the 'ondiscussionpage' thing), know which ones lucene supports, and run the right hooks. And then LQT should be able to use this hook to determine whether or not to show the page creation link.

  • This bug has been marked as a duplicate of bug 22678 ***