Page MenuHomePhabricator

VisualEditor freaks out on <span>
Closed, ResolvedPublic

Description

After I vandalised the test page with[1], trying to edit this page resulted in "renderers[annotation.type] is undefined"

var openAnnotations = function( annotations ) {

var out = '',
    annotation;
for ( var hash in annotations ) {
    annotation = annotations[hash];
    out += typeof renderers[annotation.type].open === 'function' ? <-- here
        renderers[annotation.type].open( annotation.data ) :
        renderers[annotation.type].open;
    hashStack.push( hash );
    annotationStack[hash] = annotation;
}

[1] https://www.mediawiki.org/w/index.php?title=VisualEditor:Test&diff=552553&oldid=552537


Version: unspecified
Severity: normal

Details

Reference
bz37808

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:28 AM
bzimport set Reference to bz37808.
bzimport added a subscriber: Unknown Object (MLST).

Yeah, this is because span is listed as an annotation but has no renderer defined. Fixing.

Mass-moving old VisualEditor tickets to the VE product. Search for this message to mass-delete bugmail.

Noting bugs closed in the 2012-10-15 release.