Page MenuHomePhabricator

Set $wgSecurePollUseMediaWikiNamespace = true on English Wikipedia
Closed, ResolvedPublic

Event Timeline

Change #1164506 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[operations/mediawiki-config@master] initialiseSettings: set wgSecurePollUseMediaWikiNamespace = true for enwiki

https://gerrit.wikimedia.org/r/1164506

Change #1164506 merged by jenkins-bot:

[operations/mediawiki-config@master] initialiseSettings: set wgSecurePollUseMediaWikiNamespace = true for enwiki

https://gerrit.wikimedia.org/r/1164506

Mentioned in SAL (#wikimedia-operations) [2025-06-30T08:02:47Z] <kharlan@deploy1003> Started scap sync-world: Backport for [[gerrit:1164506|initialiseSettings: set wgSecurePollUseMediaWikiNamespace = true for enwiki (T398080)]], [[gerrit:1164507|refactor unnecessary wmgSecurePollUseNamespace variable]]

Mentioned in SAL (#wikimedia-operations) [2025-06-30T08:07:03Z] <kharlan@deploy1003> novemlinguae, kharlan: Backport for [[gerrit:1164506|initialiseSettings: set wgSecurePollUseMediaWikiNamespace = true for enwiki (T398080)]], [[gerrit:1164507|refactor unnecessary wmgSecurePollUseNamespace variable]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-06-30T08:19:05Z] <kharlan@deploy1003> Finished scap sync-world: Backport for [[gerrit:1164506|initialiseSettings: set wgSecurePollUseMediaWikiNamespace = true for enwiki (T398080)]], [[gerrit:1164507|refactor unnecessary wmgSecurePollUseNamespace variable]] (duration: 16m 17s)

Novem_Linguae closed this task as Resolved.EditedJun 30 2025, 8:24 AM
Novem_Linguae claimed this task.
Novem_Linguae added a subscriber: kostajh.

This feature is all set to arrive to English Wikipedia on Thursday, when https://gerrit.wikimedia.org/r/1090512 rides the train. Thank you @kostajh for deploying and @DreamRimmer for attending the backport window!

Something weird is going on. Both patches needed to turn this on are deployed. I can tell because https://en.wikipedia.org/w/index.php?title=MediaWiki:SecurePoll&action=edit correctly gives a permission error.

But when I create a poll, edit translations, etc. no edits are being made.

It works fine in my localhost.

Needs further investigation. Maybe by someone with logstash access who can look for PHP warnings. I did my enwiki testing maybe 15 minutes ago so the log entries should be around the timestamp 2025-07-04 09:00:00 UTC.

Something weird is going on. Both patches needed to turn this on are deployed. I can tell because https://en.wikipedia.org/w/index.php?title=MediaWiki:SecurePoll&action=edit correctly gives a permission error.

But when I create a poll, edit translations, etc. no edits are being made.

It works fine in my localhost.

Needs further investigation. Maybe by someone with logstash access who can look for PHP warnings. I did my enwiki testing maybe 15 minutes ago so the log entries should be around the timestamp 2025-07-04 09:00:00 UTC.

I had a look in Logstash but did not see anything. Can you try again, using the WikimediaDebug extension and set to "Verbose log"?

Verbose log completed. Feel free to check.

Looks like this is because enwiki has subpages disabled for MediaWiki namespace. I can reproduce locally after setting $wgNamespacesWithSubpages[NS_MEDIAWIKI] = false;.

The clue was that only MediaWiki:SecurePoll is giving the permission error. Subpages like MediaWiki:SecurePoll/123 also should have gotten locked up, but they're editable, since $title->getRootText() in TitleQuickPermissions hook doesn't work as intended if subpages are disabled.

Change #1169298 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[operations/mediawiki-config@master] Revert "initialiseSettings: set wgSecurePollUseMediaWikiNamespace = true for enwiki"

https://gerrit.wikimedia.org/r/1169298

Change #1169298 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "initialiseSettings: set wgSecurePollUseMediaWikiNamespace = true for enwiki"

https://gerrit.wikimedia.org/r/1169298

Mentioned in SAL (#wikimedia-operations) [2025-07-15T20:07:26Z] <zabe@deploy1003> Started scap sync-world: Backport for [[gerrit:1169298|Revert "initialiseSettings: set wgSecurePollUseMediaWikiNamespace = true for enwiki" (T398080 T399372)]]

Mentioned in SAL (#wikimedia-operations) [2025-07-15T20:09:36Z] <zabe@deploy1003> novemlinguae, zabe: Backport for [[gerrit:1169298|Revert "initialiseSettings: set wgSecurePollUseMediaWikiNamespace = true for enwiki" (T398080 T399372)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

We ran the query INSERT INTO content_models (model_name) VALUES ('SecurePoll'), and this is now fully working on enwiki. Despite the bot comments above, we left this deployed since the SQL query worked. Should be all set.