Alright, let me first state that this is my first review for a tool adoption request. Do not consider my words definitive, nor this review to be complete :-P I am also not a Toolforge admin, so I am not able to action this request nor do a full review of the files hosted on Toolforge.

• The repo is MIT-liscened and hosted on GitLab, but is under Inductiveload's namespace. The right to fork applies here, so I think we're all set as far as licensing.
• I see this is a tool (not a bot), so simply creating a new tool won't help existing backlinks. A global search shows integration with gadgets across multiple wikis. Given this, I would think that a redirect at minimum would be ideal if we have to create a new tool.
• Known private data:
  • /www/python/src/.env ­– seems to contain Hathi credentials. Is this Indictiveload's personal credentials? Can new credentials be used, or are IL's privileged in some way?
  • /.ssh – I believe all Toolforge projects have this for the known_hosts file, but it should still probably be checked by a Toolforge admin

Barring other complications, I don't see a problem with this moving forward. I might recommend forking the repo and keeping just the Pagelister bits, as I see the repo as a whole is advertised as "General mish-mash of tools by (and mostly for) Inductiveload" (emphasis mine).

Mentioned in SAL (#wikimedia-cloud) [2025-08-03T11:05:00Z] <lucaswerkmeister> add toolforge-standards-committee to maintainer tools so non-root members can process T398111

@MusikAnimal per the above, you should be able to become toolforge-standards-committee become pagelister now.

I think it’s also fine for me to confirm publicly that the .env file only contains a ILTOOLS_HATHI_KEY= and ILTOOLS_HATHI_SECRET= (no other credentials), and that the .ssh/ directory only contains a known_hosts file (with two entries for the same public key – the one for gitlab.wikimedia.org – under different hashed hostnames).

On the hathi credentials: these are for a terminated api (https://babel.hathitrust.org/cgi/htd/); so sharing them is not much risk. You can remove them if you want.

Thanks @LucasWerkmeister :)

I have examined the tool more closely and don't see any problems. After talking with Alien333, we concluded the Hathi credentials aren't needed at all, so I have removed the .env file.

+1 from me! I unfortunately still can't action the request as group maintainers like toolforge-standards-committee don't appear to be able to change maintainers in Striker.

For the Toolforge admin who does process this, note that Alien333's shell name is Alien4444.

Mentioned in SAL (#wikimedia-cloud) [2025-08-04T18:15:51Z] <lucaswerkmeister> add Alien4444, remove toolforge-standards-committee (T398111)

Thanks! Could I also get rights on the gitlab repo? To keep it up to date.

Ideally yes, but I don’t have permissions to add you :/ maybe ask in IRC?

In T398111#11059050, @Alien333 wrote:

Thanks! Could I also get rights on the gitlab repo? To keep it up to date.

{{Done}}.

Thanks @bd808!

Thanks! All good here, as far as I'm concerned.