Page MenuHomePhabricator
Create Task
Maniphest T398136

NoSuchServiceException when replying comments
Closed, ResolvedPublicBUG REPORT
Actions

Description

I got some errors when replying comments.

Wikimedia\Services\NoSuchServiceException at /www/wwwroot/MediaWiki/vendor/wikimedia/services/src/ServiceContainer.php(426) 
from /www/wwwroot/MediaWiki/vendor/wikimedia/services/src/ServiceContainer.php(426) 
#0 /www/wwwroot/MediaWiki/vendor/wikimedia/services/src/ServiceContainer.php(406): Wikimedia\Services\ServiceContainer->createService() 
#1 /www/wwwroot/MediaWiki/includes/MediaWikiServices.php(356): Wikimedia\Services\ServiceContainer->getService() 
#2 /www/wwwroot/mw-utils/YsArchives-Extensions/CommentStreams/includes/Notifier/EchoNotifier.php(175): MediaWiki\MediaWikiServices->getService() 
#3 /www/wwwroot/mw-utils/YsArchives-Extensions/Echo/includes/Controller/NotificationController.php(471): MediaWiki\Extension\CommentStreams\Notifier\EchoNotifier::locateUsersWatchingComment() 
#4 /www/wwwroot/mw-utils/YsArchives-Extensions/Echo/includes/Controller/NotificationController.php(502): MediaWiki\Extension\Notifications\Controller\NotificationController::evaluateUserCallable() 
#5 /www/wwwroot/mw-utils/YsArchives-Extensions/Echo/includes/Controller/NotificationController.php(137): MediaWiki\Extension\Notifications\Controller\NotificationController::getUsersToNotifyForEvent() 
#6 /www/wwwroot/mw-utils/YsArchives-Extensions/Echo/includes/Model/Event.php(207): MediaWiki\Extension\Notifications\Controller\NotificationController::notify() 
#7 /www/wwwroot/mw-utils/YsArchives-Extensions/CommentStreams/includes/Notifier/EchoNotifier.php(148): MediaWiki\Extension\Notifications\Model\Event::create() 
#8 /www/wwwroot/mw-utils/YsArchives-Extensions/CommentStreams/includes/ApiCSPostReply.php(116): MediaWiki\Extension\CommentStreams\Notifier\EchoNotifier->sendReplyNotifications() 
#9 /www/wwwroot/MediaWiki/includes/api/ApiMain.php(1974): MediaWiki\Extension\CommentStreams\ApiCSPostReply->execute() 
#10 /www/wwwroot/MediaWiki/includes/api/ApiMain.php(942): MediaWiki\Api\ApiMain->executeAction() 
#11 /www/wwwroot/MediaWiki/includes/api/ApiMain.php(913): MediaWiki\Api\ApiMain->executeActionWithErrorHandling() 
#12 /www/wwwroot/MediaWiki/includes/api/ApiEntryPoint.php(153): MediaWiki\Api\ApiMain->execute() 
#13 /www/wwwroot/MediaWiki/includes/MediaWikiEntryPoint.php(200): MediaWiki\Api\ApiEntryPoint->execute() 
#14 /www/wwwroot/MediaWiki/api.php(44): MediaWiki\MediaWikiEntryPoint->run() 
#15 {main}

I'm using the latest commit of REL1_43 and my MediaWiki is 1.43.1, not sure if it's a error about Echo or CommentStreams

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix service namemediawiki/extensions/CommentStreamsREL1_44+1 -1
Fix service namemediawiki/extensions/CommentStreamsREL1_45+1 -1
Fix service namemediawiki/extensions/CommentStreamsmaster+1 -1
Fix service namemediawiki/extensions/CommentStreamsREL1_43+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Zorua_Fox created this task.Jun 29 2025, 12:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2025, 12:43 PM
Zorua_Fox triaged this task as Unbreak Now! priority.Jun 29 2025, 12:50 PM
Zorua_Fox added subscribers: Osnard, MarkAHershberger.
Zorua_Fox added a comment.Jun 29 2025, 1:06 PM

@Osnard @MarkAHershberger This issue occurs when I reply to someone else's existing comment. If I post a brand new comment, this problem does not happen.

Aklapper lowered the priority of this task from Unbreak Now! to Needs Triage.Jun 29 2025, 2:12 PM

@Zorua_Fox: Do you plan to work on fixing this task, as you increased the priority of this task?

Zorua_Fox added a comment.Jun 29 2025, 4:05 PM
在T398136#10956640中，@Aklapper写道：

@Zorua_Fox: Do you plan to work on fixing this task, as you increased the priority of this task?

My apologies for the wrong priority of this task, Sorry for the inconvenience.

Zorua_Fox triaged this task as Unbreak Now! priority.EditedJul 12 2025, 7:57 AM

Given that I have identified the potential issue, I will increase this task's priority to Unbreak Now.

@Osnard @MarkAHershberger Can you help check if line 175 in the EchoNotifier.php file is using the correct service name? The issue disappeared when I changed ICommentStreamsStore to CommentStreamsStore there.

Aklapper lowered the priority of this task from Unbreak Now! to Needs Triage.Jul 12 2025, 11:29 AM

Please do not, as knowing the reason does not imply at all that a problem has suddenly become more urgent.

Zorua_Fox added a comment.EditedJul 12 2025, 11:36 AM
在T398136#10997247中，@Aklapper写道：

Please do not, as knowing the reason does not imply at all that a problem has suddenly become more urgent.

Based on this code error causing a critical error in the latest extension version (preventing others from replying to any comments), and referencing the "Issues that hold the train" section on Wikitech regarding how to define priority as Unbreak Now!, I believe this issue qualifies as a Major feature regression as defined in that section. Additionally, based on the definition of Unbreak Now! priority in https://mediawiki.org/wiki/Phabricator/Project_management#Priority_levels, I have therefore adjusted this bug to target priority. I am fully aware of what I'm doing and the impact this issue has on the master branch. Please reconsider restoring the priority level I set.

Aklapper added a comment.Jul 12 2025, 2:18 PM

(This cannot hold the train as this codebase is not deployed on Wikimedia servers at all :)

Zorua_Fox triaged this task as Medium priority.Jul 12 2025, 3:17 PM
malberts subscribed.Sep 8 2025, 9:02 AM
Kghbln subscribed.Sep 8 2025, 9:24 AM
Kghbln added a comment.EditedSep 9 2025, 4:27 PM

@Osnard, I can confirm the issue. I suspect that the extension can currently only be used with the new page content model introduced with version 9.0.0, although I have not verified this. Either way, it will be great if you could fix the issue, which can only be circumvented by disabling the Echo extension. That's a nasty workaround.

gerritbot added a comment.Sep 10 2025, 2:25 PM

Change #1187003 had a related patch set uploaded (by Robert Vogel; author: Robert Vogel):

[mediawiki/extensions/CommentStreams@REL1_43] Fix service name

https://gerrit.wikimedia.org/r/1187003

gerritbot added a project: Patch-For-Review.Sep 10 2025, 2:25 PM
Osnard added a comment.Sep 10 2025, 2:27 PM

I have provided a patch. And a version 9.0.1 will be published soon.

gerritbot added a comment.Sep 10 2025, 2:29 PM

Change #1187005 had a related patch set uploaded (by ItSpiderman; author: Robert Vogel):

[mediawiki/extensions/CommentStreams@master] Fix service name

https://gerrit.wikimedia.org/r/1187005

gerritbot added a comment.Sep 10 2025, 2:32 PM

Change #1187003 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@REL1_43] Fix service name

https://gerrit.wikimedia.org/r/1187003

Osnard mentioned this in rECOS68876ab09336: Fix service name.Sep 10 2025, 2:34 PM
Kghbln added a comment.Sep 15 2025, 4:31 PM

@Osnard Regretably, the fix does not work, i.e., I still get API response errors when trying to reply to a comment. There must be something else in the water.

Kghbln assigned this task to Osnard.Sep 15 2025, 5:04 PM

@Osnard, I am sorry for the noise. I did not check out the fixed code. After eventually doing so, it worked. Senior moments, I guess. Thanks a lot!

Osnard added a comment.Sep 16 2025, 9:40 AM

Nevermind, thanks for confirmation.

Zorua_Fox closed this task as Resolved.Sep 18 2025, 5:47 AM
gerritbot added a comment.Nov 5 2025, 2:03 PM

Change #1187005 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@master] Fix service name

https://gerrit.wikimedia.org/r/1187005

jenkins-bot mentioned this in rECOS5a693c80cce7: Fix service name.Nov 5 2025, 2:05 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 5 2025, 2:31 PM
SomeRandomDeveloper reopened this task as Open.Nov 10 2025, 3:50 PM
SomeRandomDeveloper subscribed.

This needs a backport for 1.44: https://github.com/wikimedia/mediawiki-extensions-CommentStreams/blob/REL1_44/includes/Notifier/EchoNotifier.php#L175

gerritbot added a comment.Nov 10 2025, 3:50 PM

Change #1203477 had a related patch set uploaded (by SomeRandomDeveloper; author: Robert Vogel):

[mediawiki/extensions/CommentStreams@REL1_44] Fix service name

https://gerrit.wikimedia.org/r/1203477

gerritbot added a project: Patch-For-Review.Nov 10 2025, 3:50 PM
SomeRandomDeveloper merged a task: T405769: No such service: ICommentStreamsStore.Nov 10 2025, 3:50 PM
SomeRandomDeveloper added a subscriber: Paladox.
gerritbot added a comment.Nov 10 2025, 3:51 PM

Change #1203478 had a related patch set uploaded (by SomeRandomDeveloper; author: Robert Vogel):

[mediawiki/extensions/CommentStreams@REL1_45] Fix service name

https://gerrit.wikimedia.org/r/1203478

gerritbot added a comment.Nov 10 2025, 7:38 PM

Change #1203478 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@REL1_45] Fix service name

https://gerrit.wikimedia.org/r/1203478

gerritbot added a comment.Nov 10 2025, 7:39 PM

Change #1203477 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@REL1_44] Fix service name

https://gerrit.wikimedia.org/r/1203477

SomeRandomDeveloper mentioned this in rECOS620cc67ba455: Fix service name.Nov 10 2025, 7:39 PM
SomeRandomDeveloper mentioned this in rECOS31b25696a07e: Fix service name.
Maintenance_bot removed a project: Patch-For-Review.Nov 10 2025, 8:31 PM
SomeRandomDeveloper closed this task as Resolved.Nov 10 2025, 9:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits