Page MenuHomePhabricator

Remove create_isbn_edition.py from scripts package with Pywikibot 11
Closed, ResolvedPublic

Description

Status

create_isbn_edition.py originally written by Geert Van Pamel was added 3 years ago with Pywikibot 7.7 but I am unsure whether this is ever used from this repository and it is always behind the initial source at https://github.com/geertivp. Overall it is hardly maintainable and difficult to keep in sync with it.

  • the last change wasn't ported to pywikibot
  • different repositories with different further development are difficult to keep in sync if they changes
  • the script uses a lot of global variables which is generally considered bad practice and should be avoided if possible.
  • the script is in critical risc category with a cyclomatic complexity of ~80
  • in result the script is vulnerable to unintended changes, difficult to maintain, has reduced modularity and probably performance issues
  • finally there are a lot of open tasks according this script for further development

Proposal

I propose to remove create_isbn_edition.py from Pywikibot scripts package. It is still available under the repository https://github.com/geertivp/Pywikibot which hold several scripts. With code entry point for foreign scripts introduced in Pywikibot 9.4 the whole script package could be published by the maintainer as a separate package based on Pywikibot like we do it with pywikibot-scripts.

See also T377066.

Event Timeline

JJMC89 renamed this task from Remove create_isbn_edition.py from scripts package with Pywikibot 1 to Remove create_isbn_edition.py from scripts package with Pywikibot 11.Jun 29 2025, 2:55 PM
JJMC89 awarded a token.
Xqt updated the task description. (Show Details)
Xqt moved this task from Backlog to Ready to announce on the Pywikibot-Announce board.
Xqt moved this task from Backlog to Next major release on the Pywikibot board.

Change #1170272 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] Cleanup: Deprecate create_isbn_edition script

https://gerrit.wikimedia.org/r/1170272

Change #1170272 merged by jenkins-bot:

[pywikibot/core@master] Cleanup: Deprecate create_isbn_edition script

https://gerrit.wikimedia.org/r/1170272

Change #1172810 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] Tests: ignore create_isbn_edition from script_tests

https://gerrit.wikimedia.org/r/1172810

Change #1172810 merged by jenkins-bot:

[pywikibot/core@master] Tests: ignore create_isbn_edition from script_tests

https://gerrit.wikimedia.org/r/1172810

Change #1200447 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] cleanup: remove create_isbn_edition.py from scripts package

https://gerrit.wikimedia.org/r/1200447

Xqt changed the task status from Open to In Progress.Nov 1 2025, 11:47 AM
Xqt claimed this task.

Change #1200447 merged by jenkins-bot:

[pywikibot/core@master] cleanup: remove create_isbn_edition.py from scripts package

https://gerrit.wikimedia.org/r/1200447