Page MenuHomePhabricator

Reorder search bar and tabs in Adjust Suggestions dialog
Closed, ResolvedPublic2 Estimated Story Points

Assigned To
Authored By
SGautam_WMF
Jun 30 2025, 5:30 AM
Referenced Files
F66734307: 2025-10-06_11-31-51.mp4
Oct 6 2025, 7:11 PM
F66734302: 2025-10-06_11-29-34.mp4
Oct 6 2025, 7:11 PM
F66734292: 2025-10-06_11-20-01.mp4
Oct 6 2025, 7:11 PM
F66734199: 2025-10-06_10-43-28.png
Oct 6 2025, 7:11 PM
F66490152: image.png
Sep 24 2025, 3:33 PM
F66491306: image.png
Sep 24 2025, 3:33 PM
F66056193: image.png
Sep 18 2025, 6:57 PM
F62701904: Proposed.png
Jun 30 2025, 6:27 AM

Description

Background

In T392753, we implemented a tabbed structure for the "Adjust suggestions" dialog with the search bar positioned below the tabs. Post implementation, we've decided to switch this order to prioritize search functionality.

CurrentProposed
image.png (1,032×1,410 px, 164 KB)
image.png (1,030×1,406 px, 166 KB)
Related Work
  • T395307(Surface recently selected filters) - Updates the same dialog with a "Recent" section. The mockups in T395307 already reflect the search-above-tabs layout from this task.
Requirements
  • Move the search bar component to appear above the tab navigation
  • Maintain all existing search functionality
Acceptance Criteria
  • Search bar appears above the tabs in the dialog
  • All existing search functionality remains intact

Derived Requirement

Ensure that the search bar in the "Adjust suggestions" dialog is positioned above the tab navigation instead of below it. The change should maintain all existing search and filtering functionality, ensuring that UI behavior and interaction remain consistent after reordering.

Test Steps

Test Case 1: Verify search bar placement above tabs

  1. Open the "Adjust suggestions" dialog from the appropriate interface.
  2. Observe the layout of the dialog.
  3. ✅❓❌⬜ AC1: Confirm that the search bar appears above the tab navigation section.

Test Case 2: Validate existing search functionality

  1. In the "Adjust suggestions" dialog, type a search term into the search bar.
  2. ✅❓❌⬜ AC2: Confirm that search results update correctly based on the entered term.
  3. Clear the search input.
  4. ✅❓❌⬜ AC3: Confirm that all suggestions reappear after clearing the search.

Test Case 3: Validate tab functionality after layout change

  1. With the search bar now above the tabs, switch between available tabs (e.g., categories or filters).
  2. ✅❓❌⬜ AC4: Confirm that tab switching still functions correctly and updates the content area as expected.

Test Case 4: Cross-check layout consistency on different devices

  1. Open the "Adjust suggestions" dialog on desktop view.
  2. Switch to mobile view (Minerva skin).
  3. ✅❓❌⬜ AC5: Confirm that the same layout order (search above tabs) is maintained and responsive on mobile.

QA Results - TestWiki

Event Timeline

SBisson triaged this task as Medium priority.Sep 17 2025, 2:51 PM
SBisson moved this task from Backlog to Prioritized on the LPL Hypothesis board.
SBisson moved this task from Prioritized to Incoming on the LPL Hypothesis board.
eamedina subscribed.

@SGautam_WMF has it been discussed already what we're gonna do about the 'Active filters' section? Currently it looks like this [1], the desired state in the description of this ticket doesn't show this section, should I remove it?

Some questions to consider if we would like to keep it: should it be only displayed under 'All' tab? Or what's the expected design if displayed in every tab?

image.png (1,086×1,468 px, 185 KB)

Change #1189611 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] Update suggestions filters dialog

https://gerrit.wikimedia.org/r/1189611

eamedina changed the task status from Open to In Progress.Sep 19 2025, 12:41 AM
eamedina moved this task from Prioritized to In-progress on the LPL Hypothesis board.
Nikerabbit set the point value for this task to 2.

@SGautam_WMF has it been discussed already what we're gonna do about the 'Active filters' section? Currently it looks like this [1], the desired state in the description of this ticket doesn't show this section, should I remove it?

Some questions to consider if we would like to keep it: should it be only displayed under 'All' tab? Or what's the expected design if displayed in every tab?

image.png (1,086×1,468 px, 185 KB)

Hello @eamedina, I would say let's not remove "Active filters" in this task. This task can focus on reordering the layout so the search bar sit above the tabs. Keep "Active filters" visible as they are currently. We will remove "Active filters" and introduce "Recent" section in T395307

Change #1189611 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Minor update to suggestions filters dialog

https://gerrit.wikimedia.org/r/1189611

Change #1192155 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 1.0.0+20250929

https://gerrit.wikimedia.org/r/1192155

Change #1192155 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 1.0.0+20250929

https://gerrit.wikimedia.org/r/1192155

@eamedina Confirmed the reorder search bar and tabs in Adjust Suggestions dialog, as seen below. I will move this to Sign-Off. Thanks for all your work!

Test Result - TestWiki

Status: ✅ PASS
Environment: TestWiki
OS: macOS Tahoe 26.0.1
Browser: Chrome 140
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify search bar placement above tabs

  1. Open the "Adjust suggestions" dialog from the appropriate interface.
  2. Observe the layout of the dialog.
  3. AC1: Confirm that the search bar appears above the tab navigation section.

2025-10-06_10-43-28.png (890×659 px, 122 KB)

Test Case 2: Validate existing search functionality

  1. In the "Adjust suggestions" dialog, type a search term into the search bar.
  2. AC2: Confirm that search results update correctly based on the entered term.
  3. Clear the search input.

  1. AC3: Confirm that all suggestions reappear after clearing the search.

See AC2

Test Case 3: Validate tab functionality after layout change

  1. With the search bar now above the tabs, switch between available tabs (e.g., categories or filters).
  2. AC4: Confirm that tab switching still functions correctly and updates the content area as expected.

Test Case 4: Cross-check layout consistency on different devices

  1. Open the "Adjust suggestions" dialog on desktop view.
  2. Switch to mobile view (Minerva skin).
  3. AC5: Confirm that the same layout order (search above tabs) is maintained and responsive on mobile.

GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF moved this task from Needs QA to Design Signoff on the LPL Hypothesis board.