Page MenuHomePhabricator

ProofreadPage uses too many global variables in JavaScript
Closed, ResolvedPublic

Description

The proofread extension uses global variables. This is bad as it means other javascript extensions could possibly break it.

The javascript should attach itself to the mw object
e.g. mw.proofreadPage


Version: unspecified
Severity: normal

Details

Reference
bz37836

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:30 AM
bzimport added a project: ProofreadPage.
bzimport set Reference to bz37836.
bzimport added a subscriber: Unknown Object (MLST).
Tpt added a comment.Dec 11 2013, 8:33 AM

All global variables have been removed

GOIII moved this task from Backlog to Done on the ProofreadPage board.Jun 12 2016, 3:45 AM