Page MenuHomePhabricator

UserInfo: Two icons are shown on Special:MobileDiff
Closed, ResolvedPublic0.25 Estimated Story Points

Description

Motivation

On mobile users already have a user icon. Adding another icon for userinfo creates duplicate icons.
Reported by @Johannnes89 on wiki
From my testing on testwiki this is what I see:

image.png (664×632 px, 63 KB)

Example URL: https://en.wikipedia.org/w/index.php?diff=1294264611

Acceptance criteria:
  • user avatar icon is not duplicated

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Note there is also a mismatch between the icon used for temp accounts on userinfo versus the one used on mobile:

image.png (766×674 px, 94 KB)

kostajh renamed this task from UserInfo: Two icons are shown on mobile to UserInfo: Two icons are shown on Special:MobileDiff.EditedJul 23 2025, 10:18 AM
kostajh subscribed.

One idea is to remove the user icon from MinervaNeue

.mw-userlink::before {
	content: '';
	.cdx-mixin-css-icon( @cdx-icon-user-avatar, @color-subtle );
	margin-right: 8px;
}

Change #1172902 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/CheckUser@master] UserInfoCard: Hide MinervaNeue avatar on .mw-userlink

https://gerrit.wikimedia.org/r/1172902

hector.arroyo subscribed.

The patch fixing this issue is being merged right now, so moving the ticket forward for QA.

Change #1172902 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] UserInfoCard: Hide MinervaNeue avatar on .mw-userlink for diffs and history

https://gerrit.wikimedia.org/r/1172902

OKryva-WMF triaged this task as Medium priority.Aug 1 2025, 1:47 PM
Djackson-ctr subscribed.

I am still seeing duplicate UserInfoCard icons for the same user especially when I view the WatchList page.
Since Kosta is out of office this week I am pushing this back to Ready so another engineer can take a look at it.

image.png (987×1 px, 262 KB)

Change #1177973 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CheckUser@master] UserInfoCard: Hide Minerva's avatar on Special:Watchlist

https://gerrit.wikimedia.org/r/1177973

Change #1178470 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/skins/MinervaNeue@master] Special:Watchlist: Fix layout of log entries around userlinks

https://gerrit.wikimedia.org/r/1178470

Change #1177973 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] UserInfoCard: Hide Minerva's avatar on Special:Watchlist

https://gerrit.wikimedia.org/r/1177973

Change #1178470 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Special:Watchlist: Fix layout of log entries around userlinks

https://gerrit.wikimedia.org/r/1178470

I don't see duplicate icons in diffs directly anymore, but it still appears in info cards:

Screenshot_2025-08-13-13-33-52-037_com.opera.browser.jpg (2×1 px, 404 KB)

I don't see duplicate icons in diffs directly anymore, but it still appears in info cards:

Screenshot_2025-08-13-13-33-52-037_com.opera.browser.jpg (2×1 px, 404 KB)

Can you provide the exact URL you used to get this? Also we have made some changes which may affect this and should be deployed there today.

It's any diff, for example https://en.m.wikipedia.org/w/index.php?title=Draft:Typhoon_Podul_(2025)&curid=80691989&diff=1305855111&oldid=1305855040. If you are accessing it from a desktop, you must reduce the window width until the bottom card appears, and then click on the icon (the issue is otherwise not visible).

Thanks. I am able to reproduce it on my local wiki:

image.png (1×1 px, 176 KB)

I think we should create a new ticket for this specific issue. @mszwarc would you agree?

Thanks. I am able to reproduce it on my local wiki:

image.png (1×1 px, 176 KB)

I think we should create a new ticket for this specific issue. @mszwarc would you agree?

Yes, let's do so; let's not dilute this task even more with new patches and things to review.

New Code Changes have been implemented, and verified per the Acceptance Criteria:
QA was completed for this ticket using LocalHost: Mediawiki1.45.0-alpha / CheckUser 2.5 (e561217).
Testing was performed on various: Skins, Desktop View/MobileView, Chrome/Edge/Firefox/Safari, Windows/Mac/Android/iOS, RTL languages