Make favourite icon thicker on Timeless
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	dom_walden
	Jul 2 2025, 8:39 AM

Description

We added a favourite button to Template pages as part of T390019. On the Timeless skin the outline of the icon looks a bit thinner compared to the other icons on the same line.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add custom favorite icon for Timeless skin	mediawiki/extensions/TemplateData	master	+36 -20

Customize query in gerrit

Related Objects

Mentioned In: T397894: Load template page favorite button via SkinTemplateNavigation hook
T396678: Favorite icon size and alignment is wrong in some skins
Mentioned Here: T390019: Add favorite button next to watch star on template pages

Event Timeline

dom_walden created this task.Jul 2 2025, 8:39 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 2 2025, 8:39 AM

dom_walden mentioned this in T396678: Favorite icon size and alignment is wrong in some skins.Jul 2 2025, 8:52 AM

Maintenance_bot added a project: VisualEditor.Jul 2 2025, 9:29 AM

A_smart_kitten added a project: Timeless.Jul 2 2025, 9:45 AM

Samwilson moved this task from New & TBD Tickets to Allow users to favorite a template on the Template-Discovery-And-Recall board.Jul 2 2025, 11:26 AM

Samwilson edited projects, added Template-Discovery-And-Recall (Allow users to favorite a template); removed Template-Discovery-And-Recall.

Samwilson edited projects, added Community-Tech (Fox Squad); removed Community-Tech.Jul 9 2025, 10:16 AM

Samwilson mentioned this in T397894: Load template page favorite button via SkinTemplateNavigation hook.Jul 10 2025, 4:50 AM

Samwilson claimed this task.Jul 18 2025, 1:41 AM

Samwilson moved this task from Ready for Dev to In Development on the Community-Tech (Fox Squad) board.

Samwilson changed the task status from Open to In Progress.Jul 28 2025, 5:31 AM

I've made the icon a bit shorter, as well as with thicker lines, to make it look more like the watch star next to it.

With guide lines:

And without:

The watchstar might be a bit high compared to the other icons:

{F65687967,size=full}

Change #1173590 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/TemplateData@master] Add custom favorite icon for Timeless skin

https://gerrit.wikimedia.org/r/1173590

gerritbot added a project: Patch-For-Review.Jul 29 2025, 5:11 AM

Samwilson moved this task from In Development to Feedback and Review on the Community-Tech (Fox Squad) board.Jul 29 2025, 6:33 AM

Change #1173590 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Add custom favorite icon for Timeless skin

https://gerrit.wikimedia.org/r/1173590

Samwilson moved this task from Feedback and Review to QA on the Community-Tech (Fox Squad) board.Jul 29 2025, 9:25 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 29 2025, 9:31 AM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.13; 2025-08-05).Jul 29 2025, 1:00 PM

How it looks now:

	F65687935: image.png
	Jul 29 2025, 4:54 AM

	F65687928: image.png
	Jul 29 2025, 4:54 AM

Make favourite icon thicker on TimelessClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Make favourite icon thicker on Timeless
Closed, ResolvedPublic
Actions