Page MenuHomePhabricator

TypeError: Cannot assign string to property MediaWiki\Extension\CampaignEvents\Event\EventRegistration::$meetingAddress of type ?MediaWiki\Extension\CampaignEvents\Address\Address
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
  • service.version: 1.45.0-wmf.8
  • timestamp: 2025-07-02T09:05:37.258Z
  • labels.phpversion: 8.1.32
  • trace.id: 9ac63538-a11a-4fa0-9fd4-545889106c0e
  • Find trace.id in Logstash
labels.normalized_message
[{reqId}] {exception_url}   TypeError: Cannot assign string to property MediaWiki\Extension\CampaignEvents\Event\EventRegistration::$meetingAddress of type ?MediaWiki\Extension\CampaignEvents\Address\Address
FrameLocationCall
from/srv/mediawiki/php-1.45.0-wmf.8/includes/libs/objectcache/MemcachedPeclBagOStuff.php(371)
#0/srv/mediawiki/php-1.45.0-wmf.8/includes/libs/objectcache/MemcachedPeclBagOStuff.php(371)Memcached->getMulti(array)
#1/srv/mediawiki/php-1.45.0-wmf.8/includes/libs/objectcache/MediumSpecificBagOStuff.php(675)Wikimedia\ObjectCache\MemcachedPeclBagOStuff->doGetMulti(array, int)
#2/srv/mediawiki/php-1.45.0-wmf.8/includes/libs/objectcache/WANObjectCache.php(613)Wikimedia\ObjectCache\MediumSpecificBagOStuff->getMulti(array)
#3/srv/mediawiki/php-1.45.0-wmf.8/includes/libs/objectcache/WANObjectCache.php(1698)Wikimedia\ObjectCache\WANObjectCache->fetchKeys(array, array, float, null)
#4/srv/mediawiki/php-1.45.0-wmf.8/includes/libs/objectcache/WANObjectCache.php(1646)Wikimedia\ObjectCache\WANObjectCache->fetchOrRegenerate(string, int, Closure, array, array)
#5/srv/mediawiki/php-1.45.0-wmf.8/extensions/CampaignEvents/src/Event/Store/EventStore.php(138)Wikimedia\ObjectCache\WANObjectCache->getWithSetCallback(string, int, Closure, array)
#6/srv/mediawiki/php-1.45.0-wmf.8/extensions/CampaignEvents/src/Event/PageEventLookup.php(63)MediaWiki\Extension\CampaignEvents\Event\Store\EventStore->getEventByPage(MediaWiki\Extension\CampaignEvents\MWEntity\MWPageProxy, int)
#7/srv/mediawiki/php-1.45.0-wmf.8/extensions/CampaignEvents/src/EventPage/EventPageDecorator.php(161)MediaWiki\Extension\CampaignEvents\Event\PageEventLookup->getRegistrationForLocalPage(MediaWiki\Page\WikiPage)
#8/srv/mediawiki/php-1.45.0-wmf.8/extensions/CampaignEvents/src/Hooks/Handlers/ArticleViewHeaderHandler.php(46)MediaWiki\Extension\CampaignEvents\EventPage\EventPageDecorator->decoratePage(MediaWiki\Page\WikiPage)
#9/srv/mediawiki/php-1.45.0-wmf.8/includes/HookContainer/HookContainer.php(155)MediaWiki\Extension\CampaignEvents\Hooks\Handlers\ArticleViewHeaderHandler->onArticleViewHeader(MediaWiki\Page\Article, null, bool)
#10/srv/mediawiki/php-1.45.0-wmf.8/includes/HookContainer/HookRunner.php(882)MediaWiki\HookContainer\HookContainer->run(string, array)
#11/srv/mediawiki/php-1.45.0-wmf.8/includes/page/Article.php(708)MediaWiki\HookContainer\HookRunner->onArticleViewHeader(MediaWiki\Page\Article, null, bool)
#12/srv/mediawiki/php-1.45.0-wmf.8/includes/page/Article.php(551)MediaWiki\Page\Article->generateContentOutput(MediaWiki\User\User, MediaWiki\Parser\ParserOptions, int, MediaWiki\Output\OutputPage, array)
#13/srv/mediawiki/php-1.45.0-wmf.8/includes/actions/ViewAction.php(84)MediaWiki\Page\Article->view()
#14/srv/mediawiki/php-1.45.0-wmf.8/includes/actions/ActionEntryPoint.php(728)MediaWiki\Actions\ViewAction->show()
#15/srv/mediawiki/php-1.45.0-wmf.8/includes/actions/ActionEntryPoint.php(505)MediaWiki\Actions\ActionEntryPoint->performAction(MediaWiki\Page\Article, MediaWiki\Title\Title)
#16/srv/mediawiki/php-1.45.0-wmf.8/includes/actions/ActionEntryPoint.php(143)MediaWiki\Actions\ActionEntryPoint->performRequest()
#17/srv/mediawiki/php-1.45.0-wmf.8/includes/MediaWikiEntryPoint.php(198)MediaWiki\Actions\ActionEntryPoint->execute()
#18/srv/mediawiki/php-1.45.0-wmf.8/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#19/srv/mediawiki/w/index.php(3)require(string)
#20{main}
Notes

Event Timeline

Cannot assign string to property MediaWiki\Extension\CampaignEvents\Event\EventRegistration::$meetingAddress of type ?MediaWiki\Extension\CampaignEvents\Address\Address

Uhhhhh of course it can't, I changed the format of the property. But I also bumped the cache version key in the same patch. Why is it trying to unserialize a value with an older version key??

Change #1165860 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Rename EventRegistration::$meetingAddress to $address for cache compat

https://gerrit.wikimedia.org/r/1165860

Change #1165867 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Update event serialization test to catch more issues

https://gerrit.wikimedia.org/r/1165867

Daimona triaged this task as Unbreak Now! priority.Jul 2 2025, 12:47 PM

450 seen for the last 24 hours. These would eventually fix themselves as the cache expires, but the cache in question has a TTL of up to 1 week, and that's too long to just wait it out.

450 seen for the last 24 hours. These would eventually fix themselves as the cache expires, but the cache in question has a TTL of up to 1 week, and that's too long to just wait it out.

Well, technically, for the last ~5 hours, as it's meta-only and wmf.8 reached group 1 ~5 hours ago. Also, this would get worse for group 2, hence making it a train blocker.

Change #1165860 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Rename EventRegistration::$meetingAddress to $address for cache compat

https://gerrit.wikimedia.org/r/1165860

Change #1165894 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@wmf/1.45.0-wmf.8] Rename EventRegistration::$meetingAddress to $address for cache compat

https://gerrit.wikimedia.org/r/1165894

Change #1165894 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@wmf/1.45.0-wmf.8] Rename EventRegistration::$meetingAddress to $address for cache compat

https://gerrit.wikimedia.org/r/1165894

Mentioned in SAL (#wikimedia-operations) [2025-07-02T15:46:46Z] <jnuche@deploy1003> Started scap sync-world: Backport for [[gerrit:1165894|Rename EventRegistration::$meetingAddress to $address for cache compat (T398413)]]

Mentioned in SAL (#wikimedia-operations) [2025-07-02T15:49:06Z] <jnuche@deploy1003> jnuche, daimona: Backport for [[gerrit:1165894|Rename EventRegistration::$meetingAddress to $address for cache compat (T398413)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-07-02T15:55:37Z] <jnuche@deploy1003> Finished scap sync-world: Backport for [[gerrit:1165894|Rename EventRegistration::$meetingAddress to $address for cache compat (T398413)]] (duration: 08m 51s)

jnuche claimed this task.
jnuche subscribed.

Fix is in prod

Change #1165867 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Update event serialization test to catch more issues

https://gerrit.wikimedia.org/r/1165867