Page MenuHomePhabricator
Create Task
Maniphest T398439

Temporary user link styling in content area should not adjust padding
Closed, ResolvedPublic
Actions

Assigned To
Esanders
Authored By
Esanders
Jul 2 2025, 1:07 PM
Tags
Referenced Files
F62779757: image.png
Jul 2 2025, 1:07 PM
F62779763: image.png
Jul 2 2025, 1:07 PM
F62779750: image.png
Jul 2 2025, 1:07 PM
F62779745: image.png
Jul 2 2025, 1:07 PM
Subscribers
Aklapper
Esanders
KColeman-WMF
Niharika
Tchanders

Description

Currently the styling adds padding to make the background color more visible. This is likely to cause problems with other places which expect text to flow normally and links not to have background text, for example opening the link in VE causes the width to change and content to reflow, or in a table where horizontal alignment is expected

We can add padding that doesn't cause a reflow using a CSS outline instead.

BeforeAfter
image.png (134×174 px, 7 KB)
image.png (134×174 px, 7 KB)
image.png (134×174 px, 7 KB)
image.png (134×174 px, 7 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
GlobalContributions: Use outline instead of padding for temp user linksmediawiki/extensions/CheckUsermaster+1 -1
Temporary user links: Use outline instead of paddingmediawiki/skins/MinervaNeuemaster+4 -2
Temporary user links: Use outline instead of paddingmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Jul 2 2025, 1:07 PM
Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptJul 2 2025, 1:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders added parent tasks: T347209: Investigate: Grey background for temporary usernames in signatures, mentions etc, T389961: Visual Editor should use the `action=query&prop=info&inprop=linkclasses` to color newly-added links.Jul 2 2025, 1:16 PM
Esanders removed a parent task: T389961: Visual Editor should use the `action=query&prop=info&inprop=linkclasses` to color newly-added links.
gerritbot added a comment.Jul 2 2025, 1:17 PM

Change #1165881 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/core@master] Temporary user links: Use outline instead of padding

https://gerrit.wikimedia.org/r/1165881

gerritbot added a project: Patch-For-Review.Jul 2 2025, 1:17 PM
Esanders added a project: Editing-team (Kanban Board).Jul 2 2025, 1:18 PM
Esanders moved this task from Inbox to Blocked / Needs More Work on the Editing-team (Kanban Board) board.
Esanders updated the task description. (Show Details)
Niharika moved this task from Inbox to Needs Other Teams on the Temporary accounts board.Jul 8 2025, 9:37 AM
Esanders added a subscriber: Tchanders.Jul 8 2025, 11:53 AM
gerritbot added a comment.Jul 8 2025, 1:02 PM

Change #1167213 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/MinervaNeue@master] Temporary user links: Use outline instead of padding

https://gerrit.wikimedia.org/r/1167213

Tchanders added a project: Trust and Safety Product Sprint (Sprint Cannoli (July 7 - July 25)).Jul 8 2025, 3:01 PM
Tchanders assigned this task to Esanders.Jul 8 2025, 3:10 PM
Tchanders moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Cannoli (July 7 - July 25)) board.
Tchanders added subscribers: KColeman-WMF, Niharika.
gerritbot added a comment.Jul 8 2025, 7:28 PM

Change #1165881 merged by jenkins-bot:

[mediawiki/core@master] Temporary user links: Use outline instead of padding

https://gerrit.wikimedia.org/r/1165881

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.10; 2025-07-15).Jul 8 2025, 8:00 PM
gerritbot added a comment.Jul 9 2025, 12:08 PM

Change #1167213 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Temporary user links: Use outline instead of padding

https://gerrit.wikimedia.org/r/1167213

Maintenance_bot removed a project: Patch-For-Review.Jul 9 2025, 12:31 PM
Esanders added a subtask: T399003: Temporary user icon shouldn't be included in highlight on mobile action=history (with advanced mode disabled).Jul 9 2025, 12:44 PM
Esanders mentioned this in T399003: Temporary user icon shouldn't be included in highlight on mobile action=history (with advanced mode disabled).
Esanders added a comment.Jul 9 2025, 12:47 PM

On Editing board for visibility but TSP will review/QA.

Tchanders moved this task from Needs Review to Needs Design Review on the Trust and Safety Product Sprint (Sprint Cannoli (July 7 - July 25)) board.Jul 9 2025, 12:47 PM
ppelberg edited projects, added Editing-team (Tracking); removed Editing-team (Kanban Board).Jul 14 2025, 5:15 PM
ppelberg moved this task from Backlog to Dependent on others on the Editing-team (Tracking) board.
KColeman-WMF added a comment.Jul 17 2025, 11:13 PM

This looks good to me. It's a bit tight at the edges but it solves the horizontal alignment issue.

Tchanders moved this task from Needs Design Review to Done on the Trust and Safety Product Sprint (Sprint Cannoli (July 7 - July 25)) board.Jul 18 2025, 7:17 AM

Thanks @KColeman-WMF

Tchanders closed this task as Resolved.Jul 18 2025, 7:18 AM
gerritbot added a comment.Jul 18 2025, 1:43 PM

Change #1170563 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] GlobalContributions: Use outline instead of padding for temp user links

https://gerrit.wikimedia.org/r/1170563

gerritbot added a project: Patch-For-Review.Jul 18 2025, 1:43 PM
gerritbot added a comment.Jul 18 2025, 2:14 PM

Change #1170563 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] GlobalContributions: Use outline instead of padding for temp user links

https://gerrit.wikimedia.org/r/1170563

Maintenance_bot removed a project: Patch-For-Review.Jul 18 2025, 2:31 PM
ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.11; 2025-07-22); removed MW-1.45-notes (1.45.0-wmf.10; 2025-07-15).Jul 18 2025, 3:00 PM
DLynch closed subtask T399003: Temporary user icon shouldn't be included in highlight on mobile action=history (with advanced mode disabled) as Resolved.Aug 20 2025, 3:17 PM
OKryva-WMF added a project: OKR-Work.Oct 3 2025, 3:58 PM
Esanders mentioned this in T400577: Grey background for temporary usernames overlaps the punctuation marks in RC and Watchlist with grouped mode.Dec 1 2025, 12:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits