Page MenuHomePhabricator

Remove TypeToString in favor of ZObjectToString
Open, In Progress, LowPublic

Description

Description

TypeToString and ZObjectToString show nearly identical outputs: an object represented as a string with links to the relevant pages.

  • ZObjectToString: used to represent parts of the main ZObject in the page, which was stored in a flat table, so worked with rowIds and zobject.js module getters.
    • Used to represent function calls in the collapsed Function Call component
    • Used to represent input and output types from the main ZObject in the About widget
  • TypeToString: was used on function types, and the input was the argument types stored in the library.js module (which was pure JSON form)

Currently, ZObjectToString receives as a property the whole Object to represent as a string, which means that this component could also be used instead of the TypeToString object in the FunctionExplorer widget.

NOTE: the only difference is that, according to the original Function Explorer designs, the links are black instead of blue.

Completion checklist

Event Timeline

Change #1211710 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] Remove TypeToString in favor of ZObjectToString

https://gerrit.wikimedia.org/r/1211710

DSmit-WMF changed the task status from Open to In Progress.Wed, Nov 26, 4:03 PM
DSmit-WMF claimed this task.