Page MenuHomePhabricator
Create Task
Maniphest T398460

Phab Scap template vs actual value out of sync for numerous values
Open, Needs TriagePublic
Actions

Description

https://phabricator.wikimedia.org/config/edit/maniphest.custom-field-definitions/ and the same setting in https://gitlab.wikimedia.org/repos/phabricator/deployment/-/blob/wmf/stable/scap/templates/phabricator/conf/local/local.json.j2 are out of sync.

That's probably the case for years.

https://phabricator.wmcloud.org/ at least seems to use the Scap values ("Local Config") and doesn't have any random custom stuff ("Database").

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
phabricator: drop elasticsearch settings in codfwoperations/puppetproduction+0 -21
phabricator: remove defunct ElasticSearch backend settingsoperations/puppetproduction+0 -22
Customize query in gerrit

Revisions and Commits

rPHDEP Phabricator Deployment
rPHDEP6cf9d0e48fa8 Add 'diffusion.fields' config from production database
rPHDEPe4f2481029cf Remove Releeph from "phabricator.uninstalled-applications"
rPHDEP2f4eda971076 Sync phabricator.uninstalled-applications setting from DB to config

Related Objects

Event Timeline

Aklapper created this task.Jul 2 2025, 3:42 PM
Aklapper added a project: Release-Engineering-Team (Priority Backlog 📥).
brennen subscribed.Jul 2 2025, 4:16 PM
Aklapper mentioned this in T398397: Remove remnants of Phatality ID in Phabricator ("error.id" custom field).Jul 2 2025, 4:34 PM
Aklapper mentioned this in T398197: 2100 tasks cannot be found by fulltext search (due to exception when indexing "Other Assignee" custom field).Jul 3 2025, 2:51 PM
Aklapper mentioned this in T398732: Add the 'other assignee' field to the Phabricator test instance.Jul 7 2025, 5:07 PM
A_smart_kitten subscribed.Jul 8 2025, 5:31 PM
Aklapper mentioned this in T388590: Stop writing "std:maniphest:security_topic" in "maniphest_customfieldstorage" DB table.Aug 7 2025, 1:25 PM
gerritbot added a comment.Sep 8 2025, 10:45 AM

Change #1185884 had a related patch set uploaded (by Aklapper; author: Aklapper):

[operations/puppet@production] phabricator: remove defunct ElasticSearch backend settings

https://gerrit.wikimedia.org/r/1185884

gerritbot added a project: Patch-For-Review.Sep 8 2025, 10:45 AM
Aklapper mentioned this in T403948: 'Fulltext' searches fail on test Phab instance due to ElasticSearch default config (PhutilAggregateException: All Fulltext Search hosts failed / CURLE_COULDNT_CONNECT).Sep 8 2025, 10:45 AM
gerritbot added a comment.Sep 16 2025, 3:09 PM

Change #1185884 merged by Dzahn:

[operations/puppet@production] phabricator: remove defunct ElasticSearch backend settings

https://gerrit.wikimedia.org/r/1185884

gerritbot added a comment.Sep 16 2025, 3:18 PM

Change #1188815 had a related patch set uploaded (by Dzahn; author: Dzahn):

[operations/puppet@production] phabricator: drop elasticsearch settings in codfw

https://gerrit.wikimedia.org/r/1188815

gerritbot added a comment.Sep 16 2025, 3:20 PM

Change #1188815 merged by Dzahn:

[operations/puppet@production] phabricator: drop elasticsearch settings in codfw

https://gerrit.wikimedia.org/r/1188815

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2025, 3:32 PM
A_smart_kitten added a comment.Sep 16 2025, 8:51 PM

<noting that the above patches were reverted; see T403948#11185883>

Aklapper mentioned this in T384243: Change the dropdown in security ticket dropdown to not include WMF Product and WMF Technology as two separate departments.Feb 13 2026, 3:02 PM
Aklapper mentioned this in T418033: Uninstall Countdown (Phabricator application).Feb 24 2026, 4:13 PM
A_smart_kitten added a comment.Apr 5 2026, 7:21 AM

q: Is the scope of this task maniphest.custom-field-definitions only, or is it any config setting for which the 'Database' value for production-Phabricator is different to the 'Local Config' value set in GitLab/by Scap?

Aklapper added a comment.Apr 5 2026, 10:00 AM

The former. The latter is not a problem per-se.

A_smart_kitten added a comment.Apr 5 2026, 12:16 PM

Fair enough. Speaking personally, though, it would be nice if Phab's config could be public (ie., I guess in GitLab) where it can be :)

Aklapper added a commit: rPHDEP2f4eda971076: Sync phabricator.uninstalled-applications setting from DB to config.Mon, May 18, 9:14 AM
Aklapper mentioned this in rPHDEP1e82e4046fd4: Sync maniphest.custom-field-definitions config with test instance DB.Mon, May 18, 9:49 AM
Aklapper added a comment.Mon, May 18, 9:49 AM
Aklapper mentioned this in T426754: Deploy Phab/Phorge 2026-05-19.Tue, May 19, 3:19 PM
Aklapper renamed this task from Phab Scap template vs actual value out of sync for maniphest.custom-field-definitions to Phab Scap template vs actual value out of sync for numerous values.Wed, May 27, 10:26 AM
Aklapper added a comment.Wed, May 27, 10:31 AM

Switched a few more now-identical config settings from reading DB to reading JSON config file:

aklapper@phab1004:~$ cd /srv/phab/phabricator/
aklapper@phab1004:/srv/phab/phabricator$ sudo ./bin/config delete --database "metamta.recipients.show-hints"
  Deleted 'metamta.recipients.show-hints' from database configuration.
aklapper@phab1004:/srv/phab/phabricator$ sudo ./bin/config delete --database "maniphest.points"
  Deleted 'maniphest.points' from database configuration.
aklapper@phab1004:/srv/phab/phabricator$ sudo ./bin/config delete --database "ui.logo"
  Deleted 'ui.logo' from database configuration.
Aklapper added a commit: rPHDEPe4f2481029cf: Remove Releeph from "phabricator.uninstalled-applications".Thu, May 28, 10:12 AM
Aklapper added a comment.Thu, May 28, 10:16 AM

Removed Releeph from config file in https://gitlab.wikimedia.org/repos/phabricator/deployment/-/commit/e4f2481029cf60edf63096f28b2bd6896a0ff571

aklapper@phab1004:/srv/phab/phabricator$ sudo ./bin/config delete --database "phabricator.uninstalled-applications"
Deleted 'phabricator.uninstalled-applications' from database configuration.
Aklapper added a comment.Fri, May 29, 12:51 PM
aklapper@phab1004:/srv/phab/phabricator$ sudo ./bin/config delete --database "differential.fields"
Deleted 'differential.fields' from database configuration.
Aklapper added a commit: rPHDEP6cf9d0e48fa8: Add 'diffusion.fields' config from production database.Fri, May 29, 1:06 PM
Aklapper added a comment.Fri, May 29, 1:14 PM

Added 'diffusion.fields' config from production database in https://gitlab.wikimedia.org/repos/phabricator/deployment/-/commit/6cf9d0e48fa8f1cd4365bb226e1a3811fe37f719

aklapper@phab1004:/srv/phab/phabricator$ sudo ./bin/config delete --database "maniphest.statuses"
Deleted 'maniphest.statuses' from database configuration.
Aklapper mentioned this in T410849: Update to Phorge/Arcanist upstream 2026-06-01.Tue, Jun 9, 3:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits