Page MenuHomePhabricator

PHP71NullableDocOptionalArg reporting violation on untyped parameter
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce

Add a parameter with a parameter with a default value of null and without any type declaration, but with a nullable PHPDoc type. Example

Actual result

PHPCS violation saying

Use nullable type("?Title") for parameters documented as nullable (MediaWiki.Commenting.FunctionComment.PHP71NullableDocOptionalArg)

Expected result

No PHPCS violation

Software version

mediawiki/mediawiki-codesniffer 47.0.0

Other information

Per https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#Don't_add_type_declarations_for_%22big%22_legacy_classes, this parameter should not have a type declaration.

Event Timeline

Change #1175269 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/tools/codesniffer@master] FunctionCommentSniff: Remove PHP71NullableDocOptionalArg error

https://gerrit.wikimedia.org/r/1175269

Change #1175268 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MassMessage@master] build: Remove phpcs exclude by changing documented type

https://gerrit.wikimedia.org/r/1175268

Change #1175268 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] build: Remove phpcs exclude by changing documented type

https://gerrit.wikimedia.org/r/1175268

Change #1175269 merged by jenkins-bot:

[mediawiki/tools/codesniffer@master] FunctionCommentSniff: Remove PHP71NullableDocOptionalArg error

https://gerrit.wikimedia.org/r/1175269

Change #1184919 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/tools/codesniffer@master] HISTORY: Tag as v48.0.0

https://gerrit.wikimedia.org/r/1184919

Change #1184919 merged by jenkins-bot:

[mediawiki/tools/codesniffer@master] HISTORY: Tag as v48.0.0

https://gerrit.wikimedia.org/r/1184919