Page MenuHomePhabricator

Add the 'other assignee' field to the Phabricator test instance
Closed, ResolvedPublic

Description

The 'other assignee' field isn't currently present on the Phabricator test instance (relevant config: https://phabricator.wmcloud.org/config/edit/maniphest.custom-field-definitions/).
Adding it would (hopefully) make it easier to debug issues like T396878: "Other assignee" icon disappears briefly after loading a workboard in a test environment, in addition to making it possible to add 'other assignees' for tasks on the test instance at all.

As an admin on the test instance, I think I have the technical access to make this change myself, but - if I was going to make the change myself - I absolutely would not want to do it without checking with other people about it first, & checking that it's definitely a good idea to do it. [Hence this task :)]

It looks like the config for the 'other assignee' field was pasted to https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/1#note_21033 in March 2023, although I wouldn't know if it's changed since then or not.

Event Timeline

To me the problem to fix is "test instance config is different from prod instance" regardless of the specific setting.

This gets back to the old issue of:

"a test instance is supposed to be like production, otherwise it's not good for testing"

vs

"the test instance is where anyone is supposed to easily make changes to be able to test them before they hit production"

and the answer to that is "technically each service needs at least 2 test instances, one "like-prod" and one to stage new things" but on the other hand that creates even more work

In case I've accidentally opened a can of worms with this task (apologies if so!), I'd be fine with adding the field for use in testing it, and then removing it at any time in the future / if someone wants to test without it at any point :)

@A_smart_kitten You can be bold with this one. If you just want to add it, please go ahead! And thank you for using the test instance and reporting these things.

Thanks @Dzahn! I've done that now - for the record, I've left the new value I've changed that config setting to at P78793 (paste limited to acl*releng & acl*sre-team just in case, as I'm not sure whether this config counts as non-public or not).

Feel free to close this task out now if there's nothing left to do here (I would, but I'm not sure if folks want to use this task to track anything else as well; e.g. T398732#10980302) :)

And thank you for using the test instance and reporting these things.

No problem - thank you (collab, releng) for maintaining the test instance!

Thank you. I will call it resolved.

The paste you linked to does not seem to be secret to me either.

If we run into the issue of "test instance is not like prod instance" more often we can always get back to that topic with a fresh more general task.

You can be bold with this one. If you just want to add it, please go ahead!

+1. Once/if we've sorted out T398460 the field will still be there anyway :D