Page MenuHomePhabricator

New git version tag for oauthclient-php
Closed, ResolvedPublicFeature

Description

Please create a new version for https://gerrit.wikimedia.org/g/mediawiki/oauthclient-php
The existing one throws all sorts of warnings. Just need a new tag, no new code.

Details

Related Changes in Gerrit:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
A_smart_kitten renamed this task from New git version tag for Oauth to New git version tag for oathclient-php.Jul 7 2025, 7:03 AM
A_smart_kitten renamed this task from New git version tag for oathclient-php to New git version tag for oauthclient-php.
Jdforrester-WMF subscribed.

Which of the changes in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/oauthclient-php/+log/refs/heads/master since v2.2.0 has fixed the warnings you're getting? Can you give an example of the warnings?

PHP 8.4 now does this complaint in 2.2.0 version, which is now fixed in master/main:
Deprecated: MediaWiki\OAuthClient\Client::__construct(): Implicitly marking parameter $logger as nullable is deprecated, the explicit nullable type must be used instead in .../vendor/mediawiki/oauthclient/src/Client.php on line 77

Deprecated: MediaWiki\OAuthClient\Client::makeOAuthCall(): Implicitly marking parameter $postFields as nullable is deprecated, the explicit nullable type must be used .../vendor/mediawiki/oauthclient/src/Client.php on line 246

Deprecated: MediaWiki\OAuthClient\Client::makeCurlCall(): Implicitly marking parameter $postFields as nullable is deprecated, the explicit nullable type must be used .../vendor/mediawiki/oauthclient/src/Client.php on line 302

Yeah. I just need a new version number. I really dislike having composer ask for "the latest and greatest, good luck"

Change #1167208 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/oauthclient-php@master] Prepare to tag version 3.0.0

https://gerrit.wikimedia.org/r/1167208

DAlangi_WMF changed the task status from Open to In Progress.Jul 8 2025, 12:38 PM
DAlangi_WMF claimed this task.

Change #1167208 merged by jenkins-bot:

[mediawiki/oauthclient-php@master] Prepare to tag version 2.3.0

https://gerrit.wikimedia.org/r/1167208

Thank you @Tgr for reviewing. The 2.3.0 tag has been pushed. @AManWithNoPlan, let us know if the new tag resolves the issue(s) you reported. Thanks!