[Search] Update entity order on dropdown menu
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Arian_Bozorg
	Jul 7 2025, 12:09 PM

Description

To align with the searches that are being made we need to update the order of the entities on the Scoped Typeahead Search dropdown menu.

The order is currently:
Lexeme
Item
Property
EntitySchema

and the new order should be:
Item
Property
Lexeme
EntitySchema

Steps to reproduce

Install Wikibase, WikibaseLexeme, WikibaseCirrusSearch, WikibaseLexemeCirrusSearch (EntitySchema is optional)
set $wgLexemeUseCirrus = true;
set $wgWBRepoSettings['tmpEnableScopedTypeaheadSearch'] = true;
load any page with ?useskin=vector-2022
click into the search input
open the entity type dropdown

Acceptance Criteria

The dropdown menu is updated with the entity types in the order: Item - Property - Lexeme - EntitySchema

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	WikibaseRepoEntityTypesHookHandler: Don’t reorder entity types	mediawiki/extensions/WikibaseLexemeCirrusSearch	master	+79 -4
	WikibaseRepoEntityTypesHookHandler: Don’t reorder entity types	mediawiki/extensions/WikibaseCirrusSearch	master	+77 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Arian_Bozorg	T321543 [EPIC] Making other entity types more accessible through the search box
		Resolved		Arian_Bozorg	T398817 [Search] Update entity order on dropdown menu

Event Timeline

Arian_Bozorg created this task.Jul 7 2025, 12:09 PM

Arian_Bozorg updated the task description. (Show Details)

Lucas_Werkmeister_WMDE removed a project: Epic.Jul 7 2025, 3:09 PM

karapayneWMDE moved this task from Incoming to Ready for Task Time (Story Writing) on the Wikidata-Omega board.Jul 15 2025, 2:21 PM

FWIW, I get the correct order on my local wiki:

Hopefully the issue in production won’t be too tricky to reproduce / investigate anyway.

Okay, it’s reproducible by enabling $wgLexemeUseCirrus = true; in LocalSettings.php.

Change #1175900 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseCirrusSearch@master] WikibaseRepoEntityTypesHookHandler: Don’t reorder entity types

https://gerrit.wikimedia.org/r/1175900

Change #1175901 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] WikibaseRepoEntityTypesHookHandler: Don’t reorder entity types

https://gerrit.wikimedia.org/r/1175901

FTR, I decided to look into this, and work on the above patches, because the rest of our backlog was unit test tasks (subtasks of T400154), and I didn’t want to work on too many of those at once while others were still in peer review.

I would consider this task ready for peer review now, but I don’t want to rip it out of “ready for task time” prematurely if others think it still needs more work, so I’ll leave it where it is.

Arian_Bozorg reassigned this task from Arian_Bozorg to Lucas_Werkmeister_WMDE.Aug 6 2025, 9:40 AM

Arian_Bozorg moved this task from Ready for Task Time (Story Writing) to Completed Tasks on the Wikidata-Omega board.

Arian_Bozorg edited projects, added Wikidata-Omega (Completed Tasks); removed Wikidata-Omega.

Arian_Bozorg moved this task from Completed Tasks to The Backlog on the Wikidata-Omega board.

Arian_Bozorg edited projects, added Wikidata-Omega; removed Wikidata-Omega (Completed Tasks).

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Aug 6 2025, 10:00 AM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

Lucas_Werkmeister_WMDE edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.

Lucas_Werkmeister_WMDE moved this task from new to the board to Ready for Peer Review on the Wikidata-Omega (The Board) board.

ArthurTaylor claimed this task.Aug 6 2025, 11:03 AM

ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.

Change #1175900 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] WikibaseRepoEntityTypesHookHandler: Don’t reorder entity types

https://gerrit.wikimedia.org/r/1175900

ArthurTaylor removed ArthurTaylor as the assignee of this task.Aug 6 2025, 11:53 AM

ArthurTaylor moved this task from In Peer Review to Ready for Tech Verification on the Wikidata-Omega (The Board) board.

ArthurTaylor subscribed.

I’d say this belongs in Product Verification? Should be testable on Beta Wikidata once the WikibaseLexemeCirrusSearch change merges in half an hour or so. (Right now I can still reproduce the issue there.)

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.14; 2025-08-12).Aug 6 2025, 12:00 PM

Change #1175901 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] WikibaseRepoEntityTypesHookHandler: Don’t reorder entity types

https://gerrit.wikimedia.org/r/1175901

Maintenance_bot removed a project: Patch-For-Review.Aug 6 2025, 12:31 PM

Lucas_Werkmeister_WMDE mentioned this in rEWLC66c926df544f: WikibaseRepoEntityTypesHookHandler: Don’t reorder entity types.Aug 6 2025, 1:10 PM