Page MenuHomePhabricator

Close all tabs flow
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

After the release of Tabs V1, we are adding nice-to-have improvements into V2.

Requirements
  • Add option to Close all tabs into Tabs overview overflow menu
  • Show a confirmation dialog before someone closes tabs
  • For behavior when all tabs are closed, please consult variant tickets for behavior. Control stays as is
Designs

https://www.figma.com/design/5gHmEo8IIFxlPfYM6bppzz/iOS---%3E-More-Dynamic-Tabs?node-id=457-8150&t=6J80rBHZB5ZD98rj-4

QA Notes

Test in TestFlight Wikipedia build 7.8.4 (latest).
Developer Settings toggle for forcing: "Enable tabs V2 with group {letter}"

Event Timeline

HNordeenWMF triaged this task as Low priority.

@HNordeenWMF A couple of questions:

  • Can we get designs (or at least copy) for the confirmation dialog and toasts?
  • There was a design requirement in V1 that we never show an empty state, that is, there is always at least 1 current tab on screen. So when we close all tabs, I expect all tabs will be removed and replaced by a single "Main" page tab. Is that expected?

designs for the close all tabs flow are as follows:

Screenshot 2025-07-08 at 12.17.14 PM.png (1×1 px, 1 MB)

as for the design requirement for V1 — yes, when all tabs are closed, we should keep one "tab" open but it should be a new tab — i.e. whatever we decide to show for the final new tab design which is forthcoming, which will not be the Main Page. this is in accordance with platform standards, as in this is the way Safari handles this behavior.

@Tsevener @HNordeenWMF let me know if this makes sense!

If we do this, we'll need designs for what the new tab experiences should look like in the overview (Robin made a custom one for the Main page). Let's see what makes sense in planning: If we're doing the active search variant, then it has to be "over" some page, and that could still be the main page

Mazevedo updated the task description. (Show Details)
Mazevedo updated the task description. (Show Details)

UPDATE: https://wikimedia.slack.com/archives/C4DDMJ9CH/p1755200114472309

Changed text -> Close other tabs, got rid of numbers (close all x tabs)
Changed functionality -> If there's only one tab, do not display the close all tabs button, if more than one, close all tabs except the current one.

    1. Test Steps
  1. Open a variety of tabs, making note of which one you are currently on
  2. Go into tabs overview
  3. Press close all other tabs
  4. Ensure pop up allows you to cancel or complete the action
  5. After completion, make sure the current tab you were on is still open / usable
  6. If you only have one tab open, make sure the close all tabs button is NOT present
ABorbaWMF subscribed.

Testing on 7.8.1 (5733)

This appears to be working on the phone, but I do not see an overflow menu on the iPad.

Screenshot 2025-08-25 at 3.47.52 PM.png (2×2 px, 473 KB)

Moving back to QA signoff. I think I did not have the correct developer setting

Looks good on 7.8.1 (5733)

Tested on iPhone on iOS 26.0 and iPad on iPadOS 26. Tested on all themes

JTannerWMF subscribed.

I believe this is unchanged but I want this task to be tested when the rest of the feature is redone.

The number of tabs in the confirmation dialog is not updating correctly, so we're moving to needs eng sync to be worked on soon.

Please design review on Staging 7.8.4 (109).

Update:

Please design review on Staging 7.8.4 (110) for Group B.
Please design review on Staging 7.8.4 (111) for Group C.

Before your first app launch, ensure your device is in a target experiment region (I use Germany).

this seems to have been a part of this ticket — I reviewed earlier there. @Tsevener @GOlson-WMF can this be joined to that ticket?

@SChekfa-WMF this can absolutely be the other ticket!

Group B: Staging 115
Group C: Staging 116

Appears to be fixed on 7.8.4 (5853)

Tested on iPhone 16 on iOS 26, iPad 12.9 on iPadOS 26, and iPhone 11 on iOS 18. Tested on both tab groups.