PR https://github.com/wikimedia/wikipedia-ios/pull/5368

Appears to be fixed on 7.8.1 (5969)

Tested on iPhone on iOS 26.0 and iPad on iPadOS 18.5. Tested on all themes

l-olson1214 opened https://github.com/wikimedia/wikipedia-ios/pull/5447

mazevedofs closed https://github.com/wikimedia/wikipedia-ios/pull/5447

Please design review on Staging 7.8.4 (109).

thanks for working on this. some notes for improvement:

1. when i navigate to tabs from Explore, with no tabs open, I see the main page has an active border around it. this should not be the case, as the main page is not active in this instance. per the spec, "Main page can have an active border if that is the active tab. For example, if user taps on "Main page" then immediately taps on the "tab icon" they will see that the main page is the active tab." what i'm seeing now

2. the overflow menu placement is incorrect. it should be in the rightmost corner, while the new tab (+) should be to its left.

3. per the requirements in the ticket, "If user has more than two active tabs (not including initial mainpage tab) users should see Because You Read article recommendations in place of Did You Know content." I am seeing the BYR recommendations even when I have one active tab open (not including the initial mainpage tab):

4. when i open a new tab, a glimmer of the main page appears before the active Search state appears. this should not be happening — the user should be dropped directly into the active search state. please refer to the prototype Tais created for the appropriate animation to use here. what i'm seeing now

@Tsevener @GOlson-WMF

when i navigate to tabs from Explore, with no tabs open, I see the main page has an active border around it. this should not be the case, as the main page is not active in this instance. per the spec, "Main page can have an active border if that is the active tab. For example, if user taps on "Main page" then immediately taps on the "tab icon" they will see that the main page is the active tab." what i'm seeing now

Yeah, that is some fallout from the original architecture in V1. It is set up so that the initial main page tab is considered "current", because we need to add an article to the current tab upon navigation. See requirements from T390999 and T392398.

The minimum amount of tabs is 1 (see how this looks here). If no article has been searched yet, the tab contains the main page.
Explore [or any root view]:
Article opens in the current tab, user is taken there.

So that initial single main page tab has to be considered current for articles to be added to it upon navigation, and for V2 we added a border to the current tab. So that's why you see it. I'll try to find some non-risky way to suppress it.

the overflow menu placement is incorrect. it should be in the rightmost corner, while the new tab (+) should be to its left.

@GOlson-WMF Can you look into this one?

per the requirements in the ticket, "If user has more than two active tabs (not including initial mainpage tab) users should see Because You Read article recommendations in place of Did You Know content." I am seeing the BYR recommendations even when I have one active tab open (not including the initial mainpage tab):

This came from https://wikimedia.slack.com/archives/C4DDMJ9CH/p1759433498839539 - the Main Page contributes to Because You Read recommendations. @HNordeenWMF can you chime in on if this is the correct interpretation?

when i open a new tab, a glimmer of the main page appears before the active Search state appears. this should not be happening — the user should be dropped directly into the active search state. please refer to the prototype Tais created for the appropriate animation to use here. what i'm seeing now

I'll take a look at this one!

@Tsevener on it!

@SChekfa-WMF & @Tsevener yes - sorry I was not aware of the original requirements here. Please filter out the main page when counting tabs for recommendations. It's ok if people with 2+ tabs that are all main page still see DYK.

l-olson1214 opened https://github.com/wikimedia/wikipedia-ios/pull/5469

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/5469

@SChekfa-WMF Have a couple of builds for you!

Staging 7.8.4 (110)

I am temporarily forcing Group B assignment in this build upon app launch, this will be closer to a true test of the initial app state for Group B users without having to toggle developer settings. Please change your device region to a target region (I use Germany in my testing) before launching for the first time.

when i navigate to tabs from Explore, with no tabs open, I see the main page has an active border around it. this should not be the case, as the main page is not active in this instance. per the spec, "Main page can have an active border if that is the active tab. For example, if user taps on "Main page" then immediately taps on the "tab icon" they will see that the main page is the active tab." what i'm seeing now

Should be fixed in this build, initial Main Page tab is not highlighted as current at first.

the overflow menu placement is incorrect. it should be in the rightmost corner, while the new tab (+) should be to its left.

Should be fixed in this build (thanks @GOlson-WMF)

per the requirements in the ticket, "If user has more than two active tabs (not including initial mainpage tab) users should see Because You Read article recommendations in place of Did You Know content." I am seeing the BYR recommendations even when I have one active tab open (not including the initial mainpage tab):

Not yet in this build, @GOlson-WMF is working on this piece.

when i open a new tab, a glimmer of the main page appears before the active Search state appears. this should not be happening — the user should be dropped directly into the active search state. please refer to the prototype Tais created for the appropriate animation to use here. what i'm seeing now

This should be fixed in this build

(Slack feedback)

I noticed that when a user opens a new tab --> enters active search state --> cancels without tapping into any article, then tap the back button from the main page, the main page stays open.

This is not fixed, lmk if it's a must-have @HNordeenWMF. This would technically be auto-closing a tab when tapping a back button, which was a hard V1 no-no (per design). So we inherited this behavior for V2.

when a user opens a new tab, searches for and taps into an article, the back icon is showing "Main Page" as the previous page they were on, which is not true — back should take them back to the previous screen they were on, which in the case i'm attaching here is Terraria:

This should be fixed now in this build.

the main page should only appear when you tap "cancel" from the active search state. not between tapping + and entering the active search

This should be fixed now, the Main Page should no longer flash as it's navigating upon tapping the + button.

@SChekfa-WMF

Staging 7.8.4 (111)

This build temporarily forces Group C assignment upon app launch, which will be closer to a true test of the initial app state for Group C users without having to toggle developer settings. Please change your device region to a target region (I use Germany in my testing) before launching for the first time.

tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/5471

l-olson1214 opened https://github.com/wikimedia/wikipedia-ios/pull/5472

@Tsevener i don't think i'm seeing the right Group B here — you said it's group C on launch, and even when I toggle to group B it seems like I'm seeing group C.

this is what i'm seeing. my region is set to germany.

l-olson1214 closed https://github.com/wikimedia/wikipedia-ios/pull/5471

l-olson1214 closed https://github.com/wikimedia/wikipedia-ios/pull/5472

i don't think i'm seeing the right Group B here — you said it's group C on launch, and even when I toggle to group B it seems like I'm seeing group C.

@SChekfa-WMF
This feature is tricky because stuff happens immediately upon launch (such as creating the default main tab for Group B, but not creating a default main tab for Group C). It doesn't lend itself well to changing groups via developer settings after-the-fact, at least for testing initial things like empty state, tab border, etc.

So my advise is for certain initial state logic, test the group-specific builds:

https://phabricator.wikimedia.org/T398888#11257055
To test Group B, set device region to target country and install Staging 7.8.4 (110). Do not change to a different group via developer settings after-the-fact.

https://phabricator.wikimedia.org/T398888#11257073
To test Group C, set device region to target country and install Staging 7.8.4 (111). Do not change to a different group via developer settings after-the-fact.

@SChekfa-WMF

I have a couple of new builds with our latest design review tweaks.

To test Group B, set device region to target country and install Staging 7.8.4 (112).
To test Group C, set device region to target country and install Staging 7.8.4 (113).

This is all the fixes mentioned in https://phabricator.wikimedia.org/T398888#11257055 plus a fix for this:

per the requirements in the ticket, "If user has more than two active tabs (not including initial mainpage tab) users should see Because You Read article recommendations in place of Did You Know content." I am seeing the BYR recommendations even when I have one active tab open (not including the initial mainpage tab):

Not yet in this build, @GOlson-WMF is working on this piece.

@Tsevener i'm not seeing build 112 unfortunately, only 113 — here is what i'm seeing

@SChekfa-WMF - kicked off a new build Staging 114 - let me know if that shows up (it'll be a few from when this message comes in, but by noon EST you will be good)

Group B: Staging 115
Group C: Staging 116

LGTM, thank you! moving to code review. @Tsevener @GOlson-WMF

Appears to be fixed on 7.8.4 (5853)

Tested on iPhone 16 on iOS 26, iPad 12.9 on iPadOS 26, and iPhone 11 on iOS 18. Tested on all themes.