ApiFeedContributions.php on l
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

None

Authored By

	Aklapper
	Jul 8 2025, 9:36 AM

Description

Error

mwversion: 1.45.0-wmf.9
timestamp: 2025-07-08T09:23:47.315Z
phpversion: 8.1.32
reqId: 69001a60-8c24-4155-9aae-ea9a65476ac3
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   TypeError: MediaWiki\Api\ApiFeedContributions::feedItem(): Argument #1 ($row) must be of type stdClass, Flow\Formatter\ContributionsRow given, called in /srv/mediawiki/php-1.45.0-wmf.9/includes/api/ApiFeedContributions.php on l

Frame	Location	Call
from	/srv/mediawiki/php-1.45.0-wmf.9/includes/api/ApiFeedContributions.php(189)
#0	/srv/mediawiki/php-1.45.0-wmf.9/includes/api/ApiFeedContributions.php(179)	MediaWiki\Api\ApiFeedContributions->feedItem(Flow\Formatter\ContributionsRow)
#1	/srv/mediawiki/php-1.45.0-wmf.9/includes/api/ApiMain.php(2016)	MediaWiki\Api\ApiFeedContributions->execute()
#2	/srv/mediawiki/php-1.45.0-wmf.9/includes/api/ApiMain.php(954)	MediaWiki\Api\ApiMain->executeAction()
#3	/srv/mediawiki/php-1.45.0-wmf.9/includes/api/ApiMain.php(925)	MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#4	/srv/mediawiki/php-1.45.0-wmf.9/includes/api/ApiEntryPoint.php(152)	MediaWiki\Api\ApiMain->execute()
#5	/srv/mediawiki/php-1.45.0-wmf.9/includes/MediaWikiEntryPoint.php(198)	MediaWiki\Api\ApiEntryPoint->execute()
#6	/srv/mediawiki/php-1.45.0-wmf.9/api.php(44)	MediaWiki\MediaWikiEntryPoint->run()
#7	/srv/mediawiki/w/api.php(3)	require(string)
#8	{main}

Impact

Moderate as we've only deployed wmf9 to group0 so far, but I am worried about group1 thus setting as train blocker. (Feel free to correct me.)

Notes

Regression from https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/f8235d53b2b755b12f5607a849ef371b20c34e9c%5E%21/includes/api/ApiFeedContributions.php
Steps to reproduce: Go to e.g. https://www.mediawiki.org/w/api.php?action=feedcontributions&feedformat=atom&user=Chaubunhtha1996
Cannot reproduce for every user; requires having edited a StructuredDiscussions page to show up in the Contributions feed
No issue on https://www.mediawiki.org/wiki/Special:Contributions/username; seems to only affect the atom feed via API?

Details

Request URL: https://www.mediawiki.org/w/api.php?action=feedcontributions&feedformat=atom&user=*

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Make FormatterRow extend stdClass	mediawiki/extensions/Flow	master	+2 -1
Remove stdClass type hint from ApiFeedContributions::feedItem() for now	mediawiki/core	wmf/1.45.0-wmf.9	+2 -2
Remove stdClass type hint from ApiFeedContributions::feedItem() for now	mediawiki/core	master	+2 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	Aklapper	T392179 1.45.0-wmf.9 deployment blockers
		Resolved	PRODUCTION ERROR	None	T398925 TypeError: MediaWiki\Api\ApiFeedContributions::feedItem(): Argument #1 ($row) must be of type stdClass, Flow\Formatter\ContributionsRow given, called in /srv/mediawiki/php-1.45.0-wmf.9/includes/api/ApiFeedContributions.php on l

Event Timeline

Aklapper created this task.Jul 8 2025, 9:36 AM

Aklapper triaged this task as Unbreak Now! priority.

Zabe subscribed.Jul 8 2025, 9:54 AM

Maintenance_bot added a project: MW-Interfaces-Team.Jul 8 2025, 10:30 AM

Also CC'ing reviewers of the original patch as this will block the train tomorrow from proceeding

Maybe Flow's FormatterRow could extend stdClass given that ApiFeedContributionsfeedItemHook::onApiFeedContributionsfeedItem already is documented with stdClass and this typically what a "data row" means in MW. ContribsPager__reallyDoQueryHook is still vaguely documented about &$data just being some array, it should also use stdClass if ApiFeedContribution::feedItem is requiring stdClass .

The quick-n-dirty fix is just removing that type hint in feedItem() for now.

Change #1167271 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/extensions/Flow@master] Make FormatterRow extend stdClass

https://gerrit.wikimedia.org/r/1167271

gerritbot added a project: Patch-For-Review.Jul 8 2025, 6:07 PM

Thanks for the patch!

The quick-n-dirty fix is just removing that type hint in feedItem() for now.

This seems reasonable for now, just to get the train moving again. Can always add the type hint back later.

A_smart_kitten added a project: StructuredDiscussions.Jul 8 2025, 6:37 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 8 2025, 6:37 PM

Change #1167279 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] Remove stdClass type hint from ApiFeedContributions::feedItem() for now

https://gerrit.wikimedia.org/r/1167279

Change #1167279 merged by jenkins-bot:

[mediawiki/core@master] Remove stdClass type hint from ApiFeedContributions::feedItem() for now

https://gerrit.wikimedia.org/r/1167279

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.10; 2025-07-15).Jul 8 2025, 9:00 PM

Change #1167296 had a related patch set uploaded (by Zabe; author: Aaron Schulz):

[mediawiki/core@wmf/1.45.0-wmf.9] Remove stdClass type hint from ApiFeedContributions::feedItem() for now

https://gerrit.wikimedia.org/r/1167296

Change #1167296 merged by jenkins-bot:

[mediawiki/core@wmf/1.45.0-wmf.9] Remove stdClass type hint from ApiFeedContributions::feedItem() for now

https://gerrit.wikimedia.org/r/1167296

Mentioned in SAL (#wikimedia-operations) [2025-07-08T22:09:36Z] <zabe@deploy1003> Started scap sync-world: Backport for [[gerrit:1167296|Remove stdClass type hint from ApiFeedContributions::feedItem() for now (T398925)]]

Mentioned in SAL (#wikimedia-operations) [2025-07-08T22:12:11Z] <zabe@deploy1003> zabe: Backport for [[gerrit:1167296|Remove stdClass type hint from ApiFeedContributions::feedItem() for now (T398925)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-07-08T22:18:10Z] <zabe@deploy1003> Finished scap sync-world: Backport for [[gerrit:1167296|Remove stdClass type hint from ApiFeedContributions::feedItem() for now (T398925)]] (duration: 08m 33s)

Zabe closed this task as Resolved.Jul 8 2025, 10:23 PM

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.9; 2025-07-08); removed MW-1.45-notes (1.45.0-wmf.10; 2025-07-15).Jul 8 2025, 11:00 PM

Thanks everyone!

Mentioned in SAL (#wikimedia-operations) [2025-07-09T08:01:31Z] <aklapper@deploy1003> Started scap sync-world: Backport for [[gerrit:1167296|Remove stdClass type hint from ApiFeedContributions::feedItem() for now (T398925)]]

Mentioned in SAL (#wikimedia-operations) [2025-07-09T08:03:57Z] <aklapper@deploy1003> zabe, aklapper: Backport for [[gerrit:1167296|Remove stdClass type hint from ApiFeedContributions::feedItem() for now (T398925)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-07-09T08:09:53Z] <aklapper@deploy1003> Finished scap sync-world: Backport for [[gerrit:1167296|Remove stdClass type hint from ApiFeedContributions::feedItem() for now (T398925)]] (duration: 08m 21s)

Change #1167271 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/Flow@master] Make FormatterRow extend stdClass

Reason:

No longer needed