Page MenuHomePhabricator
Create Task
Maniphest T398969

Parsoid emits parsoid fragment markers on some template namespace pages
Closed, ResolvedPublic
Actions

Description

See Parsoid output vs legacy output. This looks like a bug in Parsoid's fragment support likely.

Also seen on this awawiki template page.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.23.0-a11mediawiki/vendormaster+83 -21
Add a regression test for leaking fragment markermediawiki/services/parsoidmaster+9 -0
Bump wikimedia/parsoid to 0.23.0-a3mediawiki/vendormaster+333 -118
Add tests for template pre hackmediawiki/services/parsoidmaster+177 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

ssastry created this task.Jul 8 2025, 1:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2025, 1:40 PM
SLopes-WMF moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Jul 10 2025, 2:13 PM
cscott edited projects, added Content-Transform-Team (Work In Progress); removed Content-Transform-Team.Jul 10 2025, 2:38 PM
cscott moved this task from Backlog to Q3 FY25-26 on the Content-Transform-Team (Work In Progress) board.
ssastry renamed this task from Parsoid doesn't process Template:Hlist correctly on cbk_zamwiki to Parsoid emits parsoid fragmnet markers on some template namespace pages.Jul 15 2025, 5:48 PM
ssastry updated the task description. (Show Details)
ssastry renamed this task from Parsoid emits parsoid fragmnet markers on some template namespace pages to Parsoid emits parsoid fragment markers on some template namespace pages.Jul 15 2025, 8:50 PM
ABreault-WMF subscribed.Jul 18 2025, 11:09 PM

https://parsoid-vs-core.wmflabs.org/diff/fatwiki/Template:Hidden_begin%2Ftestcases is another example

ABreault-WMF claimed this task.Aug 6 2025, 10:46 PM
ABreault-WMF triaged this task as Medium priority.
ABreault-WMF moved this task from Q3 FY25-26 to In Progress on the Content-Transform-Team (Work In Progress) board.
ABreault-WMF added a subtask: T353697: Parsoid/legacy parser {{Pre}} template rendering difference.
ssastry raised the priority of this task from Medium to High.Sep 8 2025, 8:08 PM

This is showing up on lots of wikis and we should fix this sooner than later.

cscott subscribed.Sep 21 2025, 4:14 PM

I believe this is caused by the <pre> extension, which is not fragment-aware. We already use the PFragment machinery to dispatch legacy extension tags. My plan to address this is to attempt to use the PFragment machinery to dispatch Parsoid-native extensions as well. (I expect this bug to affect all Parsoid-native extensions t the moment.) Template:Pre is a bit of an unusual case, though, so some special case case in the pre handler may still be necessary, we'll see.

cscott claimed this task.Oct 6 2025, 3:29 PM
MSantos added a project: OKR-Work.Oct 20 2025, 2:05 PM
gerritbot added a comment.Nov 7 2025, 1:37 AM

Change #1202885 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Add tests for template pre hack

https://gerrit.wikimedia.org/r/1202885

gerritbot added a project: Patch-For-Review.Nov 7 2025, 1:37 AM
gerritbot added a comment.Nov 7 2025, 3:11 AM

Change #1202885 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add tests for template pre hack

https://gerrit.wikimedia.org/r/1202885

Maintenance_bot removed a project: Patch-For-Review.Nov 7 2025, 3:30 AM
gerritbot added a comment.Nov 10 2025, 7:07 PM

Change #1203504 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a3

https://gerrit.wikimedia.org/r/1203504

gerritbot added a project: Patch-For-Review.Nov 10 2025, 7:07 PM
gerritbot added a comment.Nov 10 2025, 7:42 PM

Change #1203504 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a3

https://gerrit.wikimedia.org/r/1203504

Maintenance_bot removed a project: Patch-For-Review.Nov 10 2025, 8:31 PM
cscott moved this task from In Progress to Q3 FY25-26 on the Content-Transform-Team (Work In Progress) board.Nov 17 2025, 4:28 PM
ABreault-WMF mentioned this in T353697: Parsoid/legacy parser {{Pre}} template rendering difference.Dec 11 2025, 12:28 PM
gerritbot added a comment.Dec 12 2025, 10:10 AM

Change #1217714 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Add a regression test for leaking fragment marker

https://gerrit.wikimedia.org/r/1217714

gerritbot added a project: Patch-For-Review.Dec 12 2025, 10:10 AM
ssastry merged a task: T413010: Parsoid error for nowiki-subst.Dec 17 2025, 10:34 PM
ssastry added a subscriber: Nux.
gerritbot added a comment.Jan 6 2026, 2:28 AM

Change #1217714 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add a regression test for leaking fragment marker

https://gerrit.wikimedia.org/r/1217714

Maintenance_bot removed a project: Patch-For-Review.Jan 6 2026, 2:30 AM
gerritbot added a comment.Jan 12 2026, 10:49 AM

Change #1225504 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a11

https://gerrit.wikimedia.org/r/1225504

gerritbot added a project: Patch-For-Review.Jan 12 2026, 10:49 AM
cscott removed cscott as the assignee of this task.Jan 12 2026, 4:33 PM
gerritbot added a comment.Jan 12 2026, 7:37 PM

Change #1225504 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a11

https://gerrit.wikimedia.org/r/1225504

Maintenance_bot removed a project: Patch-For-Review.Jan 12 2026, 8:32 PM
MSantos assigned this task to ABreault-WMF.Mon, Jan 26, 4:34 PM
MSantos moved this task from Q3 FY25-26 to To Verify on the Content-Transform-Team (Work In Progress) board.
ABreault-WMF mentioned this in T415591: Template source used in shadow attribute.Mon, Jan 26, 8:31 PM
ABreault-WMF closed this task as Resolved.Mon, Jan 26, 9:54 PM

A number of these cases were from the template pre hack, which is covered in T353697

@ssastry had mentioned an unresolved case from rt testing, which I've filed as T415591 and isn't the same as fragment markers showing up in the read view, they are showing up in roundtrip information being saved from template expansion source

From the task map,

T398969	Fragment marker in output	fatwiki, tumwiki, awawiki, cbk_zamwiki, cdowiki, avwiki, diqwiki, dzwiki, shnwiki, mnwwiki ... many ...

tumwiki and plwiki cases were fixed by https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1217714

tumwiki cases from this sheet are no longer present

fatwiki cases from this sheet are no longer present

awawiki and cbk_zamwiki case from this sheet are no longer present

cdowiki cases from this sheet are no longer present

avwiki cases from this sheet are no longer present

I think we close this out and re-open or file a more specific task if we encounter any more cases in the wikis yet to be deployed to

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits