Special:BlockedExternalDomains: TransactionProfiler warnings created when adding or removing entries
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Jul 8 2025, 4:29 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Dreamy_Jazz

Description

Summary

AbuseFilter Special:BlockedExternalDomains is not marked as performing writes, so causes TransactionProfiler warnings when a user adds or removes an entry from the list

Background

Example logstash log showing this issue
Special pages need to be marked as performing writes otherwise they are marked as nonwrite-POST for the TransactionProfiler
- Marking the special page as performing writes should fix the TransactionProfiler warnings seen for this special page

Acceptance criteria

TransactionProfiler warnings are no longer created when using Special:BlockedExternalDomains

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Special: Declare that Special:BlockedExternalDomains does writes	Umherirrender	mediawiki/extensions/AbuseFilter	master	+5 -0

Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Jul 8 2025, 4:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2025, 4:29 PM

Dreamy_Jazz updated the task description. (Show Details)Jul 8 2025, 4:29 PM

matej_suchanek moved this task from Backlog to Blocked external domains on the AbuseFilter board.Jan 2 2026, 2:08 PM

Change #1246251 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@master] Special: Override doesWrites() for Special:BlockedExternalDomains

https://gerrit.wikimedia.org/r/1246251

gerritbot added a project: Patch-For-Review.Feb 28 2026, 9:32 PM

Umherirrender claimed this task.Feb 28 2026, 9:32 PM

Change #1246251 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Special: Declare that Special:BlockedExternalDomains does writes

https://gerrit.wikimedia.org/r/1246251

Maintenance_bot removed a project: Patch-For-Review.Mar 1 2026, 10:30 AM

Umherirrender closed this task as Resolved.Mar 1 2026, 10:45 AM

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.18; 2026-03-03).Mar 1 2026, 11:00 AM

Special:BlockedExternalDomains: TransactionProfiler warnings created when adding or removing entriesClosed, ResolvedPublicActions