Page MenuHomePhabricator

Special:Tags: TransactionProfiler warnings created when deleting a tag
Closed, ResolvedPublic

Description

Summary

Special:Tags is not marked as performing writes, so causes TransactionProfiler warnings when a user deletes a tag

Background

  • Example logstash log showing this issue
  • Special pages need to be marked as performing writes otherwise they are marked as nonwrite-POST for the TransactionProfiler
    • Marking the special page as performing writes should fix the TransactionProfiler warnings seen for this special page

Acceptance criteria

  • TransactionProfiler warnings are no longer created when using Special:Tags

Details

Event Timeline

Change #1246252 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Specials: Declare that Special:Tags does writes

https://gerrit.wikimedia.org/r/1246252

Change #1246252 merged by jenkins-bot:

[mediawiki/core@master] Specials: Declare that Special:Tags does writes

https://gerrit.wikimedia.org/r/1246252