Page MenuHomePhabricator

Cleanup Aptly server from deployment-prep
Closed, ResolvedPublic

Description

deployment-deploy04 applies role::aptly::server to host a project-local Apt repository, which I believe was used to host the latest development Scap release a while ago. That's no longer in use, and the role in question hasn't been updated since Debian Stretch and is not used anywhere else. So let's just drop that role entirely?

Details

Related Changes in Gerrit:

Event Timeline

@dancy Is this apt repo dead tech? It seems likely to me, but seemed worth double checking with you.

@dancy Is this apt repo dead tech? It seems likely to me, but seemed worth double checking with you.

It was indeed used to host scap debs in the past but that changed long ago so it's good to remove.

bd808 triaged this task as Medium priority.Jul 9 2025, 3:58 PM
bd808 moved this task from To Triage to Backlog on the Beta-Cluster-Infrastructure board.

https://gerrit.wikimedia.org/r/plugins/gitiles/cloud/instance-puppet/+/6ab1b3fb2863b0d166437a220d4688d0ec0bb898%5E%21/

diff --git a/deployment-prep/deployment-deploy04.deployment-prep.eqiad1.wikimedia.cloud.roles b/deployment-prep/deployment-deploy04.deployment-prep.eqiad1.wikimedia.cloud.roles
index 1ca6d1f..9662652 100644
--- a/deployment-prep/deployment-deploy04.deployment-prep.eqiad1.wikimedia.cloud.roles
+++ b/deployment-prep/deployment-deploy04.deployment-prep.eqiad1.wikimedia.cloud.roles

@@ -1,4 +1,3 @@
 - role::beta::deploymentserver
 - role::deployment_server
-- role::aptly::server
 - profile::ci::slave::labs::common

Mentioned in SAL (#wikimedia-releng) [2025-07-09T16:02:59Z] <bd808> removed role::aptly::server from deployment-deploy04 (T399076)

bd808 changed the task status from Open to In Progress.Jul 9 2025, 4:03 PM
bd808 claimed this task.
bd808@deployment-deploy04:~$ sudo apt purge aptly
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following packages will be REMOVED:
  aptly*
0 upgraded, 0 newly installed, 1 to remove and 0 not upgraded.
After this operation, 18.9 MB disk space will be freed.
Do you want to continue? [Y/n] y
(Reading database ... 55407 files and directories currently installed.)
Removing aptly (1.4.0+ds1-4+b4) ...
Processing triggers for man-db (2.9.4-2) ...
bd808@deployment-deploy04:~$ sudo rm -r /srv/packages
bd808@deployment-deploy04:~$ sudo rm /etc/aptly.conf

I think I got all the important bits cleaned up. Feel free to reopen if you feel like there is something that was missed.

I want to remove the now-unused Puppet role as well.

https://gerrit.wikimedia.org/r/plugins/gitiles/cloud/instance-puppet/+/c6752efd7eb82ec04eb84cc036b6f5574d3fc0f1%5E%21/#F0

diff --git a/deployment-prep/_.yaml b/deployment-prep/_.yaml
index 9d0878f..b5f3398 100644
--- a/deployment-prep/_.yaml
+++ b/deployment-prep/_.yaml

@@ -526,7 +526,6 @@
 restbase::deploy::public_key_file: puppet:///private/ssh/tin/servicedeploy_rsa.pub
 restbase::deploy::scap::public_key_file: puppet:///private/ssh/tin/servicedeploy_rsa.pub
 restbase::deployment: scap
-role::aptly::client::servername: deployment-deploy04.deployment-prep.eqiad1.wikimedia.cloud
 role::cache::text::cluster: cache_text
 role::deployment::repo_config:
   abacist/abacist:
bd808 removed bd808 as the assignee of this task.Jul 9 2025, 4:23 PM

Change #1189395 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] O:aptly::server: Remove unused role

https://gerrit.wikimedia.org/r/1189395

Change #1189395 merged by Majavah:

[operations/puppet@production] O:aptly::server: Remove unused role

https://gerrit.wikimedia.org/r/1189395

taavi claimed this task.