Page MenuHomePhabricator

Make updates to Blue and Yellow to support diff updates
Closed, ResolvedPublic

Description

Background

As a part of T394117: [EPIC] Diff styling we need to make an update to the Blue and Yellow values in Codex in order to meet our goal to maintain the same exact colors currently used in the yellow/blue diff styles.

Goals

  • Use the exact same colors currently used in diff styling
  • Maintain proper accessibility/color contrast needed wherever these option colors might be used.

Changes and effects (outside of diffs)

colorbeforeaftereffects
yellow100#fbe2a2#ffe49cnone
yellow200#fecc44#ffcf4fnone
yellow300#eeb533#edb537none
blue100#dce3f9#d9e2ffbackground-color-progressive-subtle--hover in light mode
blue200#cbd6f6#b6d4fbbackground-color-progressive-subtle--active in light mode, color-progressive--active in dark mode, box-shadow-color-progressive-selected--active in dark mode
blue300#b0c1f0#a6bbf5color-progressive--hover in dark mode, border-color-progressive--active in dark mode, box-shadow-color-progressive-selected--hover in dark mode

Acceptance criteria

  • Effected colors are updated in Codex
  • Colors are also updated in Figma

Event Timeline

DTorsani-WMF moved this task from Backlog to Ready for Design/Dev on the Codex board.

Change #1173458 had a related patch set uploaded (by Dtorsani; author: Dtorsani):

[design/codex@main] tokens: Update Yellow and Blue option tokens

https://gerrit.wikimedia.org/r/1173458

Change #1173458 merged by jenkins-bot:

[design/codex@main] tokens: Update Yellow and Blue option tokens

https://gerrit.wikimedia.org/r/1173458

@DTorsani-WMF curious if the plan is to stick with blue and yellow or update to red and green as is suggested on the MediaWiki Site: https://phabricator.wikimedia.org/T399101 Thanks! Sorry for my confusion

Or is the goal for Android to default to Deuteranopia & Protanopia until the diff color themes are introduced?

This task is/was (since the patch has been merged) solely for Codex. It will update a few values of our yellow and blue palettes. The goal of the diffs updates, particularly for Apps will be to source the same color values from Codex used in the tokens listed in T394327: Update color tokens for diff styling in Codex for diffs across the four different color themes, and to replicate the nature of the tokens referenced in that task in the Apps. That will be true for light and dark mode. The updates to the colors should come, ideally, at the same time as the color theme switcher. As noted in T400754: Implement color updates to diffs on Android and T400752: Implement color updates to diffs on iOS, the default theme on Apps would Trichromatic, or red and green. This is also the Codex default, and means the Apps remains using red and green, since they already do. This does however differ from the default on Web, which will be Deuteranopia & Protanopia, or yellow and blue, since the current colors in the Wikitext view are yellow and blue. We can also reconsider the default theme on Apps if you think that is important.

Does this help at all? I'm happy to chat more about this. I know it's a lot and can be a confusing web of things.

This is helpful and I understand now, thanks @DTorsani-WMF !

Change #1178961 had a related patch set uploaded (by LorenMora; author: LorenMora):

[mediawiki/core@master] Update Codex from v2.2.1 to v2.3.0

https://gerrit.wikimedia.org/r/1178961

Test wiki created on Patch demo by LMora-WMF using patch(es) linked to this task:
https://52ad408a3b.catalyst.wmcloud.org/w/

Change #1178961 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v2.2.1 to v2.3.0

https://gerrit.wikimedia.org/r/1178961

Change #1180982 had a related patch set uploaded (by LorenMora; author: LorenMora):

[mediawiki/core@master] Update Codex from v2.2.1 to v2.3.1

https://gerrit.wikimedia.org/r/1180982

Test wiki created on Patch demo by LMora-WMF using patch(es) linked to this task:
https://590db65713.catalyst.wmcloud.org/w/

Change #1180982 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v2.2.1 to v2.3.1

https://gerrit.wikimedia.org/r/1180982

Test wiki on Patch demo by LMora-WMF using patch(es) linked to this task was deleted:

https://590db65713.catalyst.wmcloud.org/w/

Test wiki on Patch demo by LMora-WMF using patch(es) linked to this task was deleted:

https://52ad408a3b.catalyst.wmcloud.org/w/