Page MenuHomePhabricator

Regression: Cirrus exact string regexp search for insource:/"u.a."/ has stopped working
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • "There were no results matching the query." is displayed

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

1.45.0-wmf.9 - WMF wikis as of 2025-07-10. Seems to have started in the last couple of days.

Other information (browser name/version, screenshots, etc.):

After further testing it seems that the exact string regex search works if the search term does not contain dots, e.g. searching for insource:/"thumb|"/ works fine. Also normal regex searches, e.g.
for insource:/u\.a\./ work fine.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
EBernhardson subscribed.

This is most likely related to the plugin deployment for T317599.

There are two things going on here, the first is that quotes in the regexp here have special meaning. They don't match the quote, rather they define a part of the string that has to be a literal match. So the search query insource:/"u.a."/ searches for the literal string u.a., it does not search for the quotation characters and it does not treat the . as a match-all. The second part is that the recent changes to the regex engine didn't take this into account, and is rewriting the . into a semantically equivalent form.

Change #1167921 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[wmf-jvm-utils@master] regex: Support quoted literals

https://gerrit.wikimedia.org/r/1167921

Change #1167921 merged by jenkins-bot:

[wmf-jvm-utils@master] regex: Support quoted literals

https://gerrit.wikimedia.org/r/1167921

Change #1169151 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[search/highlighter@master] Bump lucene-regex-rewriter to 1.0.5

https://gerrit.wikimedia.org/r/1169151

Change #1169154 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[search/extra@master] Bump lucene-regex-rewriter to 1.0.5

https://gerrit.wikimedia.org/r/1169154

Change #1169151 merged by jenkins-bot:

[search/highlighter@master] Bump lucene-regex-rewriter to 1.0.5

https://gerrit.wikimedia.org/r/1169151

Change #1169154 merged by jenkins-bot:

[search/extra@master] Bump lucene-regex-rewriter to 1.0.5

https://gerrit.wikimedia.org/r/1169154

Change #1169694 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[operations/software/opensearch/plugins@master] Update plugins for bugfix to extended regex support

https://gerrit.wikimedia.org/r/1169694

Change #1169694 abandoned by Ebernhardson:

[operations/software/opensearch/plugins@master] Update plugins for bugfix to extended regex support

Reason:

moved to gitlab

https://gerrit.wikimedia.org/r/1169694

Mentioned in SAL (#wikimedia-operations) [2025-07-21T17:13:27Z] <bking@cumin1002> START - Cookbook sre.elasticsearch.rolling-operation Operation.RESTART (1 nodes at a time) for ElasticSearch cluster cloudelastic: T399162 - bking@cumin1002

Mentioned in SAL (#wikimedia-operations) [2025-07-21T17:42:51Z] <bking@cumin1002> END (PASS) - Cookbook sre.elasticsearch.rolling-operation (exit_code=0) Operation.RESTART (1 nodes at a time) for ElasticSearch cluster cloudelastic: T399162 - bking@cumin1002

Mentioned in SAL (#wikimedia-operations) [2025-07-21T17:53:26Z] <bking@cumin1002> START - Cookbook sre.elasticsearch.rolling-operation Operation.RESTART (3 nodes at a time) for ElasticSearch cluster search_codfw: T399162 - bking@cumin1002

Mentioned in SAL (#wikimedia-operations) [2025-07-21T18:17:30Z] <bking@cumin1002> END (FAIL) - Cookbook sre.elasticsearch.rolling-operation (exit_code=99) Operation.RESTART (3 nodes at a time) for ElasticSearch cluster search_codfw: T399162 - bking@cumin1002

Mentioned in SAL (#wikimedia-operations) [2025-07-21T18:22:39Z] <bking@cumin1002> START - Cookbook sre.elasticsearch.rolling-operation Operation.RESTART (3 nodes at a time) for ElasticSearch cluster search_codfw: T399162 - bking@cumin1002

Mentioned in SAL (#wikimedia-operations) [2025-07-21T18:24:31Z] <bking@cumin1002> END (FAIL) - Cookbook sre.elasticsearch.rolling-operation (exit_code=99) Operation.RESTART (3 nodes at a time) for ElasticSearch cluster search_codfw: T399162 - bking@cumin1002

Mentioned in SAL (#wikimedia-operations) [2025-07-21T18:25:12Z] <bking@cumin1002> START - Cookbook sre.elasticsearch.rolling-operation Operation.RESTART (3 nodes at a time) for ElasticSearch cluster search_codfw: T399162 - bking@cumin1002

Mentioned in SAL (#wikimedia-operations) [2025-07-21T18:27:05Z] <bking@cumin1002> END (FAIL) - Cookbook sre.elasticsearch.rolling-operation (exit_code=99) Operation.RESTART (3 nodes at a time) for ElasticSearch cluster search_codfw: T399162 - bking@cumin1002

Change #1171258 had a related patch set uploaded (by Bking; author: Bking):

[operations/puppet@production] cirrussearch: add missing nodes to CODFW pool

https://gerrit.wikimedia.org/r/1171258

Change #1171258 merged by Bking:

[operations/puppet@production] cirrussearch: add missing nodes to CODFW pool

https://gerrit.wikimedia.org/r/1171258

Mentioned in SAL (#wikimedia-operations) [2025-07-23T18:52:36Z] <inflatador> depool eqiad in preparation for rolling restart T399162

This looks to be resolved. All nodes report using opensearch-extra plugin 1.3.20-wmf5 which includes the fix. Example query in the ticket description looks to work as expected.