Page MenuHomePhabricator

watchlist period of time to display value should match current value on load
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Go to Special:Watchlist
  • Change some of the display filters, but do not touch the "period of time to display" value
  • Click Show

What happens?:

  • The new filters are applied, including the new "period of time to display"
  • Be shocked that the period of time to display also changed, even though I didn't ask for a new value here

What should have happened instead?:

  • The "current settings" should be the initially loaded settings for the filter controls on page load

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
WMF production

Other information (browser name/version, screenshots, etc.):

image.png (172×527 px, 18 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Select "Use non-JavaScript interface" at https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-watchlist before viewing https://en.wikipedia.org/wiki/Special:Watchlist to replicate the bug. The "Period of time to display" box defaults to 1 hour, both on initial page load and after changing it and clicking "Show". T199566 is an old resolved bug about forgetting the selection but it has regressed. WikiDan61 says at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Watchlist_bug? that before today the box said 3 days on intitial page load when 3 is selected at "Days to show in watchlist" at https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-watchlist.

The watchlist does display edits for 3 days on page load if that's your preference, and if you click "Show" then it does display edits for the selection in "Period of time to display". The bug is that you always have to change "1 hour" before clicking "Show". If you check/uncheck boxes then it's remembered but not the time.

Change #1167930 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] xml: Adjust documentation for default on XmlSelect::__construct

https://gerrit.wikimedia.org/r/1167930

Change #1167930 merged by jenkins-bot:

[mediawiki/core@master] xml: Adjust documentation for default on XmlSelect::__construct

https://gerrit.wikimedia.org/r/1167930