Page MenuHomePhabricator
Create Task
Maniphest T399195

Update logging and monitoring for multiple session storage backends
Closed, ResolvedPublic
Actions

Description

Currently we have session logging in two places:

  • Logging session writes to the session-sampled Logstash channel in SessionManager and SessionBackend
  • Sending Prometheus metrics in BagOStuff

That might be fine as is, but we should consider if we want to change something there after T399192: Create new session store abstraction to replace BagOStuff in SessionManager / T399194: Implement different backends for anonymous and authenticated sessions.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
tests: Expand tests for MultiBackendSessionStoremediawiki/coremaster+82 -0
session: Improve logging and monitoring in SessionStore implementationsmediawiki/corewmf/1.45.0-wmf.20+97 -38
session: Improve logging and monitoring in SessionStore implementationsmediawiki/corewmf/1.45.0-wmf.19+97 -38
session: Improve logging and monitoring in SessionStore implementationsmediawiki/coremaster+97 -38
session: Follow-up on I10101c8b928a12 (3fde556f95b4b1ce43)mediawiki/coremaster+683 -52
session: Segregate anonymous sessions from authenticated sessions (p2)mediawiki/coremaster+361 -32
Customize query in gerrit

Related Objects
Search...

Event Timeline

JTweed-WMF created this task.Jul 10 2025, 1:36 PM
JTweed-WMF moved this task from Inbox to WE5.1.1 on the FY2025-26 KR 5.1 board.Jul 10 2025, 1:42 PM
Tgr mentioned this in T399193: Investigate anonymous to authenticated session transitions.Jul 10 2025, 9:10 PM
Tgr added projects: MediaWiki-Core-AuthManager, observability.Jul 10 2025, 9:14 PM
Tgr updated the task description. (Show Details)
JTweed-WMF moved this task from Inbox, needs triage to Needs refinement on the MediaWiki-Platform-Team board.Jul 14 2025, 1:29 PM
• lmata moved this task from Inbox to Radar on the observability board.Jul 16 2025, 2:05 PM
JTweed-WMF removed projects: Epic, FY2025-26 KR 5.1.Jul 24 2025, 2:38 PM
JTweed-WMF edited parent tasks, added: T400365: Support multiple session stores; removed: T398814: WE5.1.1 Session storage protection.
gerritbot added a comment.Aug 25 2025, 8:09 AM

Change #1178870 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] session: Segregate anonymous sessions from authenticated sessions (p2)

https://gerrit.wikimedia.org/r/1178870

gerritbot added a project: Patch-For-Review.Aug 25 2025, 8:09 AM
Tgr mentioned this in T402808: Deploy separate anonymous session backend to Wikimedia production, in log-only mode.Aug 25 2025, 1:57 PM
DAlangi_WMF claimed this task.Aug 25 2025, 2:15 PM
DAlangi_WMF moved this task from Needs refinement to In progress (DO NOT USE) on the MediaWiki-Platform-Team board.
gerritbot added a comment.Sep 11 2025, 6:49 PM

Change #1178870 merged by jenkins-bot:

[mediawiki/core@master] session: Segregate anonymous sessions from authenticated sessions (p2)

https://gerrit.wikimedia.org/r/1178870

Maintenance_bot removed a project: Patch-For-Review.Sep 11 2025, 7:31 PM
gerritbot added a comment.Sep 12 2025, 11:24 AM

Change #1187513 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] session: Follow-up for I10101c8b928a12 (3fde556f95b4b1ce43)

https://gerrit.wikimedia.org/r/1187513

gerritbot added a project: Patch-For-Review.Sep 12 2025, 11:24 AM
DAlangi_WMF mentioned this in T399194: Implement different backends for anonymous and authenticated sessions.Sep 15 2025, 3:17 PM
gerritbot added a comment.Sep 15 2025, 8:14 PM

Change #1187513 merged by jenkins-bot:

[mediawiki/core@master] session: Follow-up on I10101c8b928a12 (3fde556f95b4b1ce43)

https://gerrit.wikimedia.org/r/1187513

Maintenance_bot removed a project: Patch-For-Review.Sep 15 2025, 8:31 PM
gerritbot added a comment.Sep 16 2025, 9:34 AM

Change #1188733 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] session: Improve logging and monitoring in SessionStore implementations

https://gerrit.wikimedia.org/r/1188733

gerritbot added a project: Patch-For-Review.Sep 16 2025, 9:34 AM
gerritbot added a comment.Sep 25 2025, 1:10 AM

Change #1188733 merged by jenkins-bot:

[mediawiki/core@master] session: Improve logging and monitoring in SessionStore implementations

https://gerrit.wikimedia.org/r/1188733

Maintenance_bot removed a project: Patch-For-Review.Sep 25 2025, 1:32 AM
gerritbot added a comment.Sep 25 2025, 11:58 AM

Change #1191351 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@wmf/1.45.0-wmf.20] session: Improve logging and monitoring in SessionStore implementations

https://gerrit.wikimedia.org/r/1191351

gerritbot added a project: Patch-For-Review.Sep 25 2025, 11:58 AM
gerritbot added a comment.Sep 25 2025, 12:14 PM

Change #1191360 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@wmf/1.45.0-wmf.19] session: Improve logging and monitoring in SessionStore implementations

https://gerrit.wikimedia.org/r/1191360

gerritbot added a comment.Sep 25 2025, 1:16 PM

Change #1191360 merged by jenkins-bot:

[mediawiki/core@wmf/1.45.0-wmf.19] session: Improve logging and monitoring in SessionStore implementations

https://gerrit.wikimedia.org/r/1191360

gerritbot added a comment.Sep 25 2025, 1:16 PM

Change #1191351 merged by jenkins-bot:

[mediawiki/core@wmf/1.45.0-wmf.20] session: Improve logging and monitoring in SessionStore implementations

https://gerrit.wikimedia.org/r/1191351

Stashbot added a comment.Sep 25 2025, 1:27 PM

Mentioned in SAL (#wikimedia-operations) [2025-09-25T13:27:03Z] <tgr@deploy1003> Started scap sync-world: Backport for [[gerrit:1191359|objectcache: Add a hit/miss flag to CachedBagOStuff]], [[gerrit:1191360|session: Improve logging and monitoring in SessionStore implementations (T399195 T402808)]], [[gerrit:1191361|hCaptcha: Fix mock for StatsFactory]], [[gerrit:1191362|NewcomerTasks: Use StatsFactory unit test helper]], [[gerrit:1191350|objectcache: Add a hit/miss flag to CachedB

Maintenance_bot removed a project: Patch-For-Review.Sep 25 2025, 1:32 PM
Stashbot added a comment.Sep 25 2025, 1:33 PM

Mentioned in SAL (#wikimedia-operations) [2025-09-25T13:33:33Z] <tgr@deploy1003> d3r1ck01, wmde-fisch, tgr: Backport for [[gerrit:1191359|objectcache: Add a hit/miss flag to CachedBagOStuff]], [[gerrit:1191360|session: Improve logging and monitoring in SessionStore implementations (T399195 T402808)]], [[gerrit:1191361|hCaptcha: Fix mock for StatsFactory]], [[gerrit:1191362|NewcomerTasks: Use StatsFactory unit test helper]], [[gerrit:1191350|objectcache: Add a hit/miss flag to Cache

Stashbot added a comment.Sep 25 2025, 1:43 PM

Mentioned in SAL (#wikimedia-operations) [2025-09-25T13:43:12Z] <tgr@deploy1003> Finished scap sync-world: Backport for [[gerrit:1191359|objectcache: Add a hit/miss flag to CachedBagOStuff]], [[gerrit:1191360|session: Improve logging and monitoring in SessionStore implementations (T399195 T402808)]], [[gerrit:1191361|hCaptcha: Fix mock for StatsFactory]], [[gerrit:1191362|NewcomerTasks: Use StatsFactory unit test helper]], [[gerrit:1191350|objectcache: Add a hit/miss flag to Cached

DAlangi_WMF closed this task as Resolved.Sep 26 2025, 10:51 AM

Created: https://grafana-rw.wikimedia.org/d/fd0c8c5e-3b26-4a90-bca2-a2504de1badc/mediawiki-and-centralauth-sessions to track the metrics as we roll out.

DAlangi_WMF mentioned this in T405824: Develop Grafana dashboard for MediaWiki session store sessions.Sep 27 2025, 8:11 AM
gerritbot added a comment.Sep 29 2025, 8:04 AM

Change #1192051 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] tests: Expand tests for MultiBackendSessionStore

https://gerrit.wikimedia.org/r/1192051

gerritbot added a project: Patch-For-Review.Sep 29 2025, 8:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits