Missing bash completion for `become`
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	LucasWerkmeister
	Jul 10 2025, 7:56 PM

Description

Steps to replicate the issue (include links if applicable):

Be a member of at least one Toolforge tool
SSH into a bastion (specifically, I used login.toolforge.org aka tools-bastion-13)
In a Bash shell, enter become
Press Tab twice

What happens?:

File names in the current directory are autocompleted.

What should have happened instead?:

Tool names should have been autocompleted.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
toolforge-misctools-cli 1.49.2

Other information (browser name/version, screenshots, etc.):
I’m pretty sure this was still working on Monday (2025-07-07), when I deployed l10n updates to several tools.

Details

Related Changes in GitLab:

	Title	Reference	Author	Source Branch	Dest Branch
	d/changelog: bump to 1.49.3	repos/cloud/toolforge/misctools-cli!6	dcaro	bump_misctools-cli	main
	package: add toolforge- prefix to more files	repos/cloud/toolforge/misctools-cli!5	lucaswerkmeister	T399238	main

Customize query in GitLab

Event Timeline

LucasWerkmeister created this task.Jul 10 2025, 7:56 PM

Restricted Application added a project: cloud-services-team. · View Herald TranscriptJul 10 2025, 7:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

CCing @dcaro based on the latest commits in that package (and because Taavi, the other person in that git log, is out for a week and a half).

I wonder if https://gitlab.wikimedia.org/repos/cloud/toolforge/misctools-cli/-/commit/0e495dbffcfe7c14cc9b92b6a5cf937dbf795e0a needed to update more debian/* files when renaming the package?

Maybe… I don’t know how bash-completion files are installed in Debian packages, but they vanished from the installed files in 1.49.2:

lucaswerkmeister@tools-bastion-13:~$ dpkg-deb -c /var/cache/apt/archives/misctools_1.49.1_amd64.deb
drwxr-xr-x root/root         0 2025-07-09 08:03 ./
drwxr-xr-x root/root         0 2025-07-09 08:03 ./usr/
drwxr-xr-x root/root         0 2025-07-09 08:03 ./usr/bin/
-rwxr-xr-x root/root      1924 2025-07-09 08:03 ./usr/bin/become
-rwxr-xr-x root/root      4240 2025-07-09 08:03 ./usr/bin/sql
-rwsr-xr-x root/root     14688 2025-07-09 08:03 ./usr/bin/take
drwxr-xr-x root/root         0 2025-07-09 08:03 ./usr/share/
drwxr-xr-x root/root         0 2025-07-09 08:03 ./usr/share/bash-completion/
drwxr-xr-x root/root         0 2025-07-09 08:03 ./usr/share/bash-completion/completions/
-rw-r--r-- root/root       381 2025-07-09 08:03 ./usr/share/bash-completion/completions/become
-rw-r--r-- root/root      1327 2025-07-09 08:03 ./usr/share/bash-completion/completions/sql
drwxr-xr-x root/root         0 2025-07-09 08:03 ./usr/share/doc/
drwxr-xr-x root/root         0 2025-07-09 08:03 ./usr/share/doc/misctools/
-rw-r--r-- root/root      4479 2025-07-09 08:03 ./usr/share/doc/misctools/changelog.gz
-rw-r--r-- root/root      1780 2025-07-09 08:03 ./usr/share/doc/misctools/copyright
drwxr-xr-x root/root         0 2025-07-09 08:03 ./usr/share/lintian/
drwxr-xr-x root/root         0 2025-07-09 08:03 ./usr/share/lintian/overrides/
-rw-r--r-- root/root        53 2025-07-09 08:03 ./usr/share/lintian/overrides/misctools
drwxr-xr-x root/root         0 2025-07-09 08:03 ./usr/share/man/
drwxr-xr-x root/root         0 2025-07-09 08:03 ./usr/share/man/man1/
-rw-r--r-- root/root       355 2025-07-09 08:03 ./usr/share/man/man1/become.1.gz
-rw-r--r-- root/root       560 2025-07-09 08:03 ./usr/share/man/man1/sql.1.gz
-rw-r--r-- root/root       358 2025-07-09 08:03 ./usr/share/man/man1/take.1.gz
lucaswerkmeister@tools-bastion-13:~$ dpkg-deb -c /var/cache/apt/archives/toolforge-misctools-cli_1.49.2_amd64.deb 
drwxr-xr-x root/root         0 2025-07-09 13:53 ./
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/bin/
-rwxr-xr-x root/root      1924 2025-07-09 13:53 ./usr/bin/become
-rwxr-xr-x root/root      4240 2025-07-09 13:53 ./usr/bin/sql
-rwsr-xr-x root/root     14688 2025-07-09 13:53 ./usr/bin/take
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/share/
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/share/doc/
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/share/doc/toolforge-misctools-cli/
-rw-r--r-- root/root      4523 2025-07-09 13:53 ./usr/share/doc/toolforge-misctools-cli/changelog.gz
-rw-r--r-- root/root      1780 2025-07-09 13:53 ./usr/share/doc/toolforge-misctools-cli/copyright
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/share/man/
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/share/man/man1/
-rw-r--r-- root/root       355 2025-07-09 13:53 ./usr/share/man/man1/become.1.gz
-rw-r--r-- root/root       561 2025-07-09 13:53 ./usr/share/man/man1/sql.1.gz
-rw-r--r-- root/root       356 2025-07-09 13:53 ./usr/share/man/man1/take.1.gz

(It looks like /usr/share/lintian/overrides/misctools also went away – I don’t know what that is.)

My theory would be that debian/misctools.bash-completion and debian/misctools.lintian-overrides need to be renamed to debian/toolforge-misctools-cli.bash-completion and debian/toolforge-misctools-cli.lintian-overrides so that they match the name of the package being built.

lucaswerkmeister opened https://gitlab.wikimedia.org/repos/cloud/toolforge/misctools-cli/-/merge_requests/5

package: add toolforge- prefix to more files

In T399238#10993703, @bd808 wrote:

My theory would be that debian/misctools.bash-completion and debian/misctools.lintian-overrides need to be renamed to debian/toolforge-misctools-cli.bash-completion and debian/toolforge-misctools-cli.lintian-overrides so that they match the name of the package being built.

After bashing my head against a wall for a bit, I was able to test this fix using sbuild and it seems to work, hence the above PR. I credited you as the commit author but signed-off as myself, idk if that makes sense or not.

lucas@lucaswerkmeister /var/tmp/misctools-cli (main +|u=) $ dpkg-deb -c ../toolforge-misctools-cli_1.49.2_amd64.deb 
drwxr-xr-x root/root         0 2025-07-09 13:53 ./
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/bin/
-rwxr-xr-x root/root      1924 2025-07-09 13:53 ./usr/bin/become
-rwxr-xr-x root/root      4240 2025-07-09 13:53 ./usr/bin/sql
-rwsr-xr-x root/root     14744 2025-07-09 13:53 ./usr/bin/take
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/share/
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/share/bash-completion/
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/share/bash-completion/completions/
-rw-r--r-- root/root       381 2025-07-09 13:53 ./usr/share/bash-completion/completions/become
-rw-r--r-- root/root      1327 2025-07-09 13:53 ./usr/share/bash-completion/completions/sql
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/share/doc/
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/share/doc/toolforge-misctools-cli/
-rw-r--r-- root/root      1682 2025-07-09 13:53 ./usr/share/doc/toolforge-misctools-cli/changelog.gz
-rw-r--r-- root/root      1780 2025-07-09 13:53 ./usr/share/doc/toolforge-misctools-cli/copyright
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/share/lintian/
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/share/lintian/overrides/
-rw-r--r-- root/root        53 2025-07-09 13:53 ./usr/share/lintian/overrides/toolforge-misctools-cli
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/share/man/
drwxr-xr-x root/root         0 2025-07-09 13:53 ./usr/share/man/man1/
-rw-r--r-- root/root       355 2025-07-09 13:53 ./usr/share/man/man1/become.1.gz
-rw-r--r-- root/root       561 2025-07-09 13:53 ./usr/share/man/man1/sql.1.gz
-rw-r--r-- root/root       356 2025-07-09 13:53 ./usr/share/man/man1/take.1.gz

dcaro merged https://gitlab.wikimedia.org/repos/cloud/toolforge/misctools-cli/-/merge_requests/5

package: add toolforge- prefix to more files

dcaro opened https://gitlab.wikimedia.org/repos/cloud/toolforge/misctools-cli/-/merge_requests/6

d/changelog: bump to 1.49.3

dcaro merged https://gitlab.wikimedia.org/repos/cloud/toolforge/misctools-cli/-/merge_requests/6

d/changelog: bump to 1.49.3