Page MenuHomePhabricator

Confusing href="#" links in the wikitext editor help panel
Closed, ResolvedPublic

Description

In T386360: Add a section about sub-refs with `details` to WT2010 toolbar help we added another entry to the help panel. This entry also contains fake links. Clicking these make the browser window jump back to the top.

Expected behavior: These fake links should not do anything. This applies to both the new help entries but also to all the old ones.

Outcome:

image.png (219×1 px, 43 KB)

Event Timeline

Change #1187253 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Remove meaningless href="#" from help panel examples

https://gerrit.wikimedia.org/r/1187253

Change #1187253 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove meaningless href="#" from help panel examples

https://gerrit.wikimedia.org/r/1187253

Change #1195983 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Fix wrong comma in [2,1] in wikitext help panel

https://gerrit.wikimedia.org/r/1195983

Change #1195986 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Fix/simplify preview code in wikitext editor help panel

https://gerrit.wikimedia.org/r/1195986

Change #1196627 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Much simpler/real-world examples in wikitext help panel

https://gerrit.wikimedia.org/r/1196627