Remove reliance on EXECUTOR_NUMBER environment variable in CI
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Jul 11 2025, 9:34 AM

Description

In 2015 we introduced usage of EXECUTOR_NUMBER to namespace the temporary directory between builds (Gerrit 198197. As the workload got moved to container, that is no more needed.

We still have some occurrences in code search:

integration/config

dockerfiles/tox-mysqld/example-run.sh

# XXX note wikimedia/fundraising/tools test suite expects the Jenkins env
# variable EXECUTOR_NUMBER to be set.
docker run \
    --rm --tty \
    --env EXECUTOR_NUMBER=1 \

jjb/beta.yaml

# Job to run MediaWiki update.php script on all the beta wikis.
#
# Set TMPDIR to point to the tmpfs if it exists.
- job:
    name: beta-update-databases-eqiad
    defaults: beta
    node: BetaClusterBastion
    builders:
      - shell: |
          # Setup tmpfs directory
          export TMPDIR_FS="/srv/home/jenkins-deploy/tmpfs/jenkins-${EXECUTOR_NUMBER}"
          if [ -d "/srv/home/jenkins-deploy/tmpfs" ]; then
            mkdir -p "$TMPDIR_FS"
            chmod 777 "$TMPDIR_FS"
            export TMPDIR="$TMPDIR_FS"
          fi
          # Teardown tmpfs directory
          function global_teardown() {
              rm -rf "$TMPDIR_FS"
          }
          trap global_teardown EXIT
          /usr/local/bin/wmf-beta-update-databases.py

integration/quibble

quibble/cmd.py

"""
Set and get needed environment variables.
TODO: Can we deprecate any of these in favor of explicit
parameters?
"""
if 'EXECUTOR_NUMBER' not in os.environ:
    os.environ['EXECUTOR_NUMBER'] = '1'

That one in Quibble came from the early days of Quibble and probably came from the 2015 script.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Stop setting EXECUTOR_NUMBER environment variable	integration/quibble	master	+0 -3
jjb: beta: remove obsolete tmp dir setup	integration/config	master	+0 -13
dockerfiles: remove EXECUTOR_NUMBER from tox example	integration/config	master	+1 -4
Replace EXECUTOR_NUMBER env var by CI	wikimedia/fundraising/tools	master	+3 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	hashar	T399283 Remove reliance on EXECUTOR_NUMBER environment variable in CI
Duplicate	None	T399303 Beta cluster down 2025-07-11
Resolved	fnegri	T399261 Widespread instances down in project deployment-prep
Duplicate	None	T399297 Widespread instances down in project deployment-prep

Event Timeline

hashar created this task.Jul 11 2025, 9:34 AM

wikimedia/fundraising/tools has:

silverpop_export/tests/test_update.py

def setup():
    global conn
    global db_name
    # FIXME: parameterize test configuration better
    db_pass = None
    if 'EXECUTOR_NUMBER' in os.environ:
        # We're running under Jenkins.  Assume things.
        db_name = "test"
        db_user = "root"
        db_host = "127.0.0.1"
    else:
        db_name = "test"
        db_user = "test"
        db_host = "database"