Rust-based evaluator implements a timeout
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmassaro
	Jul 11 2025, 10:33 PM

Description

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

there is a timeout, configurable with environment variables in the Helm chart

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	wikifunctions: Upgrade evaluators from 2025-09-24-083919 to 2025-09-30-194529	operations/deployment-charts	master	+2 -2

Customize query in gerrit

Related Changes in GitLab:

	Title	Reference	Author	Source Branch	Dest Branch
	implement timeout in Rust	repos/abstract-wiki/wikifunctions/function-evaluator!402	ecarg	grace/T399345/rust-implement-timeout	main

Customize query in GitLab

Related Objects
Search...

Status	Assigned	Task
Open	Jdforrester-WMF	T402957 [26Q2] Rust evaluator in production
Open	None	T382433 Get the Rust prototype of the function-evaluator's executors into a state where it could be deployed
In Progress	cmassaro	T343720 If we create a working evaluator service in Rust, we can measure its performance and stability characteristics and plan to productionize it in a subsequent quarter
Resolved	cmassaro	T399344 Rust-based evaluator is at feature parity with the current Node-based one
Resolved	ecarg	T399345 Rust-based evaluator implements a timeout
Resolved	cmassaro	T399321 Rust-based evaluator service can run a function call in the appropriate executor and return a result
Resolved	cmassaro	T400820 Use dedicated abstract-wikipeda-rust image in test-rust (and, eventually, other Rust images)
Resolved	ecarg	T407590 Check that timeout is working properly

Event Timeline

cmassaro created this task.Jul 11 2025, 10:33 PM

cmassaro added a parent task: T399344: Rust-based evaluator is at feature parity with the current Node-based one.

cmassaro added a subtask: T399321: Rust-based evaluator service can run a function call in the appropriate executor and return a result.Jul 11 2025, 10:37 PM

DSantamaria triaged this task as Medium priority.Jul 16 2025, 2:04 PM

DSantamaria edited projects, added Abstract Wikipedia team (26Q1 (Jul–Sep)), Essential-Work; removed Abstract Wikipedia team.

DSantamaria moved this task from Incoming to Ready on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.

cmassaro changed the status of subtask T399321: Rust-based evaluator service can run a function call in the appropriate executor and return a result from Open to In Progress.Aug 26 2025, 10:11 PM

@cmassaro I'm looking at tokio::timeout what do you think?

cmassaro closed subtask T399321: Rust-based evaluator service can run a function call in the appropriate executor and return a result as Resolved.Aug 27 2025, 3:48 PM

tokio::timeout looks very good to me!

Reflecting reality.

Bah.

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/402

Draft: implement timeout in Rust

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/402

implement timeout in Rust

Maintenance_bot removed a project: Patch-For-Review.Sep 25 2025, 4:32 PM

Leaving in Engineering for test coverage.

To confirm @ecarg, are we holding this task open for the test?

@Jdforrester-WMF I was going to make a followup task, if you think I just do it under this phab task I'm ok with that too

Change #1192973 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2025-09-24-083919 to 2025-09-30-194529

https://gerrit.wikimedia.org/r/1192973

gerritbot added a project: Patch-For-Review.Oct 1 2025, 8:49 PM

In T399345#11231937, @ecarg wrote:

@Jdforrester-WMF I was going to make a followup task, if you think I just do it under this phab task I'm ok with that too

Let's track it in T406181.

Jdforrester-WMF moved this task from In Engineering to Needs Sign-off on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.Oct 1 2025, 8:50 PM

Change #1192973 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2025-09-24-083919 to 2025-09-30-194529

https://gerrit.wikimedia.org/r/1192973

Maintenance_bot removed a project: Patch-For-Review.Oct 1 2025, 9:32 PM

Jdforrester-WMF closed this task as Resolved.Oct 2 2025, 4:27 PM

cmassaro mentioned this in rMSFE1bfc66e241ae: implement timeout in Rust.Oct 3 2025, 9:45 AM

Jdforrester-WMF changed the status of subtask T407590: Check that timeout is working properly from Open to In Progress.Tue, Oct 21, 2:41 PM

ecarg closed subtask T407590: Check that timeout is working properly as Resolved.Tue, Nov 18, 5:49 AM