Maniphest T399346

Rust-based evaluator implements rate limiting
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmassaro
	Jul 11 2025, 10:34 PM

Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

Description

Description

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

Rust evaluator rejects concurrent requests with the same request ID after a certain threshold is reached

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	wikifunctions: Upgrade evaluators from 2025-09-24-083919 to 2025-09-30-194529	operations/deployment-charts	master	+2 -2

Customize query in gerrit

Related Changes in GitLab:

	Title	Reference	Author	Source Branch	Dest Branch
	add rate-limiting to rustversion	repos/abstract-wiki/wikifunctions/function-evaluator!409	ecarg	grace/T399346/rust-rate-limit	main

Customize query in GitLab

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T421849 [Hypothesis] WE2.3.16 Productionize Rust Evaluator and Deprecate Node Evaluator
		Resolved		Jdforrester-WMF	T382433 Get the Rust prototype of the function-evaluator's executors into a state where it could be deployed
		Resolved		Jdforrester-WMF	T343720 If we create a working evaluator service in Rust, we can measure its performance and stability characteristics and plan to productionize it in a subsequent quarter
		Resolved		cmassaro	T399344 Rust-based evaluator is at feature parity with the current Node-based one
		Resolved		ecarg	T399346 Rust-based evaluator implements rate limiting
		Resolved		cmassaro	T399321 Rust-based evaluator service can run a function call in the appropriate executor and return a result
		Resolved		cmassaro	T400820 Use dedicated abstract-wikipeda-rust image in test-rust (and, eventually, other Rust images)
		Resolved		Jdforrester-WMF	T407588 Create a fail-fast for rate-limiting

Event Timeline

cmassaro created this task.Jul 11 2025, 10:34 PM

cmassaro added a parent task: T399344: Rust-based evaluator is at feature parity with the current Node-based one.

cmassaro added a subtask: T399321: Rust-based evaluator service can run a function call in the appropriate executor and return a result.Jul 11 2025, 10:38 PM

DSantamaria triaged this task as Medium priority.Jul 16 2025, 2:04 PM

DSantamaria edited projects, added Abstract Wikipedia team (26Q1 (Jul–Sep)), Essential-Work; removed Abstract Wikipedia team.

DSantamaria moved this task from Incoming to Ready on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.

cmassaro changed the status of subtask T399321: Rust-based evaluator service can run a function call in the appropriate executor and return a result from Open to In Progress.Aug 26 2025, 10:11 PM

governor rate-limiting library 👀 @cmassaro

cmassaro closed subtask T399321: Rust-based evaluator service can run a function call in the appropriate executor and return a result as Resolved.Aug 27 2025, 3:48 PM

Governor and tower are both recommended: https://docs.rs/tower/latest/tower/limit/rate/struct.RateLimitLayer.html

ecarg changed the task status from Open to In Progress.Sep 12 2025, 4:41 PM

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/409

add rate-limiting to rustversion

ecarg claimed this task.Sep 17 2025, 10:24 PM

DSantamaria moved this task from Ready to In Engineering on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.Sep 18 2025, 5:18 AM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/409

add rate-limiting to rustversion

Maintenance_bot removed a project: Patch-For-Review.Sep 30 2025, 8:32 PM

Moving straight to sign-off as it doesn't get deployed.

Change #1192973 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2025-09-24-083919 to 2025-09-30-194529

https://gerrit.wikimedia.org/r/1192973

gerritbot added a project: Patch-For-Review.Oct 1 2025, 8:49 PM

Change #1192973 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2025-09-24-083919 to 2025-09-30-194529

https://gerrit.wikimedia.org/r/1192973

Maintenance_bot removed a project: Patch-For-Review.Oct 1 2025, 9:32 PM

Jdforrester-WMF closed this task as Resolved.Oct 2 2025, 4:27 PM

cmassaro mentioned this in rMSFEd73b9f000d6b: add rate-limiting to rustversion.Oct 3 2025, 9:45 AM

ecarg added a subtask: T407588: Create a fail-fast for rate-limiting.Oct 16 2025, 11:56 PM

Jdforrester-WMF changed the status of subtask T407588: Create a fail-fast for rate-limiting from Open to In Progress.Feb 6 2026, 3:22 PM

Maintenance_bot edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (26Q1 (Jul–Sep)).Feb 6 2026, 3:30 PM

DSantamaria edited projects, added Abstract Wikipedia team (26Q3 (Jan–Mar)); removed Abstract Wikipedia team.Mar 5 2026, 8:50 AM

Jdforrester-WMF closed subtask T407588: Create a fail-fast for rate-limiting as Resolved.Wed, Mar 18, 2:17 PM