Page MenuHomePhabricator
Create Task
Maniphest T399429

Clean up unused parameters of private methods
Closed, ResolvedPublic
Actions

Description

In https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/1168603/2/.phan/config.php the new sniff for unused parameters in private methods was disabled to allow for upgrading.

These no-longer used parameters for methods can often just be dropped, but we should double-check first that them being unused is not a bug.

Steps to approach:

  1. remove te line $cfg['suppress_issue_types'][] = 'PhanUnusedPrivateMethodParameter'; from .phan/config.php
  2. handle all the phan failures that happen as a result of that

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Remove unused private method parameterCyndywikimemediawiki/extensions/GrowthExperimentsmaster+14 -12
Customize query in gerrit

Event Timeline

Michael created this task.Jul 14 2025, 6:20 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2025, 6:20 AM
Michael triaged this task as Low priority.Jul 14 2025, 6:21 AM
DMburugu edited projects, added: Growth Team Maintenance; removed: Growth-Team (Maintenance).Oct 8 2025, 11:39 AM
DMburugu moved this task from Backlog to Unused code removal & deprecations on the Growth Team Maintenance board.
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 8 2025, 11:39 AM
Michael moved this task from Inbox to Triaged on the Growth-Team board.Oct 17 2025, 2:25 PM
Cyndymediawiksim claimed this task.Dec 10 2025, 5:13 PM
gerritbot added a comment.Dec 10 2025, 7:33 PM

Change #1217266 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Remove unused private method parameter

https://gerrit.wikimedia.org/r/1217266

gerritbot added a project: Patch-For-Review.Dec 10 2025, 7:33 PM
Cyndymediawiksim edited projects, added: Growth-Team (FY2025-26 Q2 Sprint 5); removed: Growth-Team.Dec 10 2025, 7:56 PM
Cyndymediawiksim moved this task from Incoming to Doing on the Growth-Team (FY2025-26 Q2 Sprint 5) board.
Cyndymediawiksim moved this task from Doing to Code Review on the Growth-Team (FY2025-26 Q2 Sprint 5) board.Dec 11 2025, 10:53 AM
Sgs moved this task from Code Review to Doing on the Growth-Team (FY2025-26 Q2 Sprint 5) board.Dec 16 2025, 12:11 PM
KStoller-WMF edited projects, added: Growth-Team (FY2025-26 Q2 Sprint 6); removed: Growth-Team (FY2025-26 Q2 Sprint 5).Dec 16 2025, 5:42 PM
Cyndymediawiksim moved this task from Incoming to Doing on the Growth-Team (FY2025-26 Q2 Sprint 6) board.Jan 7 2026, 1:16 PM
Cyndymediawiksim moved this task from Doing to Code Review on the Growth-Team (FY2025-26 Q2 Sprint 6) board.
KStoller-WMF edited projects, added: Growth-Team (FY2025-26 Q3 Sprint 1); removed: Growth-Team (FY2025-26 Q2 Sprint 6).Jan 13 2026, 7:53 PM
KStoller-WMF moved this task from Incoming to Code Review on the Growth-Team (FY2025-26 Q3 Sprint 1) board.
gerritbot added a comment.Jan 16 2026, 11:48 AM

Change #1217266 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove unused private method parameter

https://gerrit.wikimedia.org/r/1217266

Maintenance_bot removed a project: Patch-For-Review.Jan 16 2026, 12:31 PM
Cyndymediawiksim moved this task from Code Review to QA on the Growth-Team (FY2025-26 Q3 Sprint 1) board.Jan 19 2026, 8:02 AM
Etonkovidova closed this task as Resolved.Jan 22 2026, 8:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits