Page MenuHomePhabricator

UI fixes for multi delete
Closed, ResolvedPublic2 Estimated Story Points

Description

This task is a followup for T395820: Implementing new PatchDemo multi-environment-deletion UI. There are a couple of useful UI tweaks that could make multi-delete nicer.

See @A_smart_kitten 's comments below.

Thanks for the work that's been done on this! :)
A few notes from some things I noticed with the new UI elements (let me know if you'd like me to file any/all of these as separate tasks!):

1) At the moment, it seems like the checkboxes are slightly vertically-misaligned with the linked wiki-IDs. It also feels (IMO) like there could be a little bit of extra padding added to the right of each checkbox, before each wiki's ID:

screenshot.png (692×308 px, 21 KB)

2) When scrolling down the page, the checkboxes overlap the sticky table headers at the top of the page:

screenshot.png (507×274 px, 20 KB)

3) When hovering over the "Delete selected" link, it doesn't become underlined, which makes it feel different from the other links on the page/less like a link:

comparing this (hovering over the linked wiki ID)to this (hovering over the "Delete selected" link)
screenshot.png (233×135 px, 6 KB)
screenshot.png (249×94 px, 4 KB)

4) My browser's developer tools complains to me that the checkbox elements don't have labels. (I don't know whether or not this presents any issues within the UI, but I thought it might be worth noting):

screenshot.png (634×111 px, 16 KB)

Event Timeline

Checkboxes line up, but now we've got a weird thing with sticky headers in firefox. But this is not a new problem, so let's close this one out and document the weird sticky headers behavior in our backlog.