Page MenuHomePhabricator

Add remove support button to wish and focus area pages
Closed, ResolvedPublic5 Estimated Story Points

Description

Background

This is the frontend task that goes with T404136: Add API module for voting to allow users to update or remove their votes. The new API allows users to edit or remove votes, so we'd like to expose this in the Voting section of wishes and focus area detail pages.

Designs

This is what I have now. Subject to @JSengupta-WMF's feedback.

Screenshot from 2025-09-30 14-59-58.png (1,231×1,066 px, 157 KB)
Screenshot from 2025-09-30 15-00-04.png (1,231×1,066 px, 194 KB)
Screenshot from 2025-09-30 15-00-11.png (1,231×1,066 px, 163 KB)
Screenshot from 2025-09-30 15-00-24.png (1,231×1,066 px, 144 KB)

I realize the dialog should say "Update comment" when updating.

Acceptance criteria
  • After voting, the voting button should instead be replaced with a message "You've already supported this wish" (or "focus area").
  • Next to the above message should be two quiet buttons, "Edit comment" (progressive) and "Remove support" (destructive)
  • "Edit comment" should open the same familiar dialog and allow changes to the comment
  • "Remove support" should open a confirmation dialog with a Yes/No
  • On submissions, the page should be refreshed with the vote and vote count updated accordingly

Event Timeline

JWheeler-WMF subscribed.

For now, we can pause on this task. It is unclear if volunteers will really want to rescind their support of a wish.

Samwilson changed the task status from Open to Stalled.Sep 1 2025, 2:47 AM
MusikAnimal changed the task status from Stalled to Open.Sep 23 2025, 1:47 AM
MusikAnimal claimed this task.
MusikAnimal moved this task from Voting to v2 on the MediaWiki-extensions-CommunityRequests board.
MusikAnimal set the point value for this task to 5.
MusikAnimal raised the priority of this task from Low to Medium.Sep 30 2025, 7:04 PM

@JSengupta-WMF Could you review the screenshots and acceptance criteria and let me know what you think?

Change #1192316 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CommunityRequests@master] voting: use new action=wishlistedit API and add ability to edit/rm votes

https://gerrit.wikimedia.org/r/1192316

@MusikAnimal thanks for taking a pass on it proactively. I have now updated the designs so please follow the button style and the user flow as per https://www.figma.com/design/JcTMFwbEJPpCKBiZ16Jkel/Future-of-the-Wishlist?node-id=3797-150914&t=Lv3TuFAAJWBHd1Lf-1.

Please refer to the Notes on the pink sticky on Figma too.

We don't need the view all wish link on the success message when the user removes a vote.

Change #1192316 merged by jenkins-bot:

[mediawiki/extensions/CommunityRequests@master] voting: use new action=wishlistedit API and add ability to edit/rm votes

https://gerrit.wikimedia.org/r/1192316

MusikAnimal changed the task status from Open to In Progress.Oct 14 2025, 5:56 AM
MusikAnimal changed the task status from In Progress to Open.Oct 14 2025, 6:57 AM
dom_walden subscribed.

I have been adding, updating and removing support for wishes and focus areas on beta.

I tested on Firefox, Safari and iPhone.

I did some testing of how it handled error conditions, and it seemed fairly graceful.