Page MenuHomePhabricator
Create Task
Maniphest T399556

SelectionManager: Add the ability to draw bounding rectangle selections
Closed, ResolvedPublic
Actions

Description

In EditCheck we are experimenting with a selection highlight based on a bounding rectangle, which is not currently possible in SelectionManager:

image.png (166×589 px, 126 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (307c0c15a)mediawiki/extensions/VisualEditormaster+5 -4
Update VE core submodule to master (276febcab)mediawiki/extensions/VisualEditormaster+3 -1
SelectionManager: Allow bounding rects to be drawnVisualEditor/VisualEditormaster+83 -39
Customize query in gerrit

Event Timeline

Esanders created this task.Jul 15 2025, 10:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2025, 10:43 AM
Esanders attached a referenced file: F64557629: image.png. (Show Details)Jul 15 2025, 10:44 AM
gerritbot added a comment.Jul 15 2025, 10:44 AM

Change #1169631 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] SelectionManager: Allow bounding rets to be drawn

https://gerrit.wikimedia.org/r/1169631

gerritbot added a project: Patch-For-Review.Jul 15 2025, 10:44 AM
Esanders moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.Jul 15 2025, 10:44 AM
PatchDemoBot added a comment.Jul 17 2025, 2:27 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/ec736e8900/wiki/Douglas Adams?veaction=edit&ecenable=2

gerritbot added a comment.Jul 29 2025, 5:38 PM

Change #1169631 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] SelectionManager: Allow bounding rects to be drawn

https://gerrit.wikimedia.org/r/1169631

Maintenance_bot removed a project: Patch-For-Review.Jul 29 2025, 6:30 PM
gerritbot added a comment.Jul 30 2025, 2:35 PM

Change #1174480 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (276febcab)

https://gerrit.wikimedia.org/r/1174480

gerritbot added a project: Patch-For-Review.Jul 30 2025, 2:35 PM
gerritbot added a comment.Jul 30 2025, 2:45 PM

Change #1174391 had a related patch set uploaded (by Esanders; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (276febcab)

https://gerrit.wikimedia.org/r/1174391

gerritbot added a comment.Jul 30 2025, 2:45 PM

Change #1174480 abandoned by Esanders:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (276febcab)

Reason:

I9f2a08d1c98420197aea2c38fa0e4a0c6d099c66

https://gerrit.wikimedia.org/r/1174480

gerritbot added a comment.Jul 30 2025, 5:07 PM

Change #1174391 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (307c0c15a)

https://gerrit.wikimedia.org/r/1174391

Maintenance_bot removed a project: Patch-For-Review.Jul 30 2025, 5:31 PM
Esanders moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Jul 30 2025, 5:44 PM
Esanders added a project: Skipped QA.
ppelberg closed this task as Resolved.Aug 18 2025, 4:13 PM
ppelberg subscribed.

This new highlighting behavior is live: https://2c43ba9338.catalyst.wmcloud.org/w/index.php?title=Main_Page&veaction=edit&ecenable=2

PatchDemoBot added a comment.Sep 5 2025, 10:43 AM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/ec736e8900/w/

VPuffetMichel added a project: Essential-Work.Dec 8 2025, 10:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits