Page MenuHomePhabricator

Handle the proxy.go concurrency internally
Closed, ResolvedPublic3 Estimated Story Points

Description

Objective: Stop users from controlling the go worker concurrency:
The proxy.go go workers concurrency for the NewGetLargeEntities function defaults to 3 and is controlled by the Limit field passed in the incoming request. This needs to change, allowing users to limit the result for their query is okay but concurrency should be completely managed internally.

To Do

  • Implement the solution

**//Notes from tech session://**

  1. We will update the default limit to 1 (current is 3)
  2. We will decouple the number of go-routines from limit. We will only spawn 1 go-routine for going over the projects and returning results.
  • Testing**

Renil will help with testing when doing the QPS benchmarking

Event Timeline

Question from @KMontalva-WMF : is this ticket about separating the limit parameter from the request or also making sure it won't go past a certain limit?

To be discussed: Performance parameters, best practices, team agreed to do an investigation, present to the team and then implement this ticket

JArguello-WMF set the point value for this task to 5.Jul 23 2025, 1:37 PM

The team will rewrite this ticket to rescope and reassess

JArguello-WMF changed the point value for this task from 5 to 3.