" in XML::tags by closeElement($element)
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	• bzimport
	Jun 26 2012, 10:23 AM

Description

Author: nico_zeeders

Description:
In Xml.php, function 'tags' calls openElement() next to a hardcoded "</$element>". I think it would be nicer if this is substituted by closeElement($element).

Details

Reference: bz37959

	Subject	Repo	Branch	Lines +/-
	Xml::tags(): use closeElement() instead of hardcoded "</$element>"	mediawiki/core	master	+1 -1

Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 12:28 AM

• bzimport added a project: MediaWiki-User-Interface.

• bzimport set Reference to bz37959.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.Jun 26 2012, 10:23 AM

Krinkle added a project: Technical-Debt.Dec 10 2014, 2:07 PM

Krinkle set Security to None.

Krinkle removed subscribers: Unknown Object (MLST), Krinkle.

Ricordisamoa claimed this task.Jan 26 2015, 10:42 AM

Ricordisamoa added a project: good first task.

Change 186756 had a related patch set uploaded (by Ricordisamoa):
Xml::tags(): use closeElement() instead of hardcoded "</$element>"

https://gerrit.wikimedia.org/r/186756

Patch-For-Review

Krinkle removed a project: Technical-Debt.Jan 26 2015, 8:59 PM

Change 186756 abandoned by Krinkle:
Xml::tags(): use closeElement() instead of hardcoded "</$element>"

Reason:
Closing for now. Refer to T39959.

https://gerrit.wikimedia.org/r/186756

@Ricordisamoa Thanks for writing that patch, but unfortunately I don't think this is a desired change. The existing shortcut was there on purpose.

Krinkle closed this task as Resolved.Jan 27 2015, 9:48 PM

Krinkle updated the task description. (Show Details)

Krinkle removed a project: Patch-For-Review.

Krinkle removed a subscriber: gerritbot.

In T39959#996757, @Krinkle wrote:

@Ricordisamoa Thanks for writing that patch, but unfortunately I don't think this is a desired change. The existing shortcut was there on purpose.

I also think it isn't desired.
Maybe "declined"?

In T39959#996785, @Ricordisamoa wrote:

In T39959#996757, @Krinkle wrote:

@Ricordisamoa Thanks for writing that patch, but unfortunately I don't think this is a desired change. The existing shortcut was there on purpose.

I also think it isn't desired.
Maybe "declined"?

ping?

It's already closed, but sure. Let's use status Declined then.

Replace hardcoded "</$element>" in XML::tags by closeElement($element)Closed, DeclinedPublicActions

Description

Details

Event Timeline

Replace hardcoded "</$element>" in XML::tags by closeElement($element)
Closed, DeclinedPublic
Actions